Branch '389-ds-base-1.3.3' - ldap/servers
by Noriko Hosoi
ldap/servers/slapd/bind.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 03bee0a0d4dbe313bca88cfafc605f6cb01b9fdc
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Sat May 9 18:55:39 2015 -0700
Ticket #48183 - bind on db chained to AD returns err=32
Description by rmeggins(a)redhat.com: bind is doing a search for the entry
post bind, which fails because we don't enable password policy chaining
by default. I think in this case, we should not look up password policy,
because if the remote is AD or some other non-389 server, we can't use
the password policy information. We should instead rely on the remote
server to evaluate the password policy.
The commit 4fc53e1a63222d0ff67c30a59f2cff4b535f90a8 introduced the bug.
Ticket #47748 - Simultaneous adding a user and binding as the user could
fail in the password policy check
https://fedorahosted.org/389/ticket/48183
Revewed by nhosoi(a)redhat.com.
(cherry picked from commit eb46e6f1975b19956bb38d5e070e6eb5159200b4)
diff --git a/ldap/servers/slapd/bind.c b/ldap/servers/slapd/bind.c
index 70d2d19..acc65ce 100644
--- a/ldap/servers/slapd/bind.c
+++ b/ldap/servers/slapd/bind.c
@@ -777,7 +777,8 @@ do_bind( Slapi_PBlock *pb )
* was in be_bind. Since be_bind returned SLAPI_BIND_SUCCESS,
* the entry is in the DS. So, we need to retrieve it once more.
*/
- if (!bind_target_entry) {
+ if (!slapi_be_is_flag_set(be, SLAPI_BE_FLAG_REMOTE_DATA) &&
+ !bind_target_entry) {
bind_target_entry = get_entry(pb, slapi_sdn_get_ndn(sdn));
if (bind_target_entry) {
myrc = slapi_check_account_lock(pb, bind_target_entry,
8 years, 11 months
ldap/servers
by Noriko Hosoi
ldap/servers/slapd/bind.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit eb46e6f1975b19956bb38d5e070e6eb5159200b4
Author: Noriko Hosoi <nhosoi(a)redhat.com>
Date: Sat May 9 18:55:39 2015 -0700
Ticket #48183 - bind on db chained to AD returns err=32
Description by rmeggins(a)redhat.com: bind is doing a search for the entry
post bind, which fails because we don't enable password policy chaining
by default. I think in this case, we should not look up password policy,
because if the remote is AD or some other non-389 server, we can't use
the password policy information. We should instead rely on the remote
server to evaluate the password policy.
The commit 4fc53e1a63222d0ff67c30a59f2cff4b535f90a8 introduced the bug.
Ticket #47748 - Simultaneous adding a user and binding as the user could
fail in the password policy check
https://fedorahosted.org/389/ticket/48183
Revewed by nhosoi(a)redhat.com.
diff --git a/ldap/servers/slapd/bind.c b/ldap/servers/slapd/bind.c
index 70d2d19..acc65ce 100644
--- a/ldap/servers/slapd/bind.c
+++ b/ldap/servers/slapd/bind.c
@@ -777,7 +777,8 @@ do_bind( Slapi_PBlock *pb )
* was in be_bind. Since be_bind returned SLAPI_BIND_SUCCESS,
* the entry is in the DS. So, we need to retrieve it once more.
*/
- if (!bind_target_entry) {
+ if (!slapi_be_is_flag_set(be, SLAPI_BE_FLAG_REMOTE_DATA) &&
+ !bind_target_entry) {
bind_target_entry = get_entry(pb, slapi_sdn_get_ndn(sdn));
if (bind_target_entry) {
myrc = slapi_check_account_lock(pb, bind_target_entry,
8 years, 11 months
admserv/newinst
by Mark Reynolds
admserv/newinst/src/register-ds-admin.pl.in | 2 ++
1 file changed, 2 insertions(+)
New commits:
commit c3e77fb4d6d6f4db8e577c96214bd39179c5c9e0
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Fri May 22 16:43:08 2015 -0400
Ticket 47548 - register-ds-admin.pl fails to set local bind DN and password
Description: During a interactive session the local bind DN and password
are not correctly set.
https://fedorahosted.org/389/ticket/47548
Reviewed by: nhosoi(Thanks!)
diff --git a/admserv/newinst/src/register-ds-admin.pl.in b/admserv/newinst/src/register-ds-admin.pl.in
index 08c7108..aebe0ba 100644
--- a/admserv/newinst/src/register-ds-admin.pl.in
+++ b/admserv/newinst/src/register-ds-admin.pl.in
@@ -605,6 +605,8 @@ $setup->msg('register_new_confds', $new_confdsid);
if ($silent eq "no"){
$setup->{inf}->{slapd}->{RootDNPwd} = reg_get_passwd($setup, 'input_rootdn_passwd', $new_confdsid);
+ $localrootpw = $setup->{inf}->{slapd}->{RootDNPwd};
+ $localrootdn = $setup->{inf}->{slapd}->{RootDN};
}
if ( ($#admConfKeys >= 0 && ($orig_confdsid ne $new_confdsid)) ||
8 years, 11 months
Branch '389-ds-base-1.3.3' - dirsrvtests/tickets
by Mark Reynolds
dirsrvtests/tickets/ticket47553_rdn_write_test.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 9ba030fb4525523f177498fe5d558a5ac86b096f
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Thu May 21 15:49:21 2015 -0400
Ticket 47753 - Fix testecase
Description: The pytest fixture was commented out, which broke the test
when using py.test.
https://fedorahosted.org/389/ticket/47753
Reviewed by: mreynolds
(cherry picked from commit 513393bf2ddc492413bbb6a8f061f45b1c0dc57b)
diff --git a/dirsrvtests/tickets/ticket47553_rdn_write_test.py b/dirsrvtests/tickets/ticket47553_rdn_write_test.py
index f15d9b3..826e709 100644
--- a/dirsrvtests/tickets/ticket47553_rdn_write_test.py
+++ b/dirsrvtests/tickets/ticket47553_rdn_write_test.py
@@ -24,13 +24,14 @@ DST_ENTRY_CN = SRC_ENTRY_CN + EXT_RDN
SRC_ENTRY_DN = "cn=%s,%s" % (SRC_ENTRY_CN, SUFFIX)
DST_ENTRY_DN = "cn=%s,%s" % (DST_ENTRY_CN, SUFFIX)
+
class TopologyStandalone(object):
def __init__(self, standalone):
standalone.open()
self.standalone = standalone
-#(a)pytest.fixture(scope="module")
+(a)pytest.fixture(scope="module")
def topology(request):
global installation1_prefix
@@ -55,6 +56,7 @@ def topology(request):
return TopologyStandalone(standalone)
+
def test_ticket47553_rdn_write_init(topology):
topology.standalone.log.info("\n\n######################### Add entry tuser ######################\n")
topology.standalone.add_s(Entry((SRC_ENTRY_DN, {
@@ -62,6 +64,7 @@ def test_ticket47553_rdn_write_init(topology):
'sn': SRC_ENTRY_CN,
'cn': SRC_ENTRY_CN})))
+
def test_ticket47553_rdn_write_get_ger(topology):
ANONYMOUS_DN = ""
topology.standalone.log.info("\n\n######################### GER rights for anonymous ######################\n")
@@ -75,6 +78,7 @@ def test_ticket47553_rdn_write_get_ger(topology):
topology.standalone.log.info("############### entryLevelRights: %r" % value)
assert 'n' not in value
+
def test_ticket47553_rdn_write_modrdn_anonymous(topology):
ANONYMOUS_DN = ""
topology.standalone.close()
@@ -82,13 +86,11 @@ def test_ticket47553_rdn_write_modrdn_anonymous(topology):
topology.standalone.open()
msg_id = topology.standalone.search_ext("", ldap.SCOPE_BASE, "objectclass=*")
rtype, rdata, rmsgid, response_ctrl = topology.standalone.result3(msg_id)
- value = ''
for dn, attrs in rdata:
topology.standalone.log.info("dn: %s" % dn)
for attr in attrs:
topology.standalone.log.info("############### %r: %r" % (attr, attrs[attr]))
-
try:
topology.standalone.rename_s(SRC_ENTRY_DN, "cn=%s" % DST_ENTRY_CN, delold=True)
except Exception as e:
@@ -102,6 +104,7 @@ def test_ticket47553_rdn_write_modrdn_anonymous(topology):
topology.standalone.log.info("The entry was not renamed (expected)")
isinstance(e, ldap.NO_SUCH_OBJECT)
+
def test_ticket47553_rdn_write(topology):
'''
Write your testcase here...
8 years, 11 months
dirsrvtests/tickets
by Mark Reynolds
dirsrvtests/tickets/ticket47553_rdn_write_test.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 513393bf2ddc492413bbb6a8f061f45b1c0dc57b
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Thu May 21 15:49:21 2015 -0400
Ticket 47753 - Fix testecase
Description: The pytest fixture was commented out, which broke the test
when using py.test.
https://fedorahosted.org/389/ticket/47753
Reviewed by: mreynolds
diff --git a/dirsrvtests/tickets/ticket47553_rdn_write_test.py b/dirsrvtests/tickets/ticket47553_rdn_write_test.py
index f15d9b3..826e709 100644
--- a/dirsrvtests/tickets/ticket47553_rdn_write_test.py
+++ b/dirsrvtests/tickets/ticket47553_rdn_write_test.py
@@ -24,13 +24,14 @@ DST_ENTRY_CN = SRC_ENTRY_CN + EXT_RDN
SRC_ENTRY_DN = "cn=%s,%s" % (SRC_ENTRY_CN, SUFFIX)
DST_ENTRY_DN = "cn=%s,%s" % (DST_ENTRY_CN, SUFFIX)
+
class TopologyStandalone(object):
def __init__(self, standalone):
standalone.open()
self.standalone = standalone
-#(a)pytest.fixture(scope="module")
+(a)pytest.fixture(scope="module")
def topology(request):
global installation1_prefix
@@ -55,6 +56,7 @@ def topology(request):
return TopologyStandalone(standalone)
+
def test_ticket47553_rdn_write_init(topology):
topology.standalone.log.info("\n\n######################### Add entry tuser ######################\n")
topology.standalone.add_s(Entry((SRC_ENTRY_DN, {
@@ -62,6 +64,7 @@ def test_ticket47553_rdn_write_init(topology):
'sn': SRC_ENTRY_CN,
'cn': SRC_ENTRY_CN})))
+
def test_ticket47553_rdn_write_get_ger(topology):
ANONYMOUS_DN = ""
topology.standalone.log.info("\n\n######################### GER rights for anonymous ######################\n")
@@ -75,6 +78,7 @@ def test_ticket47553_rdn_write_get_ger(topology):
topology.standalone.log.info("############### entryLevelRights: %r" % value)
assert 'n' not in value
+
def test_ticket47553_rdn_write_modrdn_anonymous(topology):
ANONYMOUS_DN = ""
topology.standalone.close()
@@ -82,13 +86,11 @@ def test_ticket47553_rdn_write_modrdn_anonymous(topology):
topology.standalone.open()
msg_id = topology.standalone.search_ext("", ldap.SCOPE_BASE, "objectclass=*")
rtype, rdata, rmsgid, response_ctrl = topology.standalone.result3(msg_id)
- value = ''
for dn, attrs in rdata:
topology.standalone.log.info("dn: %s" % dn)
for attr in attrs:
topology.standalone.log.info("############### %r: %r" % (attr, attrs[attr]))
-
try:
topology.standalone.rename_s(SRC_ENTRY_DN, "cn=%s" % DST_ENTRY_CN, delold=True)
except Exception as e:
@@ -102,6 +104,7 @@ def test_ticket47553_rdn_write_modrdn_anonymous(topology):
topology.standalone.log.info("The entry was not renamed (expected)")
isinstance(e, ldap.NO_SUCH_OBJECT)
+
def test_ticket47553_rdn_write(topology):
'''
Write your testcase here...
8 years, 11 months
Branch '389-ds-base-1.3.3' - dirsrvtests/tickets
by Mark Reynolds
dirsrvtests/tickets/ticket47828_test.py | 1 -
1 file changed, 1 deletion(-)
New commits:
commit 148e5108a7738e4f8ef7a7a45a2a330020e35921
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Tue May 19 16:46:47 2015 -0400
Ticket 47828 - fix testcase "import" issue
Description: An invalid "import" for constants needs to be removed
https://fedorahosted.org/389/ticket/47828
Reviewed by: mreynolds
(cherry picked from commit 4606c8b65452106785c44ecf2a27720697be66ac)
diff --git a/dirsrvtests/tickets/ticket47828_test.py b/dirsrvtests/tickets/ticket47828_test.py
index b9fb288..8135c60 100644
--- a/dirsrvtests/tickets/ticket47828_test.py
+++ b/dirsrvtests/tickets/ticket47828_test.py
@@ -10,7 +10,6 @@ from lib389 import DirSrv, Entry, tools
from lib389.tools import DirSrvTools
from lib389._constants import *
from lib389.properties import *
-from constants import *
log = logging.getLogger(__name__)
8 years, 11 months
dirsrvtests/tickets
by Mark Reynolds
dirsrvtests/tickets/ticket47828_test.py | 1 -
1 file changed, 1 deletion(-)
New commits:
commit 4606c8b65452106785c44ecf2a27720697be66ac
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Tue May 19 16:46:47 2015 -0400
Ticket 47828 - fix testcase "import" issue
Description: An invalid "import" for constants needs to be removed
https://fedorahosted.org/389/ticket/47828
Reviewed by: mreynolds
diff --git a/dirsrvtests/tickets/ticket47828_test.py b/dirsrvtests/tickets/ticket47828_test.py
index b9fb288..8135c60 100644
--- a/dirsrvtests/tickets/ticket47828_test.py
+++ b/dirsrvtests/tickets/ticket47828_test.py
@@ -10,7 +10,6 @@ from lib389 import DirSrv, Entry, tools
from lib389.tools import DirSrvTools
from lib389._constants import *
from lib389.properties import *
-from constants import *
log = logging.getLogger(__name__)
8 years, 11 months
Branch '389-ds-base-1.2.11' - ldap/servers
by Mark Reynolds
ldap/servers/plugins/replication/repl5_replica_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit fd427d1db9820ce3bb81e2b72e20caa7e35bf6f9
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Mon May 18 14:51:55 2015 -0400
Ticket 48158 - cleanAllRUV task limit not being enforced correctly
Bug Description: The task limit check was only counting tasks that had
already begun the cleaning process. If the task was waiting
for a replica to be online before it starting the cleaning
process, then task count was not incremented, and limit
check was essentially bypassed.
Fix Description: Use the "pre-cleaned" rid list to determine the task count.
The pre-cleaned list is updated as soon a task request
comes in - not once the cleaning starts.
https://fedorahosted.org/389/ticket/48158
Reviwed by: nhosoi(Thanks!)
(cherry picked from commit d774b19fe6a1626cca3c92b125e56a22771bba5a)
diff --git a/ldap/servers/plugins/replication/repl5_replica_config.c b/ldap/servers/plugins/replication/repl5_replica_config.c
index a9aeed3..ae4c2ff 100644
--- a/ldap/servers/plugins/replication/repl5_replica_config.c
+++ b/ldap/servers/plugins/replication/repl5_replica_config.c
@@ -3152,7 +3152,7 @@ get_cleanruv_task_count()
slapi_rwlock_wrlock(rid_lock);
for(i = 0; i < CLEANRIDSIZ; i++){
- if(cleaned_rids[i] != 0){
+ if(pre_cleaned_rids[i] != 0){
count++;
}
}
8 years, 11 months
Branch '389-ds-base-1.3.1' - ldap/servers
by Mark Reynolds
ldap/servers/plugins/replication/repl5_replica_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 35f75cea094460f108a2a794bb7571985d4bd24d
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Mon May 18 14:51:55 2015 -0400
Ticket 48158 - cleanAllRUV task limit not being enforced correctly
Bug Description: The task limit check was only counting tasks that had
already begun the cleaning process. If the task was waiting
for a replica to be online before it starting the cleaning
process, then task count was not incremented, and limit
check was essentially bypassed.
Fix Description: Use the "pre-cleaned" rid list to determine the task count.
The pre-cleaned list is updated as soon a task request
comes in - not once the cleaning starts.
https://fedorahosted.org/389/ticket/48158
Reviwed by: nhosoi(Thanks!)
(cherry picked from commit d774b19fe6a1626cca3c92b125e56a22771bba5a)
diff --git a/ldap/servers/plugins/replication/repl5_replica_config.c b/ldap/servers/plugins/replication/repl5_replica_config.c
index 3345005..73eef6f 100644
--- a/ldap/servers/plugins/replication/repl5_replica_config.c
+++ b/ldap/servers/plugins/replication/repl5_replica_config.c
@@ -3259,7 +3259,7 @@ get_cleanruv_task_count()
slapi_rwlock_wrlock(rid_lock);
for(i = 0; i < CLEANRIDSIZ; i++){
- if(cleaned_rids[i] != 0){
+ if(pre_cleaned_rids[i] != 0){
count++;
}
}
8 years, 11 months
Branch '389-ds-base-1.3.2' - ldap/servers
by Mark Reynolds
ldap/servers/plugins/replication/repl5_replica_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 31f73113fd266a72878a8d6c07f099b6a1b84e29
Author: Mark Reynolds <mreynolds(a)redhat.com>
Date: Mon May 18 14:51:55 2015 -0400
Ticket 48158 - cleanAllRUV task limit not being enforced correctly
Bug Description: The task limit check was only counting tasks that had
already begun the cleaning process. If the task was waiting
for a replica to be online before it starting the cleaning
process, then task count was not incremented, and limit
check was essentially bypassed.
Fix Description: Use the "pre-cleaned" rid list to determine the task count.
The pre-cleaned list is updated as soon a task request
comes in - not once the cleaning starts.
https://fedorahosted.org/389/ticket/48158
Reviwed by: nhosoi(Thanks!)
(cherry picked from commit d774b19fe6a1626cca3c92b125e56a22771bba5a)
diff --git a/ldap/servers/plugins/replication/repl5_replica_config.c b/ldap/servers/plugins/replication/repl5_replica_config.c
index 9944a7b..e025d4f 100644
--- a/ldap/servers/plugins/replication/repl5_replica_config.c
+++ b/ldap/servers/plugins/replication/repl5_replica_config.c
@@ -3334,7 +3334,7 @@ get_cleanruv_task_count()
slapi_rwlock_wrlock(rid_lock);
for(i = 0; i < CLEANRIDSIZ; i++){
- if(cleaned_rids[i] != 0){
+ if(pre_cleaned_rids[i] != 0){
count++;
}
}
8 years, 11 months