[389-ds-base] branch 389-ds-base-1.3.10 updated: Issue 50886 - Typo in the replication debug message
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.3.10
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.3.10 by this push:
new 33bf3e7 Issue 50886 - Typo in the replication debug message
33bf3e7 is described below
commit 33bf3e77c63e471145273b51f285ae3af404c65d
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Thu Feb 6 14:38:04 2020 -0500
Issue 50886 - Typo in the replication debug message
Description: Fix typo in replication logging message
relates: https://pagure.io/389-ds-base/issue/50886
Reviewed by: mreynolds (one line commit rule)
---
ldap/servers/plugins/replication/repl5_plugins.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ldap/servers/plugins/replication/repl5_plugins.c b/ldap/servers/plugins/replication/repl5_plugins.c
index 324e382..bd66e20 100644
--- a/ldap/servers/plugins/replication/repl5_plugins.c
+++ b/ldap/servers/plugins/replication/repl5_plugins.c
@@ -626,7 +626,7 @@ multimaster_mmr_postop (Slapi_PBlock *pb, int flags)
break;
}
slapi_log_err(SLAPI_LOG_REPL, REPLICATION_SUBSYSTEM,
- "multimaster_mmr_postop - error %d for oparation %d.\n", rc, flags);
+ "multimaster_mmr_postop - error %d for operation %d.\n", rc, flags);
return rc;
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] branch 389-ds-base-1.4.1 updated: Issue 50886 - Typo in the replication debug message
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.1 by this push:
new 9928e5b Issue 50886 - Typo in the replication debug message
9928e5b is described below
commit 9928e5bcbfed20a91de97628e5e84df34723533e
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Thu Feb 6 14:38:04 2020 -0500
Issue 50886 - Typo in the replication debug message
Description: Fix typo in replication logging message
relates: https://pagure.io/389-ds-base/issue/50886
Reviewed by: mreynolds (one line commit rule)
---
ldap/servers/plugins/replication/repl5_plugins.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ldap/servers/plugins/replication/repl5_plugins.c b/ldap/servers/plugins/replication/repl5_plugins.c
index e6b2fdb..caa99d1 100644
--- a/ldap/servers/plugins/replication/repl5_plugins.c
+++ b/ldap/servers/plugins/replication/repl5_plugins.c
@@ -622,7 +622,7 @@ multimaster_mmr_postop (Slapi_PBlock *pb, int flags)
break;
}
slapi_log_err(SLAPI_LOG_REPL, REPLICATION_SUBSYSTEM,
- "multimaster_mmr_postop - error %d for oparation %d.\n", rc, flags);
+ "multimaster_mmr_postop - error %d for operation %d.\n", rc, flags);
return rc;
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] branch 389-ds-base-1.4.2 updated: Issue 50886 - Typo in the replication debug message
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.2
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.2 by this push:
new 2b6c1bb Issue 50886 - Typo in the replication debug message
2b6c1bb is described below
commit 2b6c1bb3fe347d64d15c8bd2d5a93bdc4dddaf67
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Thu Feb 6 14:38:04 2020 -0500
Issue 50886 - Typo in the replication debug message
Description: Fix typo in replication logging message
relates: https://pagure.io/389-ds-base/issue/50886
Reviewed by: mreynolds (one line commit rule)
---
ldap/servers/plugins/replication/repl5_plugins.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ldap/servers/plugins/replication/repl5_plugins.c b/ldap/servers/plugins/replication/repl5_plugins.c
index e6b2fdb..caa99d1 100644
--- a/ldap/servers/plugins/replication/repl5_plugins.c
+++ b/ldap/servers/plugins/replication/repl5_plugins.c
@@ -622,7 +622,7 @@ multimaster_mmr_postop (Slapi_PBlock *pb, int flags)
break;
}
slapi_log_err(SLAPI_LOG_REPL, REPLICATION_SUBSYSTEM,
- "multimaster_mmr_postop - error %d for oparation %d.\n", rc, flags);
+ "multimaster_mmr_postop - error %d for operation %d.\n", rc, flags);
return rc;
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] branch master updated: Issue 50886 - Typo in the replication debug message
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch master
in repository 389-ds-base.
The following commit(s) were added to refs/heads/master by this push:
new d8988cc Issue 50886 - Typo in the replication debug message
d8988cc is described below
commit d8988cc3696e409f5676676b5c379ef83697d60d
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Thu Feb 6 14:38:04 2020 -0500
Issue 50886 - Typo in the replication debug message
Description: Fix typo in replication logging message
relates: https://pagure.io/389-ds-base/issue/50886
Reviewed by: mreynolds (one line commit rule)
---
ldap/servers/plugins/replication/repl5_plugins.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ldap/servers/plugins/replication/repl5_plugins.c b/ldap/servers/plugins/replication/repl5_plugins.c
index e6b2fdb..caa99d1 100644
--- a/ldap/servers/plugins/replication/repl5_plugins.c
+++ b/ldap/servers/plugins/replication/repl5_plugins.c
@@ -622,7 +622,7 @@ multimaster_mmr_postop (Slapi_PBlock *pb, int flags)
break;
}
slapi_log_err(SLAPI_LOG_REPL, REPLICATION_SUBSYSTEM,
- "multimaster_mmr_postop - error %d for oparation %d.\n", rc, flags);
+ "multimaster_mmr_postop - error %d for operation %d.\n", rc, flags);
return rc;
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] 02/02: Issue 50873 - Fix healthcheck and virtual attr check
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
commit 751d8cfd97533e620e708b81c0b116d19d2b3df7
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Wed Feb 5 09:48:15 2020 -0500
Issue 50873 - Fix healthcheck and virtual attr check
Description: Used the wrong DN to lookup COS definitions
relates: https://pagure.io/389-ds-base/issue/50873
Reviewed by: mreynolds (one line commit rule)
---
src/lib389/lib389/backend.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib389/lib389/backend.py b/src/lib389/lib389/backend.py
index e829ad6..8173c1b 100644
--- a/src/lib389/lib389/backend.py
+++ b/src/lib389/lib389/backend.py
@@ -438,7 +438,7 @@ class Backend(DSLdapObject):
# Check COS next
for cosDefType in [CosIndirectDefinitions, CosPointerDefinitions, CosClassicDefinitions]:
- defs = cosDefType(self._instance, self._dn).list()
+ defs = cosDefType(self._instance, suffix).list()
for cosDef in defs:
attrs = cosDef.get_attr_val_utf8_l("cosAttribute").split()
for attr in attrs:
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] 01/02: Issue 50873 - Fix issues with healthcheck tool
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
commit 5a659ec2e1f3c0429b1a7d73190e208b40ba5cd6
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Fri Jan 31 16:36:28 2020 -0500
Issue 50873 - Fix issues with healthcheck tool
Description:
- Wrong error code reported with result for backend check
- Disk Space Monitor check crashes because it is missing "import copy"
- On a non-LDAPI instance "dsctl healthcheck" does not prompt for bind dn, only for password.
relates: https://pagure.io/389-ds-base/issue/50873
Reviewed by: firstyear(Thanks!)
---
src/lib389/lib389/cli_base/__init__.py | 16 ++++++++++------
src/lib389/lib389/lint.py | 2 +-
src/lib389/lib389/monitor.py | 1 +
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/lib389/lib389/cli_base/__init__.py b/src/lib389/lib389/cli_base/__init__.py
index e2e6c90..7dd45b3 100644
--- a/src/lib389/lib389/cli_base/__init__.py
+++ b/src/lib389/lib389/cli_base/__init__.py
@@ -129,14 +129,18 @@ def connect_instance(dsrc_inst, verbose, args):
# No password or we chose to prompt
dsargs[SER_ROOT_PW] = getpass("Enter password for {} on {}: ".format(dsrc_inst['binddn'], dsrc_inst['uri']))
elif not ds.can_autobind():
- # No LDAPI, prompt for password
+ # No LDAPI, prompt for password, and bind DN if necessary
+ if dsrc_inst['binddn'] is None:
+ dn = ""
+ while dn == "":
+ dn = input("Enter Bind DN: ")
+ dsrc_inst['binddn'] = dn
dsargs[SER_ROOT_PW] = getpass("Enter password for {} on {}: ".format(dsrc_inst['binddn'], dsrc_inst['uri']))
- if 'binddn' in dsrc_inst:
- # Allocate is an awful interface that we should stop using, but for now
- # just directly map the dsrc_inst args in (remember, dsrc_inst DOES
- # overlay cli args into the map ...)
- dsargs[SER_ROOT_DN] = dsrc_inst['binddn']
+ # Allocate is an awful interface that we should stop using, but for now
+ # just directly map the dsrc_inst args in (remember, dsrc_inst DOES
+ # overlay cli args into the map ...)
+ dsargs[SER_ROOT_DN] = dsrc_inst['binddn']
ds = DirSrv(verbose=verbose)
ds.allocate(dsargs)
diff --git a/src/lib389/lib389/lint.py b/src/lib389/lib389/lint.py
index b2bd8cd..c6f2df3 100644
--- a/src/lib389/lib389/lint.py
+++ b/src/lib389/lib389/lint.py
@@ -47,7 +47,7 @@ DSBLE0002 = {
}
DSBLE0003 = {
- 'dsle': 'DSBLE0002',
+ 'dsle': 'DSBLE0003',
'severity': 'LOW',
'items' : [],
'detail' : """The backend database has not been initialized yet""",
diff --git a/src/lib389/lib389/monitor.py b/src/lib389/lib389/monitor.py
index 290cad5..d6413de 100644
--- a/src/lib389/lib389/monitor.py
+++ b/src/lib389/lib389/monitor.py
@@ -6,6 +6,7 @@
# See LICENSE for details.
# --- END COPYRIGHT BLOCK ---
+import copy
from lib389._constants import *
from lib389._mapped_object import DSLdapObject
from lib389.utils import (ds_is_older)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] 02/02: Issue 50873 - Fix healthcheck and virtual attr check
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.2
in repository 389-ds-base.
commit 472045a3fd064d8b78fb9b17103f80323aeb9181
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Wed Feb 5 09:48:15 2020 -0500
Issue 50873 - Fix healthcheck and virtual attr check
Description: Used the wrong DN to lookup COS definitions
relates: https://pagure.io/389-ds-base/issue/50873
Reviewed by: mreynolds (one line commit rule)
---
src/lib389/lib389/backend.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib389/lib389/backend.py b/src/lib389/lib389/backend.py
index ac2af02..86ee33e 100644
--- a/src/lib389/lib389/backend.py
+++ b/src/lib389/lib389/backend.py
@@ -438,7 +438,7 @@ class Backend(DSLdapObject):
# Check COS next
for cosDefType in [CosIndirectDefinitions, CosPointerDefinitions, CosClassicDefinitions]:
- defs = cosDefType(self._instance, self._dn).list()
+ defs = cosDefType(self._instance, suffix).list()
for cosDef in defs:
attrs = cosDef.get_attr_val_utf8_l("cosAttribute").split()
for attr in attrs:
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] 01/02: Issue 50873 - Fix issues with healthcheck tool
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.2
in repository 389-ds-base.
commit ebd5832f2121dc5d97747c985585a44fde3b349e
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Fri Jan 31 16:36:28 2020 -0500
Issue 50873 - Fix issues with healthcheck tool
Description:
- Wrong error code reported with result for backend check
- Disk Space Monitor check crashes because it is missing "import copy"
- On a non-LDAPI instance "dsctl healthcheck" does not prompt for bind dn, only for password.
relates: https://pagure.io/389-ds-base/issue/50873
Reviewed by: firstyear(Thanks!)
---
src/lib389/lib389/cli_base/__init__.py | 16 ++++++++++------
src/lib389/lib389/lint.py | 2 +-
src/lib389/lib389/monitor.py | 1 +
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/src/lib389/lib389/cli_base/__init__.py b/src/lib389/lib389/cli_base/__init__.py
index e2e6c90..7dd45b3 100644
--- a/src/lib389/lib389/cli_base/__init__.py
+++ b/src/lib389/lib389/cli_base/__init__.py
@@ -129,14 +129,18 @@ def connect_instance(dsrc_inst, verbose, args):
# No password or we chose to prompt
dsargs[SER_ROOT_PW] = getpass("Enter password for {} on {}: ".format(dsrc_inst['binddn'], dsrc_inst['uri']))
elif not ds.can_autobind():
- # No LDAPI, prompt for password
+ # No LDAPI, prompt for password, and bind DN if necessary
+ if dsrc_inst['binddn'] is None:
+ dn = ""
+ while dn == "":
+ dn = input("Enter Bind DN: ")
+ dsrc_inst['binddn'] = dn
dsargs[SER_ROOT_PW] = getpass("Enter password for {} on {}: ".format(dsrc_inst['binddn'], dsrc_inst['uri']))
- if 'binddn' in dsrc_inst:
- # Allocate is an awful interface that we should stop using, but for now
- # just directly map the dsrc_inst args in (remember, dsrc_inst DOES
- # overlay cli args into the map ...)
- dsargs[SER_ROOT_DN] = dsrc_inst['binddn']
+ # Allocate is an awful interface that we should stop using, but for now
+ # just directly map the dsrc_inst args in (remember, dsrc_inst DOES
+ # overlay cli args into the map ...)
+ dsargs[SER_ROOT_DN] = dsrc_inst['binddn']
ds = DirSrv(verbose=verbose)
ds.allocate(dsargs)
diff --git a/src/lib389/lib389/lint.py b/src/lib389/lib389/lint.py
index b2bd8cd..c6f2df3 100644
--- a/src/lib389/lib389/lint.py
+++ b/src/lib389/lib389/lint.py
@@ -47,7 +47,7 @@ DSBLE0002 = {
}
DSBLE0003 = {
- 'dsle': 'DSBLE0002',
+ 'dsle': 'DSBLE0003',
'severity': 'LOW',
'items' : [],
'detail' : """The backend database has not been initialized yet""",
diff --git a/src/lib389/lib389/monitor.py b/src/lib389/lib389/monitor.py
index 290cad5..d6413de 100644
--- a/src/lib389/lib389/monitor.py
+++ b/src/lib389/lib389/monitor.py
@@ -6,6 +6,7 @@
# See LICENSE for details.
# --- END COPYRIGHT BLOCK ---
+import copy
from lib389._constants import *
from lib389._mapped_object import DSLdapObject
from lib389.utils import (ds_is_older)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] branch master updated: Issue 50873 - Fix healthcheck and virtual attr check
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch master
in repository 389-ds-base.
The following commit(s) were added to refs/heads/master by this push:
new c6976c1 Issue 50873 - Fix healthcheck and virtual attr check
c6976c1 is described below
commit c6976c182e7c2f957b210a5b4241c09bcda6c60d
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Wed Feb 5 09:48:15 2020 -0500
Issue 50873 - Fix healthcheck and virtual attr check
Description: Used the wrong DN to lookup COS definitions
relates: https://pagure.io/389-ds-base/issue/50873
Reviewed by: mreynolds (one line commit rule)
---
src/lib389/lib389/backend.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib389/lib389/backend.py b/src/lib389/lib389/backend.py
index ac2af02..86ee33e 100644
--- a/src/lib389/lib389/backend.py
+++ b/src/lib389/lib389/backend.py
@@ -438,7 +438,7 @@ class Backend(DSLdapObject):
# Check COS next
for cosDefType in [CosIndirectDefinitions, CosPointerDefinitions, CosClassicDefinitions]:
- defs = cosDefType(self._instance, self._dn).list()
+ defs = cosDefType(self._instance, suffix).list()
for cosDef in defs:
attrs = cosDef.get_attr_val_utf8_l("cosAttribute").split()
for attr in attrs:
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months
[389-ds-base] branch 389-ds-base-1.3.10 updated: Ticket 50857 - Memory leak in ACI using IP subject
by pagure@pagure.io
This is an automated email from the git hooks/post-receive script.
tbordaz pushed a commit to branch 389-ds-base-1.3.10
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.3.10 by this push:
new f58f732 Ticket 50857 - Memory leak in ACI using IP subject
f58f732 is described below
commit f58f732b0f9c420cc96765238767f4e06dc924dd
Author: Thierry Bordaz <tbordaz(a)redhat.com>
AuthorDate: Mon Jan 27 13:49:37 2020 +0100
Ticket 50857 - Memory leak in ACI using IP subject
Bug Description:
When a ACI is evaluated (LASIpEval) a context (cookie) is allocated.
At the end of the connection, the context is freed
via a callback (LASIpFlush).
The context contains two LASIpTree_t tree (ipv4 and ipv6)
In free callback, only ipv4 tree is freed
Fix Description:
Free ipv6 tree in LASIpTree
https://pagure.io/389-ds-base/issue/50857
Reviewed by: Mark Reynolds
Platforms tested: F31
Flag Day: no
Doc impact: no
---
lib/libaccess/lasip.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/libaccess/lasip.cpp b/lib/libaccess/lasip.cpp
index 30c546d..cdb88ee 100644
--- a/lib/libaccess/lasip.cpp
+++ b/lib/libaccess/lasip.cpp
@@ -436,6 +436,7 @@ LASIpFlush(void **las_cookie)
return;
LASIpTreeDealloc(((LASIpContext_t *)*las_cookie)->treetop);
+ LASIpTreeDealloc(((LASIpContext_t *)*las_cookie)->treetop_ipv6);
PERM_FREE(*las_cookie);
*las_cookie = NULL;
return;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years, 2 months