[389-ds-base] branch 389-ds-base-1.4.3 updated: Bump version to 1.4.3.7
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.3
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.3 by this push:
new a7d807b Bump version to 1.4.3.7
a7d807b is described below
commit a7d807bf02f42384c92e9cad8a4d1b8a3562d9b2
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Wed Apr 22 14:51:51 2020 -0400
Bump version to 1.4.3.7
---
VERSION.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/VERSION.sh b/VERSION.sh
index ebdc741..5998ad3 100644
--- a/VERSION.sh
+++ b/VERSION.sh
@@ -10,7 +10,7 @@ vendor="389 Project"
# PACKAGE_VERSION is constructed from these
VERSION_MAJOR=1
VERSION_MINOR=4
-VERSION_MAINT=3.6
+VERSION_MAINT=3.7
# NOTE: VERSION_PREREL is automatically set for builds made out of a git tree
VERSION_PREREL=
VERSION_DATE=$(date -u +%Y%m%d)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch master updated: Bump version to 1.4.4.1
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch master
in repository 389-ds-base.
The following commit(s) were added to refs/heads/master by this push:
new 2333d75 Bump version to 1.4.4.1
2333d75 is described below
commit 2333d75d54baeba8c8157d10234a915a2d7a6a25
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Wed Apr 22 14:29:43 2020 -0400
Bump version to 1.4.4.1
---
VERSION.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/VERSION.sh b/VERSION.sh
index 8df20ee..bb7dceb 100644
--- a/VERSION.sh
+++ b/VERSION.sh
@@ -10,7 +10,7 @@ vendor="389 Project"
# PACKAGE_VERSION is constructed from these
VERSION_MAJOR=1
VERSION_MINOR=4
-VERSION_MAINT=4.0
+VERSION_MAINT=4.1
# NOTE: VERSION_PREREL is automatically set for builds made out of a git tree
VERSION_PREREL=
VERSION_DATE=$(date -u +%Y%m%d)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.1 updated: Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
tbordaz pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.1 by this push:
new 11f1b55 Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
11f1b55 is described below
commit 11f1b5537417e60a6a492ebd86c5b1e4f2cf351b
Author: Thierry Bordaz <tbordaz(a)redhat.com>
AuthorDate: Mon Apr 20 15:17:03 2020 +0200
Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
Bug Description:
startTls pushes a network layer on top of the connection.
So when processing startTLS, there should not be a pending operation
else there is a risk that the operation sends back data on moving
network layer.
When startTls detects a pending operation it aborts startTls.
However if a new operation is received while processing startTls,
the operation is pending but can not be read because startTls
holds c_mutex.
Fix Description:
In case of unread pending operation, relax the control
and just log an information message.
https://pagure.io/389-ds-base/issue/51035
Reviewed by: Mark Reynolds, William Brown
Platforms tested: F30
Flag Day: no
Doc impact: no
---
ldap/servers/slapd/operation.c | 4 ++--
ldap/servers/slapd/start_tls_extop.c | 30 +++++++++++++++++++++++++-----
2 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/ldap/servers/slapd/operation.c b/ldap/servers/slapd/operation.c
index 8590e2d..ff16cd9 100644
--- a/ldap/servers/slapd/operation.c
+++ b/ldap/servers/slapd/operation.c
@@ -150,8 +150,8 @@ operation_init(Slapi_Operation *o, int flags)
/* We can't get rid of this til we remove the operation stack. */
memset(o, 0, sizeof(Slapi_Operation));
o->o_ber = ber;
- o->o_msgid = -1;
- o->o_tag = LBER_DEFAULT;
+ o->o_msgid = -1; /* if changed please update start-tls that test this value */
+ o->o_tag = LBER_DEFAULT; /* if changed please update start-tls that test this value */
o->o_status = SLAPI_OP_STATUS_PROCESSING;
slapi_sdn_init(&(o->o_sdn));
o->o_authtype = NULL;
diff --git a/ldap/servers/slapd/start_tls_extop.c b/ldap/servers/slapd/start_tls_extop.c
index bfa32b7..f415c41 100644
--- a/ldap/servers/slapd/start_tls_extop.c
+++ b/ldap/servers/slapd/start_tls_extop.c
@@ -188,11 +188,31 @@ start_tls(Slapi_PBlock *pb)
/* Check whether the Start TLS request can be accepted. */
if (connection_operations_pending(conn, pb_op,
1 /* check for ops where result not yet sent */)) {
- slapi_log_err(SLAPI_LOG_PLUGIN, "start_tls",
- "Other operations are still pending on the connection.\n");
- ldaprc = LDAP_OPERATIONS_ERROR;
- ldapmsg = "Other operations are still pending on the connection.";
- goto unlock_and_return;
+ for (Operation *op = conn->c_ops; op != NULL; op = op->o_next) {
+ if (op == pb_op) {
+ continue;
+ }
+ if ((op->o_msgid == -1) && (op->o_tag == LBER_DEFAULT)) {
+ /* while processing start-tls extop we also received a new incoming operation
+ * As this operation will not processed until start-tls completes.
+ * Be fair do not consider this operation as a pending one
+ */
+ slapi_log_err(SLAPI_LOG_CONNS, "start_tls",
+ "New incoming operation blocked by start-tls, Continue start-tls (conn=%"PRIu64").\n",
+ conn->c_connid);
+ continue;
+ } else {
+ /* It is problematic, this pending operation is processed and
+ * start-tls can push new network layer while the operation
+ * send result. Safest to abort start-tls
+ */
+ slapi_log_err(SLAPI_LOG_CONNS, "start_tls",
+ "Other operations are still pending on the connection.\n");
+ ldaprc = LDAP_OPERATIONS_ERROR;
+ ldapmsg = "Other operations are still pending on the connection.";
+ goto unlock_and_return;
+ }
+ }
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.2 updated: Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
tbordaz pushed a commit to branch 389-ds-base-1.4.2
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.2 by this push:
new 731a5b5 Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
731a5b5 is described below
commit 731a5b5d6121bddf3dddc1f859953ee273252fa1
Author: Thierry Bordaz <tbordaz(a)redhat.com>
AuthorDate: Mon Apr 20 15:17:03 2020 +0200
Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
Bug Description:
startTls pushes a network layer on top of the connection.
So when processing startTLS, there should not be a pending operation
else there is a risk that the operation sends back data on moving
network layer.
When startTls detects a pending operation it aborts startTls.
However if a new operation is received while processing startTls,
the operation is pending but can not be read because startTls
holds c_mutex.
Fix Description:
In case of unread pending operation, relax the control
and just log an information message.
https://pagure.io/389-ds-base/issue/51035
Reviewed by: Mark Reynolds, William Brown
Platforms tested: F30
Flag Day: no
Doc impact: no
---
ldap/servers/slapd/operation.c | 4 ++--
ldap/servers/slapd/start_tls_extop.c | 30 +++++++++++++++++++++++++-----
2 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/ldap/servers/slapd/operation.c b/ldap/servers/slapd/operation.c
index 8590e2d..ff16cd9 100644
--- a/ldap/servers/slapd/operation.c
+++ b/ldap/servers/slapd/operation.c
@@ -150,8 +150,8 @@ operation_init(Slapi_Operation *o, int flags)
/* We can't get rid of this til we remove the operation stack. */
memset(o, 0, sizeof(Slapi_Operation));
o->o_ber = ber;
- o->o_msgid = -1;
- o->o_tag = LBER_DEFAULT;
+ o->o_msgid = -1; /* if changed please update start-tls that test this value */
+ o->o_tag = LBER_DEFAULT; /* if changed please update start-tls that test this value */
o->o_status = SLAPI_OP_STATUS_PROCESSING;
slapi_sdn_init(&(o->o_sdn));
o->o_authtype = NULL;
diff --git a/ldap/servers/slapd/start_tls_extop.c b/ldap/servers/slapd/start_tls_extop.c
index bfa32b7..f415c41 100644
--- a/ldap/servers/slapd/start_tls_extop.c
+++ b/ldap/servers/slapd/start_tls_extop.c
@@ -188,11 +188,31 @@ start_tls(Slapi_PBlock *pb)
/* Check whether the Start TLS request can be accepted. */
if (connection_operations_pending(conn, pb_op,
1 /* check for ops where result not yet sent */)) {
- slapi_log_err(SLAPI_LOG_PLUGIN, "start_tls",
- "Other operations are still pending on the connection.\n");
- ldaprc = LDAP_OPERATIONS_ERROR;
- ldapmsg = "Other operations are still pending on the connection.";
- goto unlock_and_return;
+ for (Operation *op = conn->c_ops; op != NULL; op = op->o_next) {
+ if (op == pb_op) {
+ continue;
+ }
+ if ((op->o_msgid == -1) && (op->o_tag == LBER_DEFAULT)) {
+ /* while processing start-tls extop we also received a new incoming operation
+ * As this operation will not processed until start-tls completes.
+ * Be fair do not consider this operation as a pending one
+ */
+ slapi_log_err(SLAPI_LOG_CONNS, "start_tls",
+ "New incoming operation blocked by start-tls, Continue start-tls (conn=%"PRIu64").\n",
+ conn->c_connid);
+ continue;
+ } else {
+ /* It is problematic, this pending operation is processed and
+ * start-tls can push new network layer while the operation
+ * send result. Safest to abort start-tls
+ */
+ slapi_log_err(SLAPI_LOG_CONNS, "start_tls",
+ "Other operations are still pending on the connection.\n");
+ ldaprc = LDAP_OPERATIONS_ERROR;
+ ldapmsg = "Other operations are still pending on the connection.";
+ goto unlock_and_return;
+ }
+ }
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.3 updated: Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
tbordaz pushed a commit to branch 389-ds-base-1.4.3
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.3 by this push:
new 285fd0d Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
285fd0d is described below
commit 285fd0dfe9d35d6339eb6e7968d56638b8613df1
Author: Thierry Bordaz <tbordaz(a)redhat.com>
AuthorDate: Mon Apr 20 15:17:03 2020 +0200
Ticket 51035 - Heavy StartTLS connection load can randomly fail with err=1
Bug Description:
startTls pushes a network layer on top of the connection.
So when processing startTLS, there should not be a pending operation
else there is a risk that the operation sends back data on moving
network layer.
When startTls detects a pending operation it aborts startTls.
However if a new operation is received while processing startTls,
the operation is pending but can not be read because startTls
holds c_mutex.
Fix Description:
In case of unread pending operation, relax the control
and just log an information message.
https://pagure.io/389-ds-base/issue/51035
Reviewed by: Mark Reynolds, William Brown
Platforms tested: F30
Flag Day: no
Doc impact: no
---
ldap/servers/slapd/operation.c | 4 ++--
ldap/servers/slapd/start_tls_extop.c | 30 +++++++++++++++++++++++++-----
2 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/ldap/servers/slapd/operation.c b/ldap/servers/slapd/operation.c
index 8590e2d..ff16cd9 100644
--- a/ldap/servers/slapd/operation.c
+++ b/ldap/servers/slapd/operation.c
@@ -150,8 +150,8 @@ operation_init(Slapi_Operation *o, int flags)
/* We can't get rid of this til we remove the operation stack. */
memset(o, 0, sizeof(Slapi_Operation));
o->o_ber = ber;
- o->o_msgid = -1;
- o->o_tag = LBER_DEFAULT;
+ o->o_msgid = -1; /* if changed please update start-tls that test this value */
+ o->o_tag = LBER_DEFAULT; /* if changed please update start-tls that test this value */
o->o_status = SLAPI_OP_STATUS_PROCESSING;
slapi_sdn_init(&(o->o_sdn));
o->o_authtype = NULL;
diff --git a/ldap/servers/slapd/start_tls_extop.c b/ldap/servers/slapd/start_tls_extop.c
index bfa32b7..f415c41 100644
--- a/ldap/servers/slapd/start_tls_extop.c
+++ b/ldap/servers/slapd/start_tls_extop.c
@@ -188,11 +188,31 @@ start_tls(Slapi_PBlock *pb)
/* Check whether the Start TLS request can be accepted. */
if (connection_operations_pending(conn, pb_op,
1 /* check for ops where result not yet sent */)) {
- slapi_log_err(SLAPI_LOG_PLUGIN, "start_tls",
- "Other operations are still pending on the connection.\n");
- ldaprc = LDAP_OPERATIONS_ERROR;
- ldapmsg = "Other operations are still pending on the connection.";
- goto unlock_and_return;
+ for (Operation *op = conn->c_ops; op != NULL; op = op->o_next) {
+ if (op == pb_op) {
+ continue;
+ }
+ if ((op->o_msgid == -1) && (op->o_tag == LBER_DEFAULT)) {
+ /* while processing start-tls extop we also received a new incoming operation
+ * As this operation will not processed until start-tls completes.
+ * Be fair do not consider this operation as a pending one
+ */
+ slapi_log_err(SLAPI_LOG_CONNS, "start_tls",
+ "New incoming operation blocked by start-tls, Continue start-tls (conn=%"PRIu64").\n",
+ conn->c_connid);
+ continue;
+ } else {
+ /* It is problematic, this pending operation is processed and
+ * start-tls can push new network layer while the operation
+ * send result. Safest to abort start-tls
+ */
+ slapi_log_err(SLAPI_LOG_CONNS, "start_tls",
+ "Other operations are still pending on the connection.\n");
+ ldaprc = LDAP_OPERATIONS_ERROR;
+ ldapmsg = "Other operations are still pending on the connection.";
+ goto unlock_and_return;
+ }
+ }
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.3 updated: Issue 49731 - undo db_home_dir under /dev/shm/dirsrv for now
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.3
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.3 by this push:
new 8fbdf92 Issue 49731 - undo db_home_dir under /dev/shm/dirsrv for now
8fbdf92 is described below
commit 8fbdf92aca65fde081604babbaa13047c066d214
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Tue Apr 21 14:48:11 2020 -0400
Issue 49731 - undo db_home_dir under /dev/shm/dirsrv for now
Bug Description: There are several issues with using /dec/shm/disrv/
for the db home directory. Cantainers have issues,
and system reboots can cause issues too.
Fix Description: Using just /dev/shm/slapd-INST solves all the permission
issues, but that requires a new selinux label, so
for now we will just set the db home directory to the
database directory (effectively disabling the change).
relates: https://pagure.io/389-ds-base/issue/49731
Reviewed by: firstyear & tbordaz(Thanks!)
---
ldap/admin/src/defaults.inf.in | 2 +-
ldap/servers/slapd/util.c | 2 +-
rpm/389-ds-base.spec.in | 2 --
src/lib389/lib389/instance/setup.py | 4 ++--
4 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/ldap/admin/src/defaults.inf.in b/ldap/admin/src/defaults.inf.in
index 23ea09d..2f630f9 100644
--- a/ldap/admin/src/defaults.inf.in
+++ b/ldap/admin/src/defaults.inf.in
@@ -58,7 +58,7 @@ access_log = @localstatedir@/log/dirsrv/slapd-{instance_name}/access
audit_log = @localstatedir@/log/dirsrv/slapd-{instance_name}/audit
error_log = @localstatedir@/log/dirsrv/slapd-{instance_name}/errors
db_dir = @localstatedir@/lib/dirsrv/slapd-{instance_name}/db
-db_home_dir = /dev/shm/dirsrv/slapd-{instance_name}
+db_home_dir = @localstatedir@/lib/dirsrv/slapd-{instance_name}/db
backup_dir = @localstatedir@/lib/dirsrv/slapd-{instance_name}/bak
ldif_dir = @localstatedir@/lib/dirsrv/slapd-{instance_name}/ldif
diff --git a/ldap/servers/slapd/util.c b/ldap/servers/slapd/util.c
index e563528..b4f31ff 100644
--- a/ldap/servers/slapd/util.c
+++ b/ldap/servers/slapd/util.c
@@ -471,7 +471,7 @@ slapi_escape_filter_value(char *filter_str, int len)
void
replace_char(char *str, char c, char c2)
{
- for (size_t i = 0; (str != NULL) && (str[i] != NULL); i++) {
+ for (size_t i = 0; (str != NULL) && (str[i] != '\0'); i++) {
if (c == str[i]) {
str[i] = c2;
}
diff --git a/rpm/389-ds-base.spec.in b/rpm/389-ds-base.spec.in
index d633732..b9f8548 100644
--- a/rpm/389-ds-base.spec.in
+++ b/rpm/389-ds-base.spec.in
@@ -431,7 +431,6 @@ popd
mkdir -p $RPM_BUILD_ROOT/var/log/%{pkgname}
mkdir -p $RPM_BUILD_ROOT/var/lib/%{pkgname}
mkdir -p $RPM_BUILD_ROOT/var/lock/%{pkgname}
-mkdir -p $RPM_BUILD_ROOT/dev/shm/%{pkgname}
# for systemd
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/systemd/system/%{groupname}.wants
@@ -637,7 +636,6 @@ exit 0
%{_prefix}/lib/sysctl.d/*
%dir %{_localstatedir}/lib/%{pkgname}
%dir %{_localstatedir}/log/%{pkgname}
-%dir /dev/shm/%{pkgname}
%ghost %dir %{_localstatedir}/lock/%{pkgname}
%exclude %{_sbindir}/ldap-agent*
%exclude %{_mandir}/man1/ldap-agent.1.gz
diff --git a/src/lib389/lib389/instance/setup.py b/src/lib389/lib389/instance/setup.py
index bc514c7..8039922 100644
--- a/src/lib389/lib389/instance/setup.py
+++ b/src/lib389/lib389/instance/setup.py
@@ -747,7 +747,7 @@ class SetupDs(object):
# Create all the needed paths
# we should only need to make bak_dir, cert_dir, config_dir, db_dir, ldif_dir, lock_dir, log_dir, run_dir?
- for path in ('backup_dir', 'cert_dir', 'db_dir', 'db_home_dir', 'ldif_dir', 'lock_dir', 'log_dir', 'run_dir'):
+ for path in ('backup_dir', 'cert_dir', 'db_dir', 'ldif_dir', 'lock_dir', 'log_dir', 'run_dir'):
self.log.debug("ACTION: creating %s", slapd[path])
try:
os.umask(0o007) # For parent dirs that get created -> sets 770 for perms
@@ -868,7 +868,7 @@ class SetupDs(object):
# Do selinux fixups
if general['selinux']:
selinux_paths = ('backup_dir', 'cert_dir', 'config_dir', 'db_dir',
- 'db_home_dir', 'ldif_dir', 'lock_dir', 'log_dir',
+ 'ldif_dir', 'lock_dir', 'log_dir',
'run_dir', 'schema_dir', 'tmp_dir')
for path in selinux_paths:
selinux_restorecon(slapd[path])
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.1 updated: Issue 51031 UI - transition between two instances needs improvement
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.1 by this push:
new 9038be2 Issue 51031 UI - transition between two instances needs improvement
9038be2 is described below
commit 9038be2979954ada6cb4c8344c8da2a810ea3784
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Fri Apr 17 15:46:42 2020 -0400
Issue 51031 UI - transition between two instances needs improvement
Bug Description: When you switch between instances in the UI, there is
no loading page, there is a long wait before the dropdown
menu changes, and it does not refresh the page content
(it still contains the previous instance's data).
Fix Description: Set the "loading" flag and the serverId right away when
instance is changed. Then we set the tab component's
key to the server ID so the content is automatically
refreshed.
fixes: https://pagure.io/389-ds-base/issue/51031
Reviewed by: spichugi(Thanks!)
---
src/cockpit/389-console/src/ds.jsx | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/cockpit/389-console/src/ds.jsx b/src/cockpit/389-console/src/ds.jsx
index b8be78e..7ff8b03 100644
--- a/src/cockpit/389-console/src/ds.jsx
+++ b/src/cockpit/389-console/src/ds.jsx
@@ -332,6 +332,11 @@ export class DSInstance extends React.Component {
}
handleServerIdChange(e) {
+ this.setState({
+ pageLoadingState: { state: "loading", jsx: "" },
+ progressValue: 25,
+ serverId: e.target.value
+ });
this.loadInstanceList(e.target.value);
}
@@ -625,6 +630,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={2}>
@@ -632,6 +638,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={3}>
@@ -639,6 +646,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={4}>
@@ -646,6 +654,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={5}>
@@ -653,6 +662,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={6}>
@@ -660,6 +670,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
</TabContent>
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.2 updated: Issue 51031 UI - transition between two instances needs improvement
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.2
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.2 by this push:
new 3ce0896 Issue 51031 UI - transition between two instances needs improvement
3ce0896 is described below
commit 3ce08963e80bd276f693f4559ce5a03294954a72
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Fri Apr 17 15:46:42 2020 -0400
Issue 51031 UI - transition between two instances needs improvement
Bug Description: When you switch between instances in the UI, there is
no loading page, there is a long wait before the dropdown
menu changes, and it does not refresh the page content
(it still contains the previous instance's data).
Fix Description: Set the "loading" flag and the serverId right away when
instance is changed. Then we set the tab component's
key to the server ID so the content is automatically
refreshed.
fixes: https://pagure.io/389-ds-base/issue/51031
Reviewed by: spichugi(Thanks!)
---
src/cockpit/389-console/src/ds.jsx | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/cockpit/389-console/src/ds.jsx b/src/cockpit/389-console/src/ds.jsx
index b8be78e..7ff8b03 100644
--- a/src/cockpit/389-console/src/ds.jsx
+++ b/src/cockpit/389-console/src/ds.jsx
@@ -332,6 +332,11 @@ export class DSInstance extends React.Component {
}
handleServerIdChange(e) {
+ this.setState({
+ pageLoadingState: { state: "loading", jsx: "" },
+ progressValue: 25,
+ serverId: e.target.value
+ });
this.loadInstanceList(e.target.value);
}
@@ -625,6 +630,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={2}>
@@ -632,6 +638,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={3}>
@@ -639,6 +646,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={4}>
@@ -646,6 +654,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={5}>
@@ -653,6 +662,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={6}>
@@ -660,6 +670,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
</TabContent>
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.3 updated: Issue 51031 UI - transition between two instances needs improvement
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.3
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.3 by this push:
new 2ae260f Issue 51031 UI - transition between two instances needs improvement
2ae260f is described below
commit 2ae260fb50d524f3a5ad12dc55ce0d49fb72ab68
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Fri Apr 17 15:46:42 2020 -0400
Issue 51031 UI - transition between two instances needs improvement
Bug Description: When you switch between instances in the UI, there is
no loading page, there is a long wait before the dropdown
menu changes, and it does not refresh the page content
(it still contains the previous instance's data).
Fix Description: Set the "loading" flag and the serverId right away when
instance is changed. Then we set the tab component's
key to the server ID so the content is automatically
refreshed.
fixes: https://pagure.io/389-ds-base/issue/51031
Reviewed by: spichugi(Thanks!)
---
src/cockpit/389-console/src/ds.jsx | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/src/cockpit/389-console/src/ds.jsx b/src/cockpit/389-console/src/ds.jsx
index b8be78e..7ff8b03 100644
--- a/src/cockpit/389-console/src/ds.jsx
+++ b/src/cockpit/389-console/src/ds.jsx
@@ -332,6 +332,11 @@ export class DSInstance extends React.Component {
}
handleServerIdChange(e) {
+ this.setState({
+ pageLoadingState: { state: "loading", jsx: "" },
+ progressValue: 25,
+ serverId: e.target.value
+ });
this.loadInstanceList(e.target.value);
}
@@ -625,6 +630,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={2}>
@@ -632,6 +638,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={3}>
@@ -639,6 +646,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={4}>
@@ -646,6 +654,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={5}>
@@ -653,6 +662,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
<TabPane eventKey={6}>
@@ -660,6 +670,7 @@ export class DSInstance extends React.Component {
addNotification={this.addNotification}
serverId={this.state.serverId}
wasActiveList={this.state.wasActiveList}
+ key={this.state.serverId}
/>
</TabPane>
</TabContent>
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years
[389-ds-base] branch 389-ds-base-1.4.1 updated: Bump version to 1.4.1.18
by pagure＠pagure.io
This is an automated email from the git hooks/post-receive script.
mreynolds pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.
The following commit(s) were added to refs/heads/389-ds-base-1.4.1 by this push:
new 5f64d41 Bump version to 1.4.1.18
5f64d41 is described below
commit 5f64d4109f2b15272424ed82132992d9c81db421
Author: Mark Reynolds <mreynolds(a)redhat.com>
AuthorDate: Thu Apr 16 17:47:33 2020 -0400
Bump version to 1.4.1.18
---
VERSION.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/VERSION.sh b/VERSION.sh
index dfa37e2..acf81f5 100644
--- a/VERSION.sh
+++ b/VERSION.sh
@@ -10,7 +10,7 @@ vendor="389 Project"
# PACKAGE_VERSION is constructed from these
VERSION_MAJOR=1
VERSION_MINOR=4
-VERSION_MAINT=1.17
+VERSION_MAINT=1.18
# NOTE: VERSION_PREREL is automatically set for builds made out of a git tree
VERSION_PREREL=
VERSION_DATE=$(date -u +%Y%m%d)
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
4 years