[389-commits] [389-ds-base] branch 389-ds-base-1.4.0 updated: Ticket 50340 - structs for diabled plugins will not be freed

This is an automated email from the git hooks/post-receive script. lkrispen pushed a commit to branch 389-ds-base-1.4.0 in repository 389-ds-base. The following commit(s) were added to refs/heads/389-ds-base-1.4.0 by this push: new dd14c53 Ticket 50340 - structs for diabled plugins will not be freed dd14c53 is described below commit dd14c53cc12a4347cfb765a30854decae8f38499 Author: Ludwig Krispenz <lkrispen(a)redhat.com&gt; AuthorDate: Thu Apr 25 10:39:17 2019 +0200 Ticket 50340 - structs for diabled plugins will not be freed Bug: when plugins are loaded from dse.ldif enabled plugins will be added to the list of the plugin type and freed when plugins are stopped. But the memory allocated for disabled plugins will remain allocated and and be reported. Fix: free plugin if not enabled after loading This will alos let the many leaks reported for "GrowStuff" disappear. The fix also contains one missing free for slapi_ch_smprintf allocated memory Reviewed by: Mark, thanks --- ldap/servers/slapd/ldaputil.c | 1 + ldap/servers/slapd/plugin.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/ldap/servers/slapd/ldaputil.c b/ldap/servers/slapd/ldaputil.c index a215e90..082250d 100644 --- a/ldap/servers/slapd/ldaputil.c +++ b/ldap/servers/slapd/ldaputil.c @@ -779,6 +779,7 @@ slapi_ldap_init_ext( if (PR_SUCCESS != PR_CallOnce(&ol_init_callOnce, internal_ol_init_init)) { slapi_log_err(SLAPI_LOG_ERR, "slapi_ldap_init_ext", "Could not perform internal ol_init init\n"); + slapi_ch_free_string(&makeurl); rc = -1; goto done; } diff --git a/ldap/servers/slapd/plugin.c b/ldap/servers/slapd/plugin.c index 9e1c1b4..601a012 100644 --- a/ldap/servers/slapd/plugin.c +++ b/ldap/servers/slapd/plugin.c @@ -3040,7 +3040,7 @@ plugin_setup(Slapi_Entry *plugin_entry, struct slapi_componentid *group, slapi_p } PLUGIN_CLEANUP: - if (status) { + if (status || !enabled) { plugin_free(plugin); } slapi_ch_free((void **)&configdir); -- To stop receiving notification emails like this one, please contact the administrator of this repository.