ldap/servers/slapd/back-ldbm/ldbm_config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 989a30bb2d63ee6b9157a9eb6a3d2ff6828abc60
Author: Rich Megginson <rmeggins(a)redhat.com>
Date: Tue Jul 2 14:40:00 2013 -0600
Ticket #47409 - allow setting db deadlock rejection policy
https://fedorahosted.org/389/ticket/47409
Reviewed by: nhosoi (Thanks!)
Branch: master
Fix Description: Fix coverity CID 11893 (#1 of 1): Unsigned compared against 0
(NO_EFFECT)
val is u_int32_t which is never less than 0
Platforms tested: RHEL6 x86_64
Flag Day: no
Doc impact: yes - document new config parameter
diff --git a/ldap/servers/slapd/back-ldbm/ldbm_config.c
b/ldap/servers/slapd/back-ldbm/ldbm_config.c
index c39e69b..db8928e 100644
--- a/ldap/servers/slapd/back-ldbm/ldbm_config.c
+++ b/ldap/servers/slapd/back-ldbm/ldbm_config.c
@@ -1407,7 +1407,7 @@ static int ldbm_config_db_deadlock_policy_set(void *arg, void
*value, char *erro
int retval = LDAP_SUCCESS;
u_int32_t val = (u_int32_t) ((uintptr_t)value);
- if ((val < DB_LOCK_NORUN) || (val > DB_LOCK_YOUNGEST)) {
+ if (val > DB_LOCK_YOUNGEST) {
PR_snprintf(errorbuf, SLAPI_DSE_RETURNTEXT_SIZE,
"Error: Invalid value for %s (%d). Must be between %d and %d
inclusive",
CONFIG_DB_DEADLOCK_POLICY, val, DB_LOCK_DEFAULT, DB_LOCK_YOUNGEST);