Please review: [Bug 563365] Error handling problems in the backend functions
by Noriko Hosoi
Summary: Error handling problems in the backend functions
https://bugzilla.redhat.com/show_bug.cgi?id=563365
[Description of problem]
1) Error handling in ldbm_back_{add,delete,modify,modrdn} functions was
incomplete. When any error occurs after the transaction begins, the changes
made after that should be aborted. There were some cases the abort was not
called.
2) If modrdn failed in ldbm_bacK_modrdn, new DN in the DN cache was not
removed.
[Proposed fix]
--> (https://bugzilla.redhat.com/attachment.cgi?id=389871)
git patch file
[Files]
ldap/servers/slapd/back-ldbm/id2entry.c
ldap/servers/slapd/back-ldbm/ldbm_add.c
ldap/servers/slapd/back-ldbm/ldbm_delete.c
ldap/servers/slapd/back-ldbm/ldbm_modify.c
ldap/servers/slapd/back-ldbm/ldbm_modrdn.c
ldap/servers/slapd/libglobs.c
[Fix Description]
1) Error handling in ldbm_back_{add,delete,modify,modrdn} functions was
incomplete. When any error occurs after the transaction begins, the
changes made after that should be aborted. There were some cases the
abort was not called.
2) If modrdn failed in ldbm_back_modrdn, new DN in the DN cache was not
removed.
3) config_set_instancedir in libglobs.c was missing the function type.
14 years, 2 months
minimal requirements to compile mozilla ldapsearch on ubuntu
by Angel Bosch Mora
hi,
i want to compile moztools on ubuntu.
i just need ldapsearch. this file is located at /usr/lib/mozldap/ldapsearch and is from rpm mozldap-tools
what source code and requirements do i need to compile it on ubuntu/debian?
regards,
abosch
ps: im not on devel list, please cc me
14 years, 2 months
Please review: [Bug 548535] memory leak in attrcrypt
by Noriko Hosoi
https://bugzilla.redhat.com/show_bug.cgi?id=548535
Files:
ldap/servers/slapd/back-ldbm/dblayer.c
ldap/servers/slapd/back-ldbm/ldbm_attrcrypt.c
ldap/servers/slapd/back-ldbm/proto-back-ldbm.h
Description:
The attrcrypt module maintains the inst_attrcrypt_state_private
field in the instance structure (ldbm_instance) to store the private
keys. The area and the space for the private keys are allocated in
attrcrypt_init which is called from dblayer_instance_start.
A backend instance could be closed and restarted multiple times
(for instance, in the bulk_import, which is used by the replica
initialization), but the area had no chance to be freed.
This patch is adding the clean-up code.
[Proposed patch]
--> (https://bugzilla.redhat.com/attachment.cgi?id=389229)
git patch file
14 years, 2 months
Please review (revised): [Bug 560827] Admin Server templates: DistinguishName validation fails
by Noriko Hosoi
Thanks to Rich and Nathan for their comments and even debugging my code
:). I revised the proposal based upon their suggestions.
Summary: Admin Server templates: DistinguishName validation fails
https://bugzilla.redhat.com/show_bug.cgi?id=560827
Description of problem:
Some template file contains double quotes in the DN string, which
are not escaped.
Sample broken entry in 01nsroot.ldif.tmpl
dn: ou="uid=%as_uid%, ou=Administrators, ou=TopologyManagement,
o=NetscapeRoot",ou=UserPreferences, ou=%domain%, o=NetscapeRoot
objectClass: top
objectClass: organizationalUnit
aci: (targetattr=*)(version 3.0; acl "UserDNControl"; allow (all)
userdnattr="creatorsname";)
ou: uid=%as_uid%, ou=Administrators, ou=TopologyManagement, o=NetscapeRoot
Related bug:
https://bugzilla.redhat.com/show_bug.cgi?id=555577
555577 - Syntax validation fails for "ou=NetscapeRoot" tree
[Proposed fix (ldapserver)]
--> (https://bugzilla.redhat.com/attachment.cgi?id=388648)
git patch file (ldapserver)
Description: adding a perl subroutine dnEscape to escape special
characters and eliminate spaces around ',', which is to make
the given dn compliant with RFC4514.
[Proposed fix (adminserver)]
--> (https://bugzilla.redhat.com/attachment.cgi?id=388650)
git patch file (adminserver)
Description:
admserv/newinst/src/dirserver.map.in
/register_param.map.in
--- added escapedrootdn key, which is an escaped rootdn compliant
with RFC4514
admserv/schema/ldif/*.tmpl
--- removed unescaped '"' from dn strings, which violates RFC4514.
escaped special characters ('=' and ',') which used to be a
value surrounded in the double quotes '"'.
removed spaces around ','
14 years, 2 months
Pleaes review: [Bug 560827] Admin Server templates: DistinguishName validation fails
by Noriko Hosoi
Summary: Admin Server templates: DistinguishName validation fails
https://bugzilla.redhat.com/show_bug.cgi?id=560827
Description of problem:
Some template file contains double quotes in the DN string, which
are not escaped.
Sample broken entry in 01nsroot.ldif.tmpl
dn: ou="uid=%as_uid%, ou=Administrators, ou=TopologyManagement,
o=NetscapeRoot",ou=UserPreferences, ou=%domain%, o=NetscapeRoot
objectClass: top
objectClass: organizationalUnit
aci: (targetattr=*)(version 3.0; acl "UserDNControl"; allow (all)
userdnattr="creatorsname";)
ou: uid=%as_uid%, ou=Administrators, ou=TopologyManagement, o=NetscapeRoot
Related bug:
https://bugzilla.redhat.com/show_bug.cgi?id=555577
555577 - Syntax validation fails for "ou=NetscapeRoot" tree
Files:
admserv/schema/ldif/00nsroot_backend.ldif.tmpl
admserv/schema/ldif/01nsroot.ldif.tmpl
admserv/schema/ldif/10dsdata.ldif.tmpl
admserv/schema/ldif/10rm_dsdata.ldif.tmpl
admserv/schema/ldif/20asdata.ldif.tmpl
Fix Description: Escaping double quotes '"' appeared in the DN string.
Tests: setup-ds-admin.pl successfully installs the Configuration Directory
Server. "o=netscaperoot" and its subtree is able to expand in the Console.
[Proposed Patch]
--> (https://bugzilla.redhat.com/attachment.cgi?id=388163)
git patch file
14 years, 2 months