February 2011 - 389-devel - Fedora Mailing-Lists

Please review: [Bug 676053] export task followed by import task causes cache assertion

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=676053 https://bugzilla.redhat.com/attachment.cgi?id=479245&action=diff https://bugzilla.redhat.com/attachment.cgi?id=479245&action=edit Thanks to Rich for his comments. I've updated ldbm_back_search_cleanup following his suggestions. And thanks to Reinhard for his testing and reports. I've found 2 more places entries are not released. Description: There were 3 places where an entry was not released by CACHE_RETURN (not decrimenting refcnt). If an entry has positive refcnt in the entry cache, it won't be released even if the entry never be accessed. 1. When a search request with VLV and/or SORT control fails. 2. When comparing entries in compare_entries_sv, and the second entry is not found, the first entry is not released. 3. vlv_trim_candidates_byvalue retrieves entries for performing binary search over the candidate list and put them into the cache. They are not released. This patch adds CACHE_RETURN call for the above cases.

13 years, 2 months

1
0
0 / 0

Please review: [Bug 676053] export task followed by import task causes cache assertion

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=676053 https://bugzilla.redhat.com/attachment.cgi?id=479007&action=diff https://bugzilla.redhat.com/attachment.cgi?id=479007&action=edit Description: When a search request with VLV and/or SORT control fails, it did not returning an entry to the entry cache. The entry has positive refcnt and won't be cleared even by cache_clear. This patch adds CACHE_RETURN call for the error cases.

13 years, 2 months

1
0
0 / 0

Please review: [Bug 676053] export task followed by import task causes cache assertion

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=676053 https://bugzilla.redhat.com/attachment.cgi?id=478729&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478729&action=edit Description: When Simple Paged Results is requested and a page is returned, one entry is read ahead to check whether more entries exist or not. The read-ahead retrieves an entry (if any) and adds it into the entry cache. Simple Paged Results code puts the read- ahead entry back, but there was missing to call cache_return for the entry (that decrementing refcnt). If ldif2db.pl is called with the cache state, it finds out the entry which is still referred. This patch calls cache_return when the Simple Paged Results puts the read-ahead entry back. Plus, adding a debug function dump_hash.

13 years, 2 months

1
0
0 / 0

Please review: Bug 677440 - clean up compiler warnings in 389-ds-base 1.2.8

by Rich Megginson

https://bugzilla.redhat.com/show_bug.cgi?id=677440 https://bugzilla.redhat.com/attachment.cgi?id=478698&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478698&action=edit

13 years, 2 months

1
0
0 / 0

Please review (take 2) Admin Server: [Bug 245278] Changing to a password with a single quote does not work

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=245278 https://bugzilla.redhat.com/attachment.cgi?id=478329&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478329&action=edit Thanks to Rich for his comments. I cancelled the 389-admin-console patch. Description: When the Admin User password is changed on the Admin Console, the console escapes the password then sends it to the Admin Server. This patch adds the apache API ap_unescape_url to mod_admserv to unescape the password before handling it.

13 years, 2 months

1
1
0 / 0

Please review: [Bug 245278] Changing to a password with a single quote does not work

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=245278 https://bugzilla.redhat.com/attachment.cgi?id=478306&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478306&action=edit Description: The save method in CGIAccessSetup "encodes" the admin password with URLByteEncoder.encodeUTF8, which escapes a string in the HTML safe manner. It should not be done for the password. Also, replacing a deprecated method getText with getPassword in AccessConfigPanel.

13 years, 2 months

1
0
0 / 0

Please review: [Bug 676053] export task followed by import task causes cache assertion

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=676053 https://bugzilla.redhat.com/attachment.cgi?id=478160&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478160&action=edit Description: Task version of export had a bug in handling the busy instance error case. When returning due to the busy error, the function ldbm_back_ldbm2ldif reset the busy bit set by other threads. This patch checks the special return value set in the busy error case and resets the busy bit only when it is set by the function. Also, this patch fixes a bug in dse_add which replaces an adding entry with its copy in pblock and the original entry is consumed. But the caller frees the original entry. Applying this patch, instead of consuming the original entry, its copy is consumed and the original adding entry stays in the pblock.

13 years, 2 months

1
0
0 / 0

Please review: Bug 676689 - crash while adding a new user to be synced to windows

by Rich Megginson

https://bugzilla.redhat.com/show_bug.cgi?id=676689 https://bugzilla.redhat.com/attachment.cgi?id=478135&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478135&action=edit

13 years, 2 months

1
0
0 / 0

Please review: [Bug 604881] admin server log files have incorrect permissions/ownerships

by Noriko Hosoi

https://bugzilla.redhat.com/show_bug.cgi?id=604881 https://bugzilla.redhat.com/attachment.cgi?id=478131&action=diff https://bugzilla.redhat.com/attachment.cgi?id=478131&action=edit Description: Log files first generated by the Admin Server/Apache has the owner (root, root), but the log files created later via Console/CGI are owned by the Admin User/Group (e.g., nobody, nobody). To make them consistent, this patch modifies the install script to call chown to change the owner to the original log files.

13 years, 2 months

1
0
0 / 0

Please Review: (675853) dirsrv crash segfault in need_new_pw()

by Nathan Kinder

https://bugzilla.redhat.com/show_bug.cgi?id=675853 https://bugzilla.redhat.com/attachment.cgi?id=477699&action=edit

13 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel February 2011