389-devel July 2012

389-devel@lists.fedoraproject.org

8 participants
14 discussions

Start a nNew thread

Please review: Ticket #405 - referint modrdn not working if case is different

by Rich Megginson

https://fedorahosted.org/389/ticket/405 https://fedorahosted.org/389/attachment/ticket/405/0001-Ticket-405-referi...

11 years, 9 months

1
0
0 / 0

Please review (take 3): [389 Project] #402: unhashed#user#password in entry extension

by Noriko Hosoi

Thanks to Nathan for his reviews and suggestions. I fixed the previous proposal following his advice. https://fedorahosted.org/389/ticket/402 https://fedorahosted.org/389/attachment/ticket/402/0001-Trac-Ticket-402-n... (This patch includes including autogen'ed files.) Thanks, --noriko 389 Project wrote: > Replying to [comment:5 nkinder]: > > There appears to have been a problem merging your changes in > ldap/servers/slapd/ldaputil.c with the patch for ticket #399. Your patch > reverts the fix made to always get the bind result, which will cause a > regression. > > Sorry, I don't know why the file was reverted. I recreated the patch > which has no change on ldaputil.c. > > > It looks odd that the slapi_entry_apply_mod_extension() and > entry_apply_mod_wsi() functions expect SLAPI_PW_* specific extensions > since these are generic functions. Is this a safe assumption? > > Yes, you are right! I replaced SLAPI_PW_SET_ADD with SLAPI_EXT_SET_ADD > and SLAPI_PW_SET_REPLACE with SLAPI_EXT_SET_REPLACE. > > > If pw_entry_constructor() fails to allocate a lock, should we just > return NULL without allocating and returning pw_extp? The slapi_rwlock_*() > functions called by the extension get/set functions do check if the lock > is NULL before attempting to use them, but this will behave with no > protection from the lock. > > A good point. Thanks for pointing it out. I've modified constructor to > return NULL when slapi_new_rwlock fails. If it happens, "struct > slapi_pw_entry_ext" won't be allocated. And the following unhashed > password set/get fails with ""pw_entry_extension is not set". > > > Does pw_copy_entry_ext() need to use the rwlock from the source and > destination extensions? > > Another good point! I added to call slapi_rwlock_wrlock to protect > valuearray_add_valuearray. >

11 years, 9 months

1
0
0 / 0

please review ticket 328 - make sure all internal search filters are properly escaped

by Mark Reynolds

https://fedorahosted.org/389/ticket/328 https://fedorahosted.org/389/attachment/ticket/328/0001-Ticket-328-make-s... Thanks, Mark -- Mark Reynolds Senior Software Engineer Red Hat, Inc mreynolds(a)redhat.com

11 years, 9 months

1
2
0 / 0

Help with trac #89

by Jonathan "Duke" Leto

Howdy, I am currently digging into Trac #89: https://fedorahosted.org/389/ticket/89 Would it be possible for anybody to add a few comments to the ticket with some helpful hints about where in the codebase I should be looking to fix that issue? Also, if somebody could describe exactly what the *correct* behavior should be, that would help me in resolving that ticket. Thanks! Duke -- Jonathan "Duke" Leto <jonathan(a)leto.net> Leto Labs LLC http://labs.leto.net 209.691.DUKE http://dukeleto.pl

11 years, 9 months

3
2
0 / 0

← Newer
1
2
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-devel July 2012