From: Martyn Taylor&lt;mtaylor(a)redhat.com&gt; --- examples/tdl.rng | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/examples/tdl.rng b/examples/tdl.rng index e302a3a..b7eae58 100644 --- a/examples/tdl.rng +++ b/examples/tdl.rng @@ -79,11 +79,9 @@ <ref name='iso'/> </choice> </element> -<optional> -<element name='rootpw'> -<text/> -</element> -</optional> +<element name='rootpw'> +<text/> +</element> <optional> <element name='key'> <text/>

To answer your q, there is no need now for any validation to take place in the CLI. It was originally there because we had no support in conductor. If you are referring to our decision last sprint to keep it in; the reason was that we had a BZ blocker on the release that required us to make some changes to the tdl. I made the call not to make significant changes to the CLI mainly due to the time constraints and for consistency with other errors in CLI + there was the possibility of us adding new bugs so close to release date. I'm pretty sure that Maros created a RM task last sprint for the removal of the validation altogether from the CLI. If you need to get this, please let us know and we can try n squeeze it in next sprint. I will be on PTO next week so I will miss next sprints planning session, Maros can you liase with Jan and get this in next sprint if he needs it.

Cheers Martyn

On 06/01/2012 09:06 AM, Jan Provaznik wrote: > On 05/23/2012 08:14 PM, mtaylor(a)redhat.com wrote: >> From: Martyn Taylor&lt;mtaylor(a)redhat.com&gt; >> >> --- >> examples/tdl.rng | 8 +++----- >> 1 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/examples/tdl.rng b/examples/tdl.rng >> index e302a3a..b7eae58 100644 >> --- a/examples/tdl.rng >> +++ b/examples/tdl.rng >> @@ -79,11 +79,9 @@ >> <ref name='iso'/> >> </choice> >> </element> >> -<optional> >> -<element name='rootpw'> >> -<text/> >> -</element> >> -</optional> >> +<element name='rootpw'> >> +<text/> >> +</element> >> <optional> >> <element name='key'> >> <text/> > > Hi Martyn, > what is the reason to have the XML schema validation in aeolus-cli. > Aeolus-cli is just very thin layer which gets params from a user and > sends them to Conductor. > I think that the XML validation should be done only by Imagefactory > since it's only component which processes the template. True is that > this validation is now done also on Conductor side but only reason for > this is that Imagefactory doesn't have API call for template validation. > > I see that in app/controllers/api/images_controller.rb is some logic > which returns validation errors if the template is invalid so I would > say that the validation on aeolus-cli side can be removed. > > Jan