7 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=863465
---
src/app/models/user.rb | 1 +
src/config/locales/en.yml | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/app/models/user.rb b/src/app/models/user.rb
index 5db8e95..e4b7854 100644
--- a/src/app/models/user.rb
+++ b/src/app/models/user.rb
@@ -84,6 +84,7 @@ class User < ActiveRecord::Base
validates_length_of :last_name, :maximum => 255, :allow_blank => true
validates_uniqueness_of :username
validates_length_of :username, :within => 1..100, :allow_blank => false
+ validates_format_of :username, :with => /[a-z0-9A-Z]/, :message =>
I18n.t("users.flash.warning.invalid_username")
validates_format_of :email, :with => /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i,
:unless => Proc.new {|u| u.email.nil?}
validates_confirmation_of :password, :if => Proc.new {|u| u.check_password?}
validates_length_of :password, :within => 4..255, :if => Proc.new {|u|
u.check_password?}
diff --git a/src/config/locales/en.yml b/src/config/locales/en.yml
index e052f91..6b03cf5 100644
--- a/src/config/locales/en.yml
+++ b/src/config/locales/en.yml
@@ -100,6 +100,7 @@ en:
warning:
not_delete: 'Cannot delete: %{reason}'
not_delete_same_user: "Cannot delete %{username} : You are logged in as this
user"
+ invalid_username: 'should use only letters and numbers.'
preset_filters:
all_users: "All Users"
name_starts_with_A: "Name starts with A"
--
1.7.11.4
10:16 a.m.
On Mon, Oct 08, 2012 at 02:00:14PM +0200, Tomáš Hrčka wrote:
+ validates_format_of :username, :with => /[a-z0-9A-Z]/, :message
=> I18n.t("users.flash.warning.invalid_username")
I'm going to comment on the bug itself and question whether it's even a
valid bug, but I'm not a fan of this particular implementation.
This would keep you from being thrčka ('č' is not "valid"), me from
being
'matt.wagner' (it uses a verboten '.'), or someone who speaks Chinese or
Russian or any other language with a non-Latin alphabet from even being
able to use their name in their username. To me, that is far worse than
being able to create a username named '.'.
Note that this isn't a review of your patch -- just me disagreeing with
the whole bug/fix. If people disagree with me, this is not a NACK.
-- Matt
10:33 a.m.
On Mon, 2012-10-08 at 11:16 -0400, Matt Wagner wrote:
On Mon, Oct 08, 2012 at 02:00:14PM +0200, Tomáš Hrčka wrote:
> + validates_format_of :username, :with => /[a-z0-9A-Z]/, :message =>
I18n.t("users.flash.warning.invalid_username")
I'm going to comment on the bug itself and question whether it's even a
valid bug, but I'm not a fan of this particular implementation.
This would keep you from being thrčka ('č' is not "valid"), me from
being
'matt.wagner' (it uses a verboten '.'), or someone who speaks Chinese or
Russian or any other language with a non-Latin alphabet from even being
able to use their name in their username. To me, that is far worse than
being able to create a username named '.'.
You are right, now when I think about it it's all wrong. What about
validation at least first char is not in .~!@#$%^&*()
Note that this isn't a review of your patch -- just me disagreeing with
the whole bug/fix. If people disagree with me, this is not a NACK.
-- Matt
== Tomas
10:59 a.m.
On Mon, Oct 08, 2012 at 05:33:11PM +0200, Tomas Hrcka wrote:
On Mon, 2012-10-08 at 11:16 -0400, Matt Wagner wrote:
> On Mon, Oct 08, 2012 at 02:00:14PM +0200, Tomáš Hrčka wrote:
> > + validates_format_of :username, :with => /[a-z0-9A-Z]/, :message =>
I18n.t("users.flash.warning.invalid_username")
>
> I'm going to comment on the bug itself and question whether it's even a
> valid bug, but I'm not a fan of this particular implementation.
>
> This would keep you from being thrčka ('č' is not "valid"), me
from being
> 'matt.wagner' (it uses a verboten '.'), or someone who speaks
Chinese or
> Russian or any other language with a non-Latin alphabet from even being
> able to use their name in their username. To me, that is far worse than
> being able to create a username named '.'.
You are right, now when I think about it it's all wrong. What about
validation at least first char is not in .~!@#$%^&*()
What irks me about this "bug" is that there's no clear solution, at
least not that I can see. I think it's really an RFE, but it's an RFE
that's too vague for us to be able to implement. Personally I would vote
that we just close this thing, but that's not my call.
I can't think of a case where '#' or '&' would ever be a
reasonable
character in a username. But if some weird customer decides to that they
want to conserve user accounts, there's no reason that 'Tomas & Matt'
can't be a valid username, except that we think it's strange.
I think a '.' or '_' is fine in the middle of a username, but not at
either end. 'matt.wagner' is a normal username, but '.matt.' would be
really weird.
But at the end of the day, I don't know that it's our place to make up
arbitrary username rules. If someone wants to create a user named
'.~!@#$%^&*()' or '☃☃⚔ Fluffy Bunnies ♿♚♚' there is no technical
reason
to prevent it.
-- Matt '☃☃⚔ Fluffy Bunnies ♿♚♚' Wagner
1:57 p.m.
On 10/08/2012 11:59 AM, Matt Wagner wrote:
On Mon, Oct 08, 2012 at 05:33:11PM +0200, Tomas Hrcka wrote:
> On Mon, 2012-10-08 at 11:16 -0400, Matt Wagner wrote:
>> On Mon, Oct 08, 2012 at 02:00:14PM +0200, Tomáš Hrčka wrote:
>>> + validates_format_of :username, :with => /[a-z0-9A-Z]/, :message =>
I18n.t("users.flash.warning.invalid_username")
>> I'm going to comment on the bug itself and question whether it's even a
>> valid bug, but I'm not a fan of this particular implementation.
>>
>> This would keep you from being thrčka ('č' is not "valid"), me
from being
>> 'matt.wagner' (it uses a verboten '.'), or someone who speaks
Chinese or
>> Russian or any other language with a non-Latin alphabet from even being
>> able to use their name in their username. To me, that is far worse than
>> being able to create a username named '.'.
> You are right, now when I think about it it's all wrong. What about
> validation at least first char is not in .~!@#$%^&*()
What irks me about this "bug" is that there's no clear solution, at
least not that I can see. I think it's really an RFE, but it's an RFE
that's too vague for us to be able to implement. Personally I would vote
that we just close this thing, but that's not my call.
I can't think of a case where '#' or '&' would ever be a
reasonable
character in a username. But if some weird customer decides to that they
want to conserve user accounts, there's no reason that 'Tomas & Matt'
can't be a valid username, except that we think it's strange.
I think a '.' or '_' is fine in the middle of a username, but not at
either end. 'matt.wagner' is a normal username, but '.matt.' would be
really weird.
But at the end of the day, I don't know that it's our place to make up
arbitrary username rules. If someone wants to create a user named
'.~!@#$%^&*()' or '☃☃⚔ Fluffy Bunnies ♿♚♚' there is no technical
reason
to prevent it.
-- Matt '☃☃⚔ Fluffy Bunnies ♿♚♚' Wagner
The other issue is when we're
using LDAP, we've got to accept whatever
the ldap server includes in the username. Also, I believe katello just
made a change (or is about to) that explicitly allows '@' and '.' in
username (to allow the user to use email address as username)
Scott
4228
days inactive
4228
days old
aeolus-devel@lists.fedorahosted.org
4 comments
3 participants
participants (3)
-
Matt Wagner -
Scott Seago -
Tomas Hrcka