Anaconda-devel January 2011

anaconda-devel@lists.fedoraproject.org

24 participants
83 discussions

[rhel6-branch] VNC does not support runtime SecurityTypes changes (#670832)
by Martin Gracik 25 Jan '11

25 Jan '11

New XVNC does not support changing of SecurityTypes when it is already running with vncconfig. So we have to solve all the password stuff first, and then run the XVNC with either None or VncAuth. --- vnc.py | 62 +++++++++++++++++++++++++------------------------------------- 1 files changed, 25 insertions(+), 37 deletions(-) diff --git a/vnc.py b/vnc.py index 6f9f4d3..5d0c209 100644 --- a/vnc.py +++ b/vnc.py @@ -76,23 +76,18 @@ class VncServer: self.password="" def setVNCPassword(self): - """Change the vnc server password. Output to file. """ - - if len(self.password) == 0: - self.setVNCParam("SecurityTypes", "None") - self.setVNCParam("rfbauth","0") - return - - # If there is a password the SecurityTypes = VncAuth for all connections. - self.setVNCParam("SecurityTypes", "VncAuth") - self.setVNCParam("rfbauth",self.pw_file) + """Set the vnc server password. Output to file. """ # password input combination. - pwinput = "%s\n%s\n" % (self.password, self.password) - vnccommand = [self.root+"/usr/bin/vncpasswd", self.pw_file] - vncpswdo = subprocess.Popen(vnccommand, stdin=subprocess.PIPE, stdout=subprocess.PIPE)# We pipe the output - # so the user does not see it. + pwinput = "%s\n" % self.password + pwoutput = open(self.pw_file, "w") + + # the -f option makes sure vncpasswd does not ask for the password again + vnccommand = ["vncpasswd", "-f"] + vncpswdo = subprocess.Popen(vnccommand, stdin=subprocess.PIPE, stdout=pwoutput) (out, err) = vncpswdo.communicate(input=pwinput) + pwoutput.close() + return vncpswdo.returncode def initialize(self): @@ -147,16 +142,6 @@ class VncServer: % {'productName': product.productName, 'productVersion': product.productVersion} - def setVNCParam(self, param, value): - """Set a parameter in the Xvnc server. - - Possible values for param and value. param=(values) - SecurityTypes=(VncAuth,None) - """ - vncconfigcommand = [self.root+"/usr/bin/vncconfig", "-display", ":%s"%self.display , "-set" , "%s=%s" %(param, value)] - vncconfo = subprocess.Popen(vncconfigcommand)# we dont want output - return vncconfo.returncode - def openlogfile(self): try: err = os.open(self.log_file, os.O_RDWR | os.O_CREAT) @@ -216,13 +201,25 @@ class VncServer: # Lets call it from here for now. self.initialize() - # Lets start the xvnc regardless of vncconnecthost and password. - # We can change the configuration on the fly later. - xvnccommand = [ self.root + "/usr/bin/Xvnc", ":%s" % self.display, "-nevershared", + if self.password and len(self.password) < 6: + self.changeVNCPasswdWindow() + + if not self.password: + SecurityTypes = "None" + rfbauth = "0" + else: + SecurityTypes = "VncAuth" + rfbauth = self.pw_file + # Create the password file. + rc = self.setVNCPassword() + + # Lets start the xvnc. + xvnccommand = [ "Xvnc", ":%s" % self.display, "-nevershared", "-depth", "16", "-geometry", "800x600", "-br", "IdleTimeout=0", "-auth", "/dev/null", "-once", "DisconnectClients=false", "desktop=%s" % (self.desktop,), - "SecurityTypes=None"] + "SecurityTypes=%s" % SecurityTypes, "rfbauth=%s" % rfbauth ] + try: xvncp = subprocess.Popen(xvnccommand, stdout=self.openlogfile(), stderr=subprocess.STDOUT) except: @@ -238,15 +235,6 @@ class VncServer: else: self.log.info(_("The VNC server is now running.")) - # Lets look at the password stuff - if self.password == "": - pass - elif len(self.password) < 6: - self.changeVNCPasswdWindow() - - # Create the password file. - self.setVNCPassword() - # Lets tell the user what we are going to do. if self.vncconnecthost != "": self.log.warning(_("\n\nYou chose to connect to a listening vncviewer. \n" -- 1.7.3.2

1 0

The threaded GUI
by Ales Kozumplik 25 Jan '11

25 Jan '11

Hi, I finished the initial research last week and made two changes to indicate how I think this should be done. For comfortable viewing I pushed my branch to github: https://github.com/akozumpl/anaconda/tree/multi My thoughts about the issue and some rationale here: https://github.com/akozumpl/anaconda/wiki/Multiple-Threads Let me know what you think. I hope we can have a discussion about this at FUDcon. Ales

1 0

Missing ISO 9660 Image
by Vijay N. Majagaonkar 23 Jan '11

23 Jan '11

Hi All, I am stuck with ISO missing error, I have customized ISO out of centos tree ISO get install with DVD (Burn on DVD and install from ROM) But i wanted to install from USB stick, It runs all pre-script installation and stuck in mounting ISO from usb stick then it throw the "Missing ISO 9660 image" and exit the installation, I started debugging the code and came to the point where it failed, Following is the code point where it fail to mount the ISO. anaconda/hardware.py [mountMedia] def mountMedia(self, cdNum): if self.mediaIsMounted: raise SystemError, "trying to mount already-mounted iso image!" self.mountDirectory() retry = True while retry: try: isoImage = self.isoDir + '/' + self.path + '/' + self.discImages[cdNum] isys.makeDevInode("loop3", "/tmp/loop3") isys.losetup("/tmp/loop3", isoImage, readOnly = 1) isys.mount("loop3", self.tree, fstype = 'iso9660', readOnly = 1); self.mediaIsMounted = cdNum retry = False except: ans = self.messageWindow( _("Missing ISO 9660 Image"), _("The installer has tried to mount " "image #%s, but cannot find it on " "the hard drive.\n\n" "Please copy this image to the " "drive and click Retry. Click Reboot " " to abort the installation.") % (cdNum,), type="custom", custom_icon="warning", custom_buttons=[_("_Reboot"), _("Re_try")]) if ans == 0: sys.exit(0) elif ans == 1: self.discImages = findIsoImages(self.isoPath, self.messageWindow) [/mountMedia] I started debugging installer and i found that iso file exist under "/tmp/isodir/images/centos.iso" Filesystem for USB stick is FAT32 Partition type: W95 FAT32 Can some please help me to understand this code, in the above function " isys.mount("loop3", self.tree, fstype = 'iso9660', readOnly = 1);" Why we are passing "self.tree" what is value of self.tree ? self.discImages = findIsoImages(self.isoPath, self.messageWindow), In this function it try to mount ISO from usb stick and path will be something like this "path = sdb1:vfat/images" Is this correct path to look at ? "sdb1:vfat/images" Thanks for the help V!jay

1 0

[PATCH] YumBackend doesn't inherit from YumBase. AnacondaYum does. (#671577)
by David Lehman 21 Jan '11

21 Jan '11

--- pyanaconda/yuminstall.py | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyanaconda/yuminstall.py b/pyanaconda/yuminstall.py index 2870b28..fa3ba72 100644 --- a/pyanaconda/yuminstall.py +++ b/pyanaconda/yuminstall.py @@ -1936,8 +1936,8 @@ reposdir=/etc/anaconda.repos.d,/tmp/updates/anaconda.repos.d,/tmp/product/anacon return def postAction(self, anaconda): - self.close() - self.closeRpmDB() + self.ayum.close() + self.ayum.closeRpmDB() iutil.resetRpmDb(anaconda.rootPath) class DownloadHeaderProgress: -- 1.7.2.3

2 1

[PATCH] After copying live rootfs to root device, grow it to fill the device.
by David Lehman 21 Jan '11

21 Jan '11

This fixes a bug introduced by commit bd1123738d8a6ea671f472c663ed8e1c882f93a7. I was under the mistaken impression that resize2fs -p would minimize the target filesystem, based on the fact that -P prints the minimum fs size. As a result, I wrote the new resize code to minimize the new rootfs, which makes no sense. --- pyanaconda/livecd.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pyanaconda/livecd.py b/pyanaconda/livecd.py index 2c7c862..2ecd844 100644 --- a/pyanaconda/livecd.py +++ b/pyanaconda/livecd.py @@ -193,7 +193,7 @@ class LiveCDCopyBackend(backend.AnacondaBackend): # resize rootfs first, since it is 100% full due to genMinInstDelta rootDevice = anaconda.storage.rootDevice rootDevice.setup() - rootDevice.format.targetSize = rootDevice.format.minSize + rootDevice.format.targetSize = rootDevice.size rootDevice.format.doResize(intf=anaconda.intf) # ensure we have a random UUID on the rootfs -- 1.7.2.3

2 1

[rhel6-branch] Make the advanced storage dialogs stay in the foreground.
by Ales Kozumplik 21 Jan '11

21 Jan '11

Resolves: #671107 --- iw/advanced_storage.py | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/iw/advanced_storage.py b/iw/advanced_storage.py index 434786b..391a6f0 100644 --- a/iw/advanced_storage.py +++ b/iw/advanced_storage.py @@ -359,6 +359,9 @@ def addFcoeDrive(anaconda): sg.add_widget(dxml.get_widget("fcoeNicCombo")) while True: + # make sure the dialog pops into foreground in case this is the second + # time through the loop: + dialog.present() rc = dialog.run() if rc in [gtk.RESPONSE_CANCEL, gtk.RESPONSE_DELETE_EVENT]: @@ -415,6 +418,7 @@ def addZfcpDrive(anaconda): sg.add_widget(dxml.get_widget(w)) while True: + dialog.present() rc = dialog.run() if rc != gtk.RESPONSE_APPLY: break -- 1.7.3.3

3 2

[PATCHES rhel6-branch] two bug fixes
by Chris Lumens 21 Jan '11

21 Jan '11

Here's five patches to fix two bugs. The last three patches are needed to make the updated glade file work correctly. - Chris

2 6

[rhel6-branch][master] two s390x patches
by David Cantrell 21 Jan '11

21 Jan '11

1) Prevent unclean filesystems on first reboot after installation. 2) Another followup to /boot on LVM. zipl requires that the logical volume containing /boot be mapped to a single physical volume. This is doable if you pass a device name at the end of the lvcreate command (e.g., "/dev/dasde1"). The comment explains more. The use case is very narrowly defined right now. This is really only going to work for autopart users. So if someone does manual partitioning and neglects /boot, we won't really catch that, but I don't care much about that. I'm not entirely sold on my method of determining a single PV. I gather a list, sort it, and take the last one. Someone who knows more about LVM may want to comment on that. -- David Cantrell <dcantrell(a)redhat.com> Red Hat / Honolulu, HI

3 4

[PATCH] Support passing updates= to liveinst via the boot command line.
by Chris Lumens 20 Jan '11

20 Jan '11

--- data/liveinst/liveinst | 30 +++++++++++++++++++++++++++++- 1 files changed, 29 insertions(+), 1 deletions(-) diff --git a/data/liveinst/liveinst b/data/liveinst/liveinst index a892a9b..7416978 100755 --- a/data/liveinst/liveinst +++ b/data/liveinst/liveinst @@ -58,7 +58,7 @@ fi # Allow running another command in the place of anaconda, but in this same # environment. This allows storage testing to make use of all the module # loading and lvm control in this file, too. -ANACONDA=${LIVECMD:=/usr/sbin/anaconda --liveinst --method=livecd://$LIVE_BLOCK $INSTLANG} +ANACONDA=${LIVECMD:=anaconda --liveinst --method=livecd://$LIVE_BLOCK $INSTLANG} # load modules that would get loaded by the loader... (#230945) for i in raid0 raid1 raid5 raid6 raid456 raid10 dm-mod dm-zero dm-mirror dm-snapshot dm-multipath dm-round-robin vfat dm-crypt cbc sha256 lrw xts iscsi_tcp iscsi_ibft; do /sbin/modprobe $i 2>/dev/null ; done @@ -95,6 +95,9 @@ for opt in `cat /proc/cmdline`; do xdriver=*) ANACONDA="$ANACONDA --$opt" ;; + updates=*) + UPDATES="${opt#updates=}" + ;; esac done @@ -103,12 +106,37 @@ anaconda-cleanup $ANACONDA $* /sbin/udevadm control --env=ANACONDA=1 +# Set up the updates, if provided. +if [ ! -z "$UPDATES" ]; then + if [ -e /tmp/updates.img -o -e /tmp/updates ]; then + zenity --error --title="Updates already exist" --text "updates= was provided, but an updates image already exists. Please remove /tmp/updates.img and /tmp/updates and try again." + exit 1 + fi + + curl -o /tmp/updates.img $UPDATES + mkdir /tmp/updates + + # We officially support two updates.img formats: a filesystem image, and + # a compressed cpio blob. + if [ ! -z "$(file /tmp/updates.img | grep 'gzip compressed data')" ]; then + ( cd /tmp/updates ; gzip -dc /tmp/updates.img | cpio -id ) + else + mount -t auto /tmp/updates.img /tmp/updates + fi + + export PYTHONPATH=/tmp/updates:$PYTHONPATH + export LD_LIBRARY_PATH=/tmp/updates:$LD_LIBRARY_PATH + export PATH=/tmp/updates:$PATH +fi + if [ -x /usr/bin/udisks ]; then /usr/bin/udisks --inhibit -- "$ANACONDA $*" else $ANACONDA $* fi +rm -r /tmp/updates /tmp/updates.img + # try to teardown the filesystems if this was an image install if [ $IMAGE_INSTALL = 1 -a $RESCUE = 0 ]; then anaconda-cleanup -- 1.7.1.1

2 1

[PATCH] Revert "Bold the warning for GPT on non-EFI (#614585)"
by Brian C. Lane 20 Jan '11

20 Jan '11

This reverts commit 5b08388cbad175e2f466971d0d04c82df1894680. Revert adding markup argument which caused problems with text installs. Resolves: rhbz#671143 --- gui.py | 8 +++----- storage/__init__.py | 4 ++-- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/gui.py b/gui.py index 76c3514..3dfbddb 100755 --- a/gui.py +++ b/gui.py @@ -685,7 +685,7 @@ class MessageWindow: def getrc (self): return self.rc - def __init__ (self, title, text, type="ok", default=None, custom_buttons=None, custom_icon=None, run = True, parent = None, destroyAfterRun = True, markup=False): + def __init__ (self, title, text, type="ok", default=None, custom_buttons=None, custom_icon=None, run = True, parent = None, destroyAfterRun = True): self.debugRid = None self.title = title if flags.autostep: @@ -723,8 +723,6 @@ class MessageWindow: style = gtk.MESSAGE_INFO self.dialog = gtk.MessageDialog(mainWindow, 0, style, buttons, str(text)) - if markup: - self.dialog.set_property("use-markup", True) if parent: self.dialog.set_transient_for(parent) @@ -1114,14 +1112,14 @@ class InstallInterface(InstallInterfaceBase): return ProgressWindow (title, text, total, updpct, pulse = pulse) def messageWindow(self, title, text, type="ok", default = None, - custom_buttons=None, custom_icon=None, markup=False): + custom_buttons=None, custom_icon=None): if self.icw: parent = self.icw.window else: parent = None rc = MessageWindow (title, text, type, default, - custom_buttons, custom_icon, run=True, parent=parent, markup=markup).getrc() + custom_buttons, custom_icon, run=True, parent=parent).getrc() return rc def reinitializeWindow(self, title, path, size, description, details): diff --git a/storage/__init__.py b/storage/__init__.py index 00053ce..2c10003 100644 --- a/storage/__init__.py +++ b/storage/__init__.py @@ -179,7 +179,7 @@ def storageComplete(anaconda): if not iutil.isEfi() and bootdisk and bootdisk.format \ and bootdisk.format.type == 'disklabel' \ and bootdisk.format.labelType == 'gpt': - warning = _("\n\n<b>WARNING:</b>\n" + warning = _("\n\nWARNING:\n" "You are using a GPT bootdisk on a non-EFI " "system. This may not work, depending on you BIOS's " "support for booting from GPT disks.") @@ -197,7 +197,7 @@ def storageComplete(anaconda): type = "custom", custom_icon="warning", custom_buttons=[_("Go _back"), _("_Write changes to disk")], - default = 0, markup=True) + default = 0) # Make sure that all is down, even the disks that we setup after popluate. anaconda.id.storage.devicetree.teardownAll() -- 1.7.3.4

2 1

← Newer
1
2
3
4
5
6
7
8
9
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Anaconda-devel January 2011