April 2015 - anaconda-patches - Fedora mailing-lists

Updated: [rhinstaller/blivet/pulls/76 master] Do not continue when presented with unusable storage configurations
by dashea 13 Apr '15

13 Apr '15

There are some issues that must be resolved before blivet can do anything useful. The two that this PR addresses are multiple LVM VGs with the same name and disklabel corruption that prevents parted from acknowledging a disklabel when partitions are present on the disk. Until the lvm tools accept UUID in place of VG name for at least lvremove, vgchange, and vgremove we have no way to work with multiple VGs with the same name. This related bug has been sitting since 2008: https://bugzilla.redhat.com/show_bug.cgi?id=449832 The first patch enables parted to proceed with a partially-corrupt GPT disklabel, but I suspect it will not cover all such cases, hence the exception handling. There will soon be an accompanying anaconda PR that handles these exceptions by showing the error and the suggested course of action to the user. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/76

1 4

Updated: [rhinstaller/blivet/pulls/71 master] Consolidate common code in DeviceFormat class methods.
by dashea 13 Apr '15

13 Apr '15

This is the same model used within the device classes, which has worked pretty well. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/71

1 1

New: [rhinstaller/anaconda/pulls/61 master] Master multiple mounts
by dashea 13 Apr '15

13 Apr '15

Use changes in https://github.com/rhinstaller/blivet/pull/69 to handle cases where we have a device mounted multiple places. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/61

1 6

Updated: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 13 Apr '15

13 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 8

New: [rhinstaller/anaconda/pulls/66 master] Give users a chance to fix unusable initial storage layouts
by dashea 13 Apr '15

13 Apr '15

If there is an issue with the initial storage configuration that must be resolved before installation can continue, give the user an opportunity to resolve it. If they do, they can retry the storage scan and proceed with the installation. If not, they have to exit the installer. Limits on input quality are not unreasonable. This relies on rhinstaller/blivet#76 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/66

1 10

[anaconda][master/f22-branch] Make reuse of LUKS devices work
by Vratislav Podzimek 13 Apr '15

13 Apr '15

These two patches fix issues with reuse of LUKS devices for a new installation reported in bug #1210254 and discovered by me after fixing the first part. Vratislav Podzimek (2): Make the Encrypt checkbox insensitive for encrypted non-BTRFS devices (#1210254) Set both .format's and .originalFormat's passphrase on unlock pyanaconda/ui/gui/spokes/custom.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- 2.1.0

2 4

New: [rhinstaller/blivet/pulls/76 master] Do not continue when presented with unusable storage configurations
by dashea 13 Apr '15

13 Apr '15

There are some issues that must be resolved before blivet can do anything useful. The two that this PR addresses are multiple LVM VGs with the same name and disklabel corruption that prevents parted from acknowledging a disklabel when partitions are present on the disk. Until the lvm tools accept UUID in place of VG name for at least lvremove, vgchange, and vgremove we have no way to work with multiple VGs with the same name. This related bug has been sitting since 2008: https://bugzilla.redhat.com/show_bug.cgi?id=449832 The first patch enables parted to proceed with a partially-corrupt GPT disklabel, but I suspect it will not cover all such cases, hence the exception handling. There will soon be an accompanying anaconda PR that handles these exceptions by showing the error and the suggested course of action to the user. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/76

1 9

New: [rhinstaller/blivet/pulls/71 master] Consolidate common code in DeviceFormat class methods.
by dashea 13 Apr '15

13 Apr '15

This is the same model used within the device classes, which has worked pretty well. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/71

1 17

Updated: [rhinstaller/blivet/pulls/72 master] Pickling support for Size
by dashea 12 Apr '15

12 Apr '15

I need to pickle size instances in blivet-gui for multiprocess communication and \__reduce__ function inherited from decimal causes precision loss and other problems. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/72

1 15

Updated: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 10 Apr '15

10 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 0

New: [rhinstaller/anaconda/pulls/64 rhel6-branch] Fix a regression caused by adding thinp support
by dashea 10 Apr '15

10 Apr '15

Resolves: rhbz#1200832 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/64

2 8

New: [rhinstaller/blivet/pulls/74 master] Trivial Test Fixes
by dashea 10 Apr '15

10 Apr '15

Easy ack. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/74

1 5

[PATCH lorax rhel7-branch] Port of lmc pxe to live support to
by Radek Vykydal 10 Apr '15

10 Apr '15

The patches are already on master and also on rhel 7 atomic dist-git branch. I needed to pull two patches from master.

2 8

New: [rhinstaller/lorax/pulls/15 master] Added Sphinx Documentation
by dashea 09 Apr '15

09 Apr '15

Run 'make docs' to update the apidocs. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/15

1 7

Updated: [rhinstaller/blivet/pulls/66 master] Fix some Python 3 compatibility issues and add the python3 subpackage
by dashea 09 Apr '15

09 Apr '15

Fixes for Python 3 compatibility issues discovered while running tests with Python 3 including hundreds of installations with Python 3 Anaconda. With all that passing in the end, I decided to add the pieces that make sure the python3 subpackage is built too (tested in [Copr builds] (https://copr.fedoraproject.org/coprs/bkabrda/py3anaconda/builds/)). **Disclaimer:** These patches don't try to fix anything else than Python 3 incompatibilities in the most straightforward way. Many changes are subject for future improvements and nicer solutions. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/66

1 16

[master/f22-branch] Fix for a possible F22 final blocker
by Vratislav Podzimek 09 Apr '15

09 Apr '15

PATCH 1/2 is just a minor "style" change, PATCH 2/2 actually fixes the bug #1210003. Vratislav Podzimek (2): Mark the back_clicked attribute of the Storage spoke as private Reset the back_clicked flag if we stay on the Storage spoke (#1210003) pyanaconda/ui/gui/spokes/storage.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) -- 2.1.0

2 3

[PATCH] Preserve the order of boot args added by kickstart.
by Chris Lumens 08 Apr '15

08 Apr '15

This adds OrderedSet to anaconda, just like it is in pykickstart. I have added additional functionality that we need to the Arguments class in bootloader.py so if OrderedSet is needed elsewhere, it won't inherit the special behavior. This also attempts to keep "rhgb quiet" at the end of the line by moving where passed-in command line arguments are processed to the very end. Note that the storage args get popped off much earlier. Resolves: rhbz#1188948 --- anaconda.spec.in | 2 +- pyanaconda/bootloader.py | 47 ++++++++++++++++++------------------ pyanaconda/orderedset.py | 63 ++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 88 insertions(+), 24 deletions(-) create mode 100644 pyanaconda/orderedset.py diff --git a/anaconda.spec.in b/anaconda.spec.in index 92a54d2..b97f7d6 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -4,7 +4,7 @@ Summary: Graphical system installer Name: anaconda Version: @PACKAGE_VERSION@ Release: @PACKAGE_RELEASE@%{?dist} -License: GPLv2+ +License: GPLv2+ and MIT Group: Applications/System URL: http://fedoraproject.org/wiki/Anaconda diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index cdd596f..568a61d 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -43,6 +43,7 @@ from pyanaconda.nm import nm_device_hwaddress from blivet import platform from blivet.size import Size from pyanaconda.i18n import _, N_ +from pyanaconda.orderedset import OrderedSet import logging log = logging.getLogger("anaconda") @@ -124,12 +125,7 @@ def _is_on_iscsi(device): class BootLoaderError(Exception): pass -class Arguments(set): - ordering_dict = { - "rhgb" : 99, - "quiet" : 100 - } - +class Arguments(OrderedSet): def _merge_ip(self): """ Find ip= arguments targetting the same interface and merge them. @@ -140,7 +136,7 @@ class Arguments(set): # automatic network setup: return arg.startswith("ip=") and arg.count(":") == 1 ip_params = filter(partition_p, self) - rest = set(filter(lambda p: not partition_p(p), self)) + rest = OrderedSet(filter(lambda p: not partition_p(p), self)) # split at the colon: ip_params = map(lambda p: p.split(":"), ip_params) @@ -162,13 +158,18 @@ class Arguments(set): def __str__(self): self._merge_ip() - # sort the elements according to their values in ordering_dict. The - # higher the number the closer to the final string the argument - # gets. The default is 50. - lst = sorted(self, key=lambda s: self.ordering_dict.get(s, 50)) - + lst = list(self) return " ".join(lst) + def add(self, key): + self.discard(key) + OrderedSet.add(self, key) + + def update(self, other): + for key in other: + self.discard(key) + self.add(key) + class BootLoaderImage(object): """ Base class for bootloader images. Suitable for non-linux OS images. """ def __init__(self, device=None, label=None, short=None): @@ -845,17 +846,6 @@ class BootLoader(object): self.boot_args.update(setup_args) self.dracut_args.update(setup_args) - # passed-in objects - for cfg_obj in list(args) + kwargs.values(): - if hasattr(cfg_obj, "dracutSetupArgs"): - setup_args = cfg_obj.dracutSetupArgs() - self.boot_args.update(setup_args) - self.dracut_args.update(setup_args) - else: - setup_string = cfg_obj.dracutSetupString() - self.boot_args.add(setup_string) - self.dracut_args.add(setup_string) - # This is needed for FCoE, bug #743784. The case: # We discover LUN on an iface which is part of multipath setup. # If the iface is disconnected after discovery anaconda doesn't @@ -890,6 +880,17 @@ class BootLoader(object): self.boot_args.add(new_arg) + # passed-in objects + for cfg_obj in list(args) + kwargs.values(): + if hasattr(cfg_obj, "dracutSetupArgs"): + setup_args = cfg_obj.dracutSetupArgs() + self.boot_args.update(setup_args) + self.dracut_args.update(setup_args) + else: + setup_string = cfg_obj.dracutSetupString() + self.boot_args.add(setup_string) + self.dracut_args.add(setup_string) + # # configuration # diff --git a/pyanaconda/orderedset.py b/pyanaconda/orderedset.py new file mode 100644 index 0000000..125d57c --- /dev/null +++ b/pyanaconda/orderedset.py @@ -0,0 +1,63 @@ +# Copyright 2009 Raymond Hettinger +# Distributed under the MIT license +# Obtained at http://code.activestate.com/recipes/576694/ + +import collections + +class OrderedSet(collections.MutableSet): + + def __init__(self, iterable=None): + self.end = end = [] + end += [None, end, end] # sentinel node for doubly linked list + self.map = {} # key --> [key, prev, next] + if iterable is not None: + self |= iterable + + def __len__(self): + return len(self.map) + + def __contains__(self, key): + return key in self.map + + def add(self, key): + if key not in self.map: + end = self.end + curr = end[1] + curr[2] = end[1] = self.map[key] = [key, curr, end] + + def discard(self, key): + if key in self.map: + key, prev, next = self.map.pop(key) # pylint: disable=redefined-builtin + prev[2] = next + next[1] = prev + + def __iter__(self): + end = self.end + curr = end[2] + while curr is not end: + yield curr[0] + curr = curr[2] + + def __reversed__(self): + end = self.end + curr = end[1] + while curr is not end: + yield curr[0] + curr = curr[1] + + def pop(self, last=True): # pylint: disable=arguments-differ + if not self: + raise KeyError('set is empty') + key = self.end[1][0] if last else self.end[2][0] + self.discard(key) + return key + + def __repr__(self): + if not self: + return '%s()' % (self.__class__.__name__,) + return '%s(%r)' % (self.__class__.__name__, list(self)) + + def __eq__(self, other): + if isinstance(other, OrderedSet): + return len(self) == len(other) and list(self) == list(other) + return set(self) == set(other) -- 2.2.2

2 1

New: [rhinstaller/blivet/pulls/72 master] Pickling support for Size
by dashea 08 Apr '15

08 Apr '15

I need to pickle size instances in blivet-gui for multiprocess communication and \__reduce__ function inherited from decimal causes precision loss and other problems. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/72

1 8

[PATCH] Don't unconditionally set ksdata.lang.seen to True (#1209927)
by Martin Kolman 08 Apr '15

08 Apr '15

Only set it to True if language is set by the user. Otherwise Geolocation would not work. Signed-off-by: Martin Kolman <mkolman(a)redhat.com> --- anaconda | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/anaconda b/anaconda index ad0a69c..d9ef103 100755 --- a/anaconda +++ b/anaconda @@ -1227,6 +1227,7 @@ if __name__ == "__main__": # If command line options or kickstart set LANG, override the environment if opts.lang: os.environ["LANG"] = opts.lang # pylint: disable=environment-modify + ksdata.lang.seen = True elif ksdata.lang.lang: os.environ["LANG"] = ksdata.lang.lang # pylint: disable=environment-modify @@ -1245,7 +1246,6 @@ if __name__ == "__main__": os.environ["LANG"] = constants.DEFAULT_LANG # pylint: disable=environment-modify localization.setup_locale(os.environ["LANG"], ksdata.lang) - ksdata.lang.seen = True import blivet blivet.enable_installer_mode() -- 2.1.0

2 2

Updated: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 08 Apr '15

08 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 7

Updated: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 07 Apr '15

07 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 4

Updated: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 07 Apr '15

07 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 4

Updated: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 07 Apr '15

07 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 5

Updated: [rhinstaller/blivet/pulls/68 master] Use /sys to obtain sizes of existing devices
by dashea 07 Apr '15

07 Apr '15

parted.Device is quite heavy for just tracking device size. Due to its intended purpose being quite different from how blivet uses it, it becomes problematic in certain situations related to uevents, udev rules, and things like md arrays. Specifically, deleting a parted.Device involves closing a read/write file descriptor, which generates a "change" uevent, which triggers all sorts of udev rules. If the device whose parted.Device you just deleted happened to be a member of an md array, the result would be that the array would get activated. One way this can happen is by simply calling Blivet.reset on a system with an inactive md array. Obviously, this is unacceptable on the basis that storage libraries (or modules) must not activate system devices without having been instructed to do so. This business of closing rw fds gets even less convenient when blivet begins listening for and reacting to uevents, so this is a prerequisite for that. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/68

1 6

New: [rhinstaller/anaconda/pulls/62 master] TUI pwpolicy setup was supposed to be in __init__ not refresh (#1208607)
by dashea 07 Apr '15

07 Apr '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/62

1 5

New: [rhinstaller/blivet/pulls/69 master] Master multiple mounts
by dashea 07 Apr '15

07 Apr '15

Fix dynamic mountpoint code to allow multiple mounts when the user specifies the mountpoint. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/69

1 11

New: [rhinstaller/anaconda/pulls/63 f22-branch] Revert "allow /boot on btrfs subvol or filesystem"
by dashea 07 Apr '15

07 Apr '15

This reverts commit 6dd9f042b607a6dc4e8d299009c62c5f98e6d5d4. We really don't have support for /boot on btrfs working, turn this off to prevent bugs. Related: rhbz#1200539 Related: rhbz#864198 Related: rhbz#1094489 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/63

1 6

New: [rhinstaller/blivet/pulls/70 master] Master 1208536
by dashea 07 Apr '15

07 Apr '15

Resolves: fed#1208536 -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/70

1 6

Updated: [rhinstaller/blivet/pulls/67 f22-branch] F22 1208536
by dashea 07 Apr '15

07 Apr '15

Also for master. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/67

1 9

New: [rhinstaller/blivet/pulls/68 master] Use /sys to obtain sizes of existing devices
by dashea 07 Apr '15

07 Apr '15

parted.Device is quite heavy for just tracking device size. Due to its intended purpose being quite different from how blivet uses it, it becomes problematic in certain situations related to uevents, udev rules, and things like md arrays. Specifically, deleting a parted.Device involves closing a read/write file descriptor, which generates a "change" uevent, which triggers all sorts of udev rules. If the device whose parted.Device you just deleted happened to be a member of an md array, the result would be that the array would get activated. One way this can happen is by simply calling Blivet.reset on a system with an inactive md array. Obviously, this is unacceptable on the basis that storage libraries (or modules) must not activate system devices without having been instructed to do so. This business of closing rw fds gets even less convenient when blivet begins listening for and reacting to uevents, so this is a prerequisite for that. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/68

1 10

[rhel6-branch] Make sure authconfig and firewalld packages are installed. (#1161682)
by Samantha N. Bueno 06 Apr '15

06 Apr '15

Unless a user specifies --nocore. Based on a patch by Masahiro Matsuya (mmatsuya(a)redhat.com) Resolves: rhbz#1161682 --- yuminstall.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/yuminstall.py b/yuminstall.py index da35677..ba9d048 100644 --- a/yuminstall.py +++ b/yuminstall.py @@ -1600,6 +1600,10 @@ debuglevel=6 anaconda.id.ksdata.services.enabled) or \ anaconda.id.storage.services or anaconda.id.network.hasActiveIPoIBDevice(): self.selectPackage("chkconfig") + else: + if not anaconda.id.ksdata.packages.nocore: + for pkg in ['authconfig', 'system-config-firewall-base']: + self.selectPackage(pkg) def doPostSelection(self, anaconda): # Only solve dependencies on the way through the installer, not the way back. -- 1.8.3.1

2 1

New: [rhinstaller/anaconda/pulls/58 master] Connect scroll adjustments in the right class (#1206472)
by dashea 06 Apr '15

06 Apr '15

Sure are a lot of classes in that file -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/58

1 6

Updated: [rhinstaller/anaconda/pulls/60 master] Enforce sane disk selections.
by dashea 02 Apr '15

02 Apr '15

There is no value (and a great deal of trouble) in allowing users to split up an existing md array, lvm vg, or btrfs volume by selecting a subset of the disks it uses. This practice has led to the filing of several bugs, mainly by individuals engaged in testing the installer. The only bug id I have handy is 1198367, which I'll edit into the commit message for the rhel7-branch commit. This requires rhinstaller/blivet#63 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/60

1 3

Updated: [rhinstaller/blivet/pulls/63 master] Bits needed to enforce sane disk selection in anaconda
by dashea 02 Apr '15

02 Apr '15

This goes with rhinstaller/anaconda#60 - move getRelatedDisks into blivet as suggested by both @vpodzime and @mulkieran - tweak getDependentDevices to (optionally) work with hidden devices -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/63

1 3

New: [rhinstaller/lorax/pulls/14 f22-branch] Include cryptsetup in the image (#1208214)
by dashea 02 Apr '15

02 Apr '15

blivet dropped its requirement on cryptsetup, but fedup needs it in the upgrade.img and it is useful for rescue mode so add it back. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/14

1 5

Updated: [rhinstaller/anaconda/pulls/60 master] Enforce sane disk selections.
by dashea 02 Apr '15

02 Apr '15

There is no value (and a great deal of trouble) in allowing users to split up an existing md array, lvm vg, or btrfs volume by selecting a subset of the disks it uses. This practice has led to the filing of several bugs, mainly by individuals engaged in testing the installer. The only bug id I have handy is 1198367, which I'll edit into the commit message for the rhel7-branch commit. This requires rhinstaller/blivet#63 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/60

1 1

Updated: [rhinstaller/blivet/pulls/67 f22-branch] F22 1208536
by dashea 02 Apr '15

02 Apr '15

Also for master. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/67

1 3

New: [rhinstaller/blivet/pulls/67 f22-branch] F22 1208536
by dashea 02 Apr '15

02 Apr '15

Also for master. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/67

1 5

Updated: [rhinstaller/anaconda/pulls/59 f22-branch] Allow overriding password policy check
by dashea 02 Apr '15

02 Apr '15

The Fedora Engineering Steering Committee decided that Fedora 22 will restore the double-click of "done" to override the password policy check. This is a temporary measure while FESCo works on a distro-wide security policy to be implemented in Fedora 23. Details: https://fedorahosted.org/fesco/ticket/1412#comment:40 https://fedoraproject.org/wiki/User:Kevin/Draft_Passwordpolicy -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/59

1 4

Updated: [rhinstaller/anaconda/pulls/60 master] Enforce sane disk selections.
by dashea 02 Apr '15

02 Apr '15

There is no value (and a great deal of trouble) in allowing users to split up an existing md array, lvm vg, or btrfs volume by selecting a subset of the disks it uses. This practice has led to the filing of several bugs, mainly by individuals engaged in testing the installer. The only bug id I have handy is 1198367, which I'll edit into the commit message for the rhel7-branch commit. This requires rhinstaller/blivet#63 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/60

1 2

Updated: [rhinstaller/anaconda/pulls/60 master] Enforce sane disk selections.
by dashea 02 Apr '15

02 Apr '15

There is no value (and a great deal of trouble) in allowing users to split up an existing md array, lvm vg, or btrfs volume by selecting a subset of the disks it uses. This practice has led to the filing of several bugs, mainly by individuals engaged in testing the installer. The only bug id I have handy is 1198367, which I'll edit into the commit message for the rhel7-branch commit. This requires rhinstaller/blivet#63 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/60

1 1

Updated: [rhinstaller/anaconda/pulls/60 master] Enforce sane disk selections.
by dashea 02 Apr '15

02 Apr '15

There is no value (and a great deal of trouble) in allowing users to split up an existing md array, lvm vg, or btrfs volume by selecting a subset of the disks it uses. This practice has led to the filing of several bugs, mainly by individuals engaged in testing the installer. The only bug id I have handy is 1198367, which I'll edit into the commit message for the rhel7-branch commit. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/60

1 4

New: [rhinstaller/blivet/pulls/66 master] Fix some Python 3 compatibility issues and add the python3 subpackage
by dashea 02 Apr '15

02 Apr '15

Fixes for Python 3 compatibility issues discovered while running tests with Python 3 including hundreds of installations with Python 3 Anaconda. With all that passing in the end, I decided to add the pieces that make sure the python3 subpackage is built too (tested in [Copr builds] (https://copr.fedoraproject.org/coprs/bkabrda/py3anaconda/builds/)). **Disclaimer:** These patches don't try to fix anything else than Python 3 incompatibilities in the most straightforward way. Many changes are subject for future improvements and nicer solutions. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/66

1 15

Updated: [rhinstaller/blivet/pulls/61 master] Use LVname not VG-LVname when adding LVs
by dashea 02 Apr '15

02 Apr '15

The VG-LVname string is not a key in the dictionary constructed from the 'lvm lvs' output and if by some chance (really high on Python 3) e.g. a thin pool is requested to be added by a thin LV, using VG-LVname as the key raises a KeyError while the info about the pool LV is in the dictionary as expected. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/61

1 4

New: [rhinstaller/blivet/pulls/64 master] ]Wrap keys() with a list so that the dictionary can be changed
by dashea 02 Apr '15

02 Apr '15

In Python 3 the keys() dictionary method returns and iterator, which we can't use if we want to modify the dictionary while iterating over it (it raises a RuntimeError). So wrap keys() with a list to prevent this from happening. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/64

1 5

New: [rhinstaller/blivet/pulls/62 master] Add back DeviceTree's methods and properties used from the outside
by dashea 02 Apr '15

02 Apr '15

These methods/properties were moved to Populator and ActionList classes, but to keep the API we need to provide them in the DeviceTree class too. Also make the 'dasd' property settable because that's what Anaconda does. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/62

1 4

New: [rhinstaller/blivet/pulls/63 master] Bits needed to enforce sane disk selection in anaconda
by dashea 02 Apr '15

02 Apr '15

This goes with rhinstaller/anaconda#60 - move getRelatedDisks into blivet as suggested by both @vpodzime and @mulkieran - tweak getDependentDevices to (optionally) work with hidden devices -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/63

1 10

New: [rhinstaller/anaconda/pulls/60 master] Enforce sane disk selections.
by dashea 01 Apr '15

01 Apr '15

There is no value (and a great deal of trouble) in allowing users to split up an existing md array, lvm vg, or btrfs volume by selecting a subset of the disks it uses. This practice has led to the filing of several bugs, mainly by individuals engaged in testing the installer. The only bug id I have handy is 1198367, which I'll edit into the commit message for the rhel7-branch commit. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/60

1 16

New: [rhinstaller/anaconda/pulls/59 f22-branch] Allow overriding password policy check
by dashea 01 Apr '15

01 Apr '15

The Fedora Engineering Steering Committee decided that Fedora 22 will restore the double-click of "done" to override the password policy check. This is a temporary measure while FESCo works on a distro-wide security policy to be implemented in Fedora 23. Details: https://fedorahosted.org/fesco/ticket/1412#comment:40 https://fedoraproject.org/wiki/User:Kevin/Draft_Passwordpolicy -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/59

1 5

New: [rhinstaller/blivet/pulls/61 master] Use LVname not VG-LVname when adding LVs
by dashea 01 Apr '15

01 Apr '15

The VG-LVname string is not a key in the dictionary constructed from the 'lvm lvs' output and if by some chance (really high on Python 3) e.g. a thin pool is requested to be added by a thin LV, using VG-LVname as the key raises a KeyError while the info about the pool LV is in the dictionary as expected. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/61

1 5

New: [rhinstaller/anaconda/pulls/57 master] Master anaconda dracut tests
by dashea 31 Mar '15

31 Mar '15

Do some testing on parse-kickstart so that we can be more confident that a python3 version of it is working correctly. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/57

1 10

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches April 2015