anaconda-patches April 2015

anaconda-patches@lists.fedorahosted.org

14 participants
151 discussions

New: [rhinstaller/blivet/pulls/96 master] Master lvm
by dashea 29 Apr '15

29 Apr '15

Correct a bug where only lvm logical volumes and physical volumes where looked up correctly in devicetree. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/96

1 6

New: [rhinstaller/blivet/pulls/100 master] Un-escape '-'s in names or paths for _all_ lvm lv or vgs.
by dashea 28 Apr '15

28 Apr '15

Assume that whenever lvm presents blivet w/ a name with two consecutive dashes this represents an escaped single dash. Previously only doing this for lvmvg's and lvmlv's, which turned out to be a problem when looking up subclass instances, like lvm thin lvs. Signed-off-by: mulhern <amulhern(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/100

1 4

Updated: [rhinstaller/anaconda/pulls/86 master] Master docs
by dashea 28 Apr '15

28 Apr '15

I've been trying to figure out how to create good docs for pyanaconda using Read the Docs, and have hit a dead end. RTD depends on the autodoc feature in Sphinx, but can't install anything other than python projects with a setup.py. You can mock various objects like I did in the previous pass at this, but that's fragile and still doesn't result in complete docs. So, I propose that we generate the docs on a system with all the build deps installed or available via repos so that they are complete and nice looking, and that we carry the html output in the repo. This allows us to either server it up ourselves from someplace, or use gh-pages to serve it from github (which is what I suggest). My understanding is you create a gh-pages branch for the project, then copy the html into the root of that branch (so it really isn't a branch, just a place to store the html for github). I'd suggest doing this manually so that the output can be checked for import problems. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/86

1 6

New: [rhinstaller/anaconda/pulls/88 f22-branch] Configure proxy settings for dnf payload (#1211122)
by dashea 28 Apr '15

28 Apr '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/88

1 7

New: [rhinstaller/blivet/pulls/82 rhel7-branch] Include LUKSDevice information in kickstart data (#1139222)
by dashea 28 Apr '15

28 Apr '15

Resolves: rhbz#1139222 Previously, if a device had a child that was a LUKS device that child was ignored when generating ksdata. What this meant was that that device's format, which was luks, was used in generating the kickstart data. Now, the LUKSDevice, which contains the format that should appear in the ks output is used. This means that the LUKS format is used to set some ks data, but the mountpoint and so forth are overwritten with the correct values when the format on the LUKSDevice is used to populate those values. The --passphrase option with passphrase continues to not appear in the output anaconda-ks.cfg file. Signed-off-by: mulhern <amulhern(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/82

1 8

New: [rhinstaller/blivet/pulls/88 rhel7-branch] If the parent volume has a label, use it in subvol's kickstart (#1072060...
by dashea 28 Apr '15

28 Apr '15

...) Resolves: rhbz#1072060 The LABEL= entry identifies the parent of the specified subvolume by its label. If the parent volume does not have a label, then no entry is made that identifies the parent volume and the generated kickstart file will be rejected by ksvalidator. Signed-off-by: mulhern <amulhern(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/88

1 4

New: [rhinstaller/blivet/pulls/94 master] Move definition of _level attribute above super-constructor call.
by dashea 28 Apr '15

28 Apr '15

The basic problem is that level is a very important concept for md so a lot of log messages log this information. Some of these log messages are executed as a result of running the parent constructor. The particular problem I saw is that self.updateSize() is called by StorageDevice.__init__, which understandably logs the size, and the size() methods logs its result, along with the level, leading to an AttributeError. Now there will be no AttributeError, but the RAID level will be displayed as None when this happens. Signed-off-by: mulhern <amulhern(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/94

1 4

[Patch for Review] iSCSI Name Validation using regex.
by Sujith Pandel 27 Apr '15

27 Apr '15

Hi All, The following patch is to make use of a regular expression to validate the user given iSCSI Initiator name in Anaconda, while selecting iSCSI disks during OS installation. I have tested it for cases which I could think of at this time. Requesting review/feedback and inclusion. Thanks and Regards, Sujith Pandel When adding iSCSI target disk during installation, the iSCSI Initiator name and the Target IP is validated to enable/disable the "Start Discovery" button on the page. Currently, the validation of iSCSI Initiator Name is based on the existence of dots only (".") and this can be more efficiently done by using a regular expression. The conditions for iSCSI initiator name used in this regex are (https://tools.ietf.org/html/rfc3720#section-3.2.6.3.1 , https://tools.ietf.org/html/rfc3721#page-5 and http://standards.ieee.org/regauth/oui/tutorials/EUI64.html): 1. For iqn format: a. Starts with string 'iqn.' b. A date code specifying the year and month in which the organization registered the domain or sub-domain name used as the naming authority string. “yyyy-mm” c. A dot (".") d. The organizational naming authority string, which consists of a valid, reversed domain or subdomain name. e. Optionally, a colon (":"), followed by a string of the assigning organization's choosing, which must make each assigned iSCSI name unique. With the exception of the colon prefix, the owner of the domain name can assign everything after the reversed domain name as desired. 2. For eui format: The format is "eui." followed by an EUI-64 identifier (16 ASCII-encoded hexadecimal digits). Signed-off-by: Sujith Pandel <sujithpshankar(a)gmail.com> --- pyanaconda/regexes.py | 8 ++++++++ pyanaconda/ui/gui/spokes/advstorage/iscsi.py | 18 ++++++++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/pyanaconda/regexes.py b/pyanaconda/regexes.py index b4e52a3..f153915 100644 --- a/pyanaconda/regexes.py +++ b/pyanaconda/regexes.py @@ -135,3 +135,11 @@ REPO_NAME_VALID = re.compile(r'^[a-zA-Z0-9_.:-]+$') # Product Version string, just the starting numbers like 21 or 21.1 VERSION_DIGITS = r'([\d.]+)' + + +#iSCSI Naming Standards: RFC 3720 and RFC 3721 +ISCSI_IQN_NAMING_FORMAT = re.compile(r'^iqn\.\d{4}-\d{2}((?<!-)\.(?!-)[a-zA-Z0-9\-]+){1,63}(?<!-)(?<!\.)(:[^:]+)?') + +ISCSI_EUI_NAMING_FORMAT = re.compile(r'^eui\.[a-fA-F0-9]{16}') + + diff --git a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py index 22e11c3..764e81f 100644 --- a/pyanaconda/ui/gui/spokes/advstorage/iscsi.py +++ b/pyanaconda/ui/gui/spokes/advstorage/iscsi.py @@ -18,7 +18,7 @@ # # Red Hat Author(s): Chris Lumens <clumens(a)redhat.com> # - +import re from IPy import IP from collections import namedtuple from gi.repository import GLib @@ -29,6 +29,9 @@ from pyanaconda.ui.gui import GUIObject from pyanaconda.ui.gui.utils import escape_markup from pyanaconda.i18n import _ from pyanaconda import nm +from pyanaconda.regexes import ISCSI_IQN_NAMING_FORMAT +from pyanaconda.regexes import ISCSI_EUI_NAMING_FORMAT + __all__ = ["ISCSIDialog"] @@ -303,7 +306,18 @@ class ISCSIDialog(GUIObject): stripped = text.strip() #iSCSI Naming Standards: RFC 3720 and RFC 3721 - return "." in stripped + if stripped.startswith('iqn.'): + initiator_name_match = re.match(ISCSI_IQN_NAMING_FORMAT,stripped) + elif stripped.startswith('eui.'): + initiator_name_match = re.match(ISCSI_EUI_NAMING_FORMAT,stripped) + else: + return False + + if initiator_name_match and (len(initiator_name_match.group(0)) == len(stripped)): + return True + else: + return False + def on_discover_field_changed(self, *args): # Make up a credentials object so we can test if it's valid. -- 2.1.0

2 1

[blivet][master] Python3-ready pyparted needed
by Vratislav Podzimek 27 Apr '15

27 Apr '15

Blivet needs newer pyparted to provide real Python 3 compatibility. The pyparted package is not built yet, so I'll keep holding this patch off until that changes. Vratislav Podzimek (1): Require new version of pyparted with Python 3 related fixes python-blivet.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.0

2 2

Updated: [rhinstaller/blivet/pulls/87 rhel7-branch] Fix "anaconda hangs while trying to discover iscsi..." (#1166652)
by dashea 27 Apr '15

27 Apr '15

This was 2 errors in one. First problem: anaconda freeze for some time. Second problem: libiscsi was run on thread and libiscsi the library is not thread safe. Anaconda freeze is because of GIL is taken on library thread which is trying to connect to server. The thread safe problem is because libiscsi is using signals internally which were delivered to another thread (this is hard to solve in python threads...). Solution is to start discover method on new process. So new process is now created to call libiscsi discover_sendtargets method. This should fix both problems. Note: Will be applied to master too. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/87

1 7

← Newer
1
2
3
4
5
6
7
8
...
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches April 2015