----- Original Message -----
From: "Vratislav Podzimek" vpodzime@redhat.com To: "anaconda patch review" anaconda-patches@lists.fedorahosted.org Sent: Wednesday, June 25, 2014 1:52:40 AM Subject: Re: [blivet:master 1/7] Remove unnecessary fanciness about importing devices.
On Tue, 2014-06-24 at 13:04 -0400, mulhern wrote:
The name will go away when the function is exited, it does not need to be explicitly deleted. The name does not conflict with any other names in the method, to which it is local. There are no global 'devices'.
Signed-off-by: mulhern amulhern@redhat.com
blivet/udev.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/blivet/udev.py b/blivet/udev.py index c670e26..a1ff007 100644 --- a/blivet/udev.py +++ b/blivet/udev.py @@ -99,7 +99,7 @@ def udev_resolve_devspec(devspec): if not devspec: return None
- from . import devices as _devices
- from . import devices
Do we need to do this import locally in the first place? If not, we should move it to the global scope, if yes, there should be a comment explaining why.
-- Vratislav Podzimek
Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic
anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
Needed to avoid an import cycle. Done.
- mulhern