PATCH 1/2 adds some logging that becomes handy when you want to test a new addon.
PATCH 2/2 fixes the issue happening with kickstart installation after the changes introduced with the 'seen' attibute of pykickstart objects.
Vratislav Podzimek (2): Log failed imports in the collect functions Don't try to remove the timer when it's None (DatetimeSpoke)
pyanaconda/ui/common.py | 6 +++++- pyanaconda/ui/gui/spokes/datetime_spoke.py | 3 ++- 2 files changed, 7 insertions(+), 2 deletions(-)
Otherwise there is no other way to find out what happened other than rebooting and using pdb. --- pyanaconda/ui/common.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/pyanaconda/ui/common.py b/pyanaconda/ui/common.py index 29c97fe..8248bd5 100644 --- a/pyanaconda/ui/common.py +++ b/pyanaconda/ui/common.py @@ -27,6 +27,9 @@ import copy import sys import types
+import logging +log = logging.getLogger("anaconda") + class PathDict(dict): """Dictionary class supporting + operator""" def __add__(self, ext): @@ -556,7 +559,8 @@ def collect(module_pattern, path, pred): if not module_flags[0].startswith(".py") and loaded_ext.startswith(".py"): continue
- except ImportError: + except ImportError as imperr: + log.error("Failed to import module in collect: %s" % imperr) continue finally: imp.release_lock()
--- pyanaconda/ui/gui/spokes/datetime_spoke.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pyanaconda/ui/gui/spokes/datetime_spoke.py b/pyanaconda/ui/gui/spokes/datetime_spoke.py index 09f8435..adebb2f 100644 --- a/pyanaconda/ui/gui/spokes/datetime_spoke.py +++ b/pyanaconda/ui/gui/spokes/datetime_spoke.py @@ -403,7 +403,8 @@ class DatetimeSpoke(NormalSpoke): self.data.timezone.nontp = not self._ntpSwitch.get_active()
def execute(self): - GLib.source_remove(self._update_datetime_timer_id) + if self._update_datetime_timer_id is not None: + GLib.source_remove(self._update_datetime_timer_id) self._update_datetime_timer_id = None self.data.timezone.setup(self.data)
anaconda-patches@lists.fedorahosted.org