It's a method, not an attribute. We were only checking if the method existed. This caused teamd to always be pulled in. --- pyanaconda/install.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/install.py b/pyanaconda/install.py index a68e793..a0c6f7f 100644 --- a/pyanaconda/install.py +++ b/pyanaconda/install.py @@ -216,7 +216,7 @@ def doInstall(storage, payload, ksdata, instClass): if willInstallBootloader: packages += storage.bootloader.packages
- if network.is_using_team_device: + if network.is_using_team_device(): packages.append("teamd")
# don't try to install packages from the install class' ignored list and the
On Mon, Feb 23, 2015 at 12:31:11PM -0800, Adam Williamson wrote:
It's a method, not an attribute. We were only checking if the method existed. This caused teamd to always be pulled in.
pyanaconda/install.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/install.py b/pyanaconda/install.py index a68e793..a0c6f7f 100644 --- a/pyanaconda/install.py +++ b/pyanaconda/install.py @@ -216,7 +216,7 @@ def doInstall(storage, payload, ksdata, instClass): if willInstallBootloader: packages += storage.bootloader.packages
- if network.is_using_team_device:
if network.is_using_team_device(): packages.append("teamd")
# don't try to install packages from the install class' ignored list and the
-- 2.3.0
Good catch, ack.
On Mon, 2015-02-23 at 15:10 -0800, Brian C. Lane wrote:
On Mon, Feb 23, 2015 at 12:31:11PM -0800, Adam Williamson wrote:
It's a method, not an attribute. We were only checking if the method existed. This caused teamd to always be pulled in.
pyanaconda/install.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/install.py b/pyanaconda/install.py index a68e793..a0c6f7f 100644 --- a/pyanaconda/install.py +++ b/pyanaconda/install.py @@ -216,7 +216,7 @@ def doInstall(storage, payload, ksdata, instClass): if willInstallBootloader: packages += storage.bootloader.packages
- if network.is_using_team_device:
if network.is_using_team_device(): packages.append("teamd")
# don't try to install packages from the install class'
ignored list and the
2.3.0
Good catch, ack.
Can you push it? Obviously I don't have the powah. If you want to s/method/function/ in the commit message on the way, that's fine too :)
On Mon, 2015-02-23 at 15:10 -0800, Brian C. Lane wrote:
On Mon, Feb 23, 2015 at 12:31:11PM -0800, Adam Williamson wrote:
It's a method, not an attribute. We were only checking if the method existed. This caused teamd to always be pulled in.
pyanaconda/install.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/install.py b/pyanaconda/install.py index a68e793..a0c6f7f 100644 --- a/pyanaconda/install.py +++ b/pyanaconda/install.py @@ -216,7 +216,7 @@ def doInstall(storage, payload, ksdata, instClass): if willInstallBootloader: packages += storage.bootloader.packages
- if network.is_using_team_device:
if network.is_using_team_device(): packages.append("teamd")
# don't try to install packages from the install class' ignored list and the
-- 2.3.0
Good catch, ack.
That even seems like something we could make pylint catch for us. I doubt we do a valid check like this very often.
anaconda-patches@lists.fedorahosted.org