[fedora-arm] proposed rpm 4.4.2 diffs for ARM

(not subscribed to rpm-list@, please CC on replies) Hi all, Attached are two patches for rpm 4.4.2 (one against the package itself, one against its spec file) which slightly extend rpm's arm support, on which I would love to get some feedback, as I'm not entirely sure whether I Did The Right Thing in every place. Any comments? Should these patches be discussed on the 'upstream' (i.e. @rpm.org) rpm mailing lists instead? If they look OK, can they make it into F8? (Please don't apply this version as-is yet, though..) Thanks in advance for your time. thanks, Lennert === rpm-4.4.2-arm.diff Add creation of RPMS dirs for the various ARM sub-archs. This seems pretty straightforward. There are two different ABIs for ARM systems, the 'legacy' ABI (old-ABI) and the newer-and-preferred ABI, EABI. EABI is selected by configuring using a target triple ending in *-gnueabi (this is a slightly odd convention, but it's an upstream-imposed convention, and followed by binutils, gcc, glibc, etc.) There isn't an easier way of detecting EABI than to check whether gcc defines __ARM_EABI__, as far as I know. Strip -gnueabi off the target triple like we do with -gnulibc1 and -gnu. Make 'arm' the canon arch for all possible sub-archs. Idem. (Note that this isn't ARM-specific.) For some reason, it seems necessary to undefine _gnu twice here to really undefine it. (Same thing happens on my x86 boxes.) Not exactly sure what's happening here. Create /u/s/r/RPMS/$foo dirs for all possible sub-archs. Include all sub-archs. Add %arm macro so that we can check whether we are building for an ARM box by checking %ifarch %{arm}, to make it easier to add sub-archs without having to patch every single spec file that has some ARM- dependent logic in it. Check for ARM archs by checking against %{arm}, and just include all arm* dirs in /u/l/rpm in the package. Add optflags for the newer ARM sub-archs. I don't think we need -fsigned-char anymore, and maybe we should remove it from the other sub-archs as well. (chars are unsigned on ARM by default, and I think that doing -fsigned-char by default was meant to work around buggy userland software that assumes that chars are always signed. I don't think this should be needed anymore.) Add more sub-archs.. === rpm-4.4.2-spec-arm.diff Add ARM patch. This is a hack to make sure that %{_gnu} ends up as -gnueabi on EABI targets. Ideally this should perhaps be hacked into the macros.in -> macros generation step itself. Ideas? Same modification as to rpm.spec.in -- check %{arm} instead of a hardcoded list of sub-archs, and pick up all /u/l/rpm/arm* dirs. Thanks!