Re: [fedora-arm] [PATCH] libprelude: valgrind rpm not yet available for ARM. Disable checks.

On Mon, Dec 29, 2008 at 03:21:42PM +0530, Kedar Sovani wrote: > diff --git a/libprelude.spec b/libprelude.spec > index c769ab7..36995c3 100644 > --- a/libprelude.spec > +++ b/libprelude.spec > @@ -5,7 +5,7 @@ > > Name: libprelude > Version: 0.9.21.2 > -Release: 1%{?dist} > +Release: 1%{?dist}.fa1 This is fine for local use but shouldn't be submitted upstream. > @@ -15,7 +15,7 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) > > BuildRequires: gnutls-devel, python-devel, ruby, ruby-devel, lua-devel > BuildRequires: swig chrpath > -%ifnarch ppc ppc64 > +%ifnarch ppc ppc64 %{arm} > BuildRequires: valgrind > %endif This I understand.. > @@ -111,7 +111,7 @@ chmod -w %{buildroot}%{perl_vendorarch}/auto/Prelude/Prelude.so > touch -r ./configure.in %{buildroot}%{_sysconfdir}/prelude/default/* > > # PPC strips ld.so so valgrind can't run > -%ifnarch ppc ppc64 > +%ifnarch ppc ppc64 %{arm} > %check > make check > %endif But what is that for? At least the comment explains why PPC can't run the testsuite, but there's no such comment for ARM. Is it the same reason? Or a different reason?