#301: Reverse execute logic in control.autoqa -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Finger Food Component: core | Keywords: -------------------------+-------------------------------------------------- The 'execute' variable is True by default and the test must specify execute=False in control.autoqa if it doesn't want to be run. That leads to constructs as:
{{{ if event not in ['post-bodhi-update-batch']: execute = False }}}
This would be more comprehensible:
{{{ # execute = False by default if event in ['post-bodhi-update-batch']: execute = True }}}
I.e. we would convert negative logic (saying when it should not run) into positive logic (saying when it should run).
Do this change and make corresponding changes in all tests.
#301: Reverse execute logic in control.autoqa -------------------------+-------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: enhancement | Status: assigned Priority: minor | Milestone: Finger Food Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by vhumpa):
* owner: => vhumpa * status: new => assigned
#301: Reverse execute logic in control.autoqa -------------------------+-------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: enhancement | Status: assigned Priority: minor | Milestone: Finger Food Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by vhumpa):
Worked on this, please check: https://fedorahosted.org/reviewboard/r/133/
#301: Reverse execute logic in control.autoqa -------------------------+-------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: enhancement | Status: assigned Priority: minor | Milestone: Finger Food Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by kparal):
Reviewed.
#301: Reverse execute logic in control.autoqa -------------------------+-------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: enhancement | Status: closed Priority: minor | Milestone: Finger Food Component: core | Resolution: fixed Keywords: | -------------------------+-------------------------------------------------- Changes (by vhumpa):
* status: assigned => closed * resolution: => fixed
Comment:
Reviewed and pushed to master.
#301: Reverse execute logic in control.autoqa ---------------------------+------------------------------------------------ Reporter: kparal | Owner: vhumpa Type: enhancement | Status: reopened Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: Keywords: | ---------------------------+------------------------------------------------ Changes (by kparal):
* status: closed => reopened * resolution: fixed => * component: core => documentation * milestone: Finger Food => 0.5.0
Comment:
The commit was: 459f5edd97ca3157370100738bf584ee5d387af5
We still need to fix some documentation I believe, reopening with documentation component.
#301: Reverse execute logic in control.autoqa ---------------------------+------------------------------------------------ Reporter: kparal | Owner: vhumpa Type: enhancement | Status: closed Priority: minor | Milestone: 0.5.0 Component: documentation | Resolution: fixed Keywords: | ---------------------------+------------------------------------------------ Changes (by vhumpa):
* status: reopened => closed * resolution: => fixed
Comment:
Updated the documentation, here is the wiki diff: https://fedoraproject.org/w/index.php?title=Writing_AutoQA_Tests&diff=23... Change was necessary only in the above "Writing AutoQA Tests" page.
#301: Reverse execute logic in control.autoqa -------------------------+-------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: enhancement | Status: closed Priority: minor | Milestone: 0.5.0 Component: core | Resolution: fixed Keywords: | -------------------------+-------------------------------------------------- Changes (by kparal):
* component: documentation => core
autoqa-devel@lists.fedorahosted.org
-
fedora-badges