#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: Type: defect | Status: new Priority: major | Milestone: 0.4.7 Component: core | Keywords: --------------------+------------------------------------------------------- Depcheck currently uses bodhi comment detection (bodhi_already_commented()) to get list of previously accepted updates. The problem is that the update might have changed in the meantime. E.g. a new build might have been added to that update, removed, etc.
When we search for past AutoQA comments, we have to detect whether the update was changed after the last matching comment. If it was, we should claim that this update wasn't tested at all.
Example of a changed update:
https://admin.fedoraproject.org/updates/control-center-3.0.0-1.fc15,gnome- settings-daemon-3.0.0.1-1.fc15
One obvious way is to detect "xxx has edited this update" strings. A better way could be possible by looking into the bodhi update object and searching for last-modified timestamps or something like that.
#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: defect | Status: assigned Priority: major | Milestone: 0.4.7 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Changes (by vhumpa):
* owner: => vhumpa * status: new => assigned
#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: defect | Status: assigned Priority: major | Milestone: 0.4.7 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by vhumpa):
bodhi_already_commented() altered: in for review at https://fedorahosted.org/reviewboard/r/141
#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: defect | Status: assigned Priority: major | Milestone: 0.4.7 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by kparal):
Reviewed.
#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: defect | Status: assigned Priority: major | Milestone: 0.4.7 Component: core | Resolution: Keywords: | --------------------+------------------------------------------------------- Comment (by jskladan):
+1 to review from kparal.
#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: defect | Status: closed Priority: major | Milestone: 0.4.7 Component: core | Resolution: fixed Keywords: | --------------------+------------------------------------------------------- Changes (by vhumpa):
* status: assigned => closed * resolution: => fixed
Comment:
Applied notes from reviewboard and pushed into master as 6a4880576e21f5e5a8857dc218ace45199db396e.
#306: bodhi_utils: don't report changed updates as tested --------------------+------------------------------------------------------- Reporter: kparal | Owner: vhumpa Type: defect | Status: closed Priority: major | Milestone: 0.4.7 Component: core | Resolution: fixed Keywords: | --------------------+------------------------------------------------------- Comment (by kparal):
And what about stable? :-)
Pushed to stable: f266d6d264bdea30508a3cea41630a8472c40f2b
autoqa-devel@lists.fedorahosted.org
-
fedora-badges