/usr/share/autotest/client/bin/autotest --verbose -t post-repo-update:repoclosure.x86_64 /tmp/autoqa-control.O1kKrU
To really inspect what will be run (which is the reason why you run dry) you still need to inspect the control file. Therefore I think the --dry-run should quite conveniently also imply the --keep-control-file (which is a little long option to have to type it everytime).
What do you think, should I commit it or not?
When using dry run, it's almost certain the user will want to inspect contents of the config file, so let's keep it on the disk automatically. --- autoqa | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/autoqa b/autoqa index 5723498..10f53f9 100755 --- a/autoqa +++ b/autoqa @@ -132,7 +132,8 @@ parser.add_option('-t', '--test', action='append', parser.add_option('--keep-control-file', action='store_true', help='Do not delete generated control files') parser.add_option('--dryrun', '--dry-run', action='store_true', dest='dryrun', - help='Do not actually execute commands, just show what would be done') + help='Do not actually execute commands, just show what would be done \ +(implies --keep-control-file)') parser.add_option('--local', action='store_true', dest='local', help='Do not schedule jobs - run test(s) directly on the local machine') parser.add_option('-l', '--list-tests', action='store_true', dest='listtests', @@ -218,7 +219,7 @@ for arch in archlist: if retval != 0: print "ERROR: failed to schedule job %s" % testname
- if opts.keep_control_file: + if opts.keep_control_file or opts.dryrun: print "keeping %s at user request" % control else: os.remove(control)
autoqa-devel@lists.fedorahosted.org