#196: Log failed job scheduling -------------------------+-------------------------------------------------- Reporter: kparal | Owner: kparal Type: enhancement | Status: new Priority: major | Milestone: Component: harness | Version: 1.0 Keywords: | -------------------------+-------------------------------------------------- Currently when we schedule a job and it fails, we just print it out and forget about it:
{{{ retval = schedule_job(control, email=email, name=testname, required_arch=arch, dryrun=opts.dryrun, labels=aq_labels) if retval != 0: print "ERROR: failed to schedule job %s" % testname }}}
That should not be the case. We should: * use syslog and log important stuff to /var/log/autoqa.log or similar * send an email about failed scheduling to autoqa-results
That way we will know something is wrong and will be able to fix it. Otherwise it just silently fails and we don't know about it.
Feel free to reassign the ticket if you want to work on it.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: kparal Type: enhancement | Status: new Priority: minor | Milestone: 0.4.4 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by kparal):
* priority: major => minor * summary: Log failed job scheduling => Use standard logging facilities * milestone: => 0.4.4
Old description:
Currently when we schedule a job and it fails, we just print it out and forget about it:
{{{ retval = schedule_job(control, email=email, name=testname, required_arch=arch, dryrun=opts.dryrun, labels=aq_labels) if retval != 0: print "ERROR: failed to schedule job %s" % testname }}}
That should not be the case. We should:
- use syslog and log important stuff to /var/log/autoqa.log or similar
- send an email about failed scheduling to autoqa-results
That way we will know something is wrong and will be able to fix it. Otherwise it just silently fails and we don't know about it.
Feel free to reassign the ticket if you want to work on it.
New description:
Currently our watchers and the main autoqa script print all debug/error messages to standard (error) output. If it is run via cron, error output is sent to root. But there's no log of it. We should change that. We should use syslog and print all our messages to /var/log/autoqa.log or similar file (we can put there a lot of debug messages which can help resolve possible problems in the future).
So let's examine standard python logging capabilities and use them if possible.
We don't probably need to adjust tests, because tests are executed on clients and everything is perfectly logged and stored by autotest. Therefore this concerns just watchers/autoqa script I think.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.4.4 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by kparal):
* owner: kparal =>
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.4.4 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by kparal):
mkrizek tried to implement this, his code is in the 'logging' branch
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.5.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by kparal):
* milestone: 0.4.4 => 0.5.0
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by tflink):
* milestone: Nice to have soon => 0.7.0
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Changes (by mkrizek):
* owner: => mkrizek
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by mkrizek):
Patch: https://fedorahosted.org/reviewboard/r/229/
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by kparal):
Heavy comments addition warning!
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by mkrizek):
I added comments.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by mkrizek):
The patch is updated.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by kparal):
Reviewed.
Btw, please update the 'logging' branch.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by mkrizek):
The patch is updated as well as the 'logging' branch.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: new Priority: minor | Milestone: 0.7.0 Component: core | Resolution: Keywords: | -------------------------+-------------------------------------------------- Comment (by kparal):
Reviewed.
#196: Use standard logging facilities -------------------------+-------------------------------------------------- Reporter: kparal | Owner: mkrizek Type: enhancement | Status: closed Priority: minor | Milestone: 0.7.0 Component: core | Resolution: fixed Keywords: | -------------------------+-------------------------------------------------- Changes (by mkrizek):
* status: new => closed * resolution: => fixed
Comment:
Pushed: 3b1fbabd35cad3537da5e3bf6a171a3a08a38518
autoqa-devel@lists.fedorahosted.org