[PATCH 0/2] Minor improvements for mock packaging on EL-6
by Todd Zullinger
Hi,
I noticed that bash-completion stopped working a few months or so ago on
EL-6. Looking closer, it's because the completion files are installed
in the wrong place for the older bash-completion on EL-6. I know EL-6
isn't getting feature updates, but if there's a bugfix update for it,
this would be nice to include. I filed this in pagure when I first
noticed it, as https://src.fedoraproject.org/rpms/mock/pull-request/1.
I've pushed a few updates to my pagure branch since then. I can either
update that PR to match what's included here or delete it, whichever is
preferred.
Todd Zullinger (2):
install bash-completion files in proper place for EL6
only call python3-pylint in %check if %use_python3 is set
mock.spec | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
--
2.15.0
6 years, 4 months
[PATCH] own bash-completion dir(s) in mock packaging
by Todd Zullinger
We don't require bash-completion. Own the completion dir(s) to ensure
they are cleaned up if mock is uninstalled.
---
This is for the master branch, which doesn't own the bash-completion dirs. I
didn't bump the release tag with this change, as I didn't think it would
warrant a build on its own.
mock.spec | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mock.spec b/mock.spec
index 06d4f01..41c3bf2 100644
--- a/mock.spec
+++ b/mock.spec
@@ -183,8 +183,11 @@ pylint-3 py/mockbuild/ py/*.py py/mockbuild/plugins/* || :
%defattr(0644, root, mock)
%config(noreplace) %{_sysconfdir}/mock/site-defaults.cfg
%if 0%{?rhel} == 6
+%dir %{_sysconfdir}/bash-completion.d
%{_sysconfdir}/bash_completion.d/mock
%else
+%dir %{_datadir}/bash-completion
+%dir %{_datadir}/bash-completion/completions
%{_datadir}/bash-completion/completions/mock
%{_datadir}/bash-completion/completions/mockchain
%endif
@@ -232,6 +235,9 @@ pylint-3 py/mockbuild/ py/*.py py/mockbuild/plugins/* || :
%endif
%changelog
+* Sun Nov 26 2017 Todd Zullinger <tmz(a)pobox.com>
+- Own bash-completion dir(s)
+
* Tue Oct 31 2017 Miroslav Suchý <msuchy(a)redhat.com> 1.4.7-1
- user and group is actually not used here since some logic moved to buildroot.py
- add config_opts['chrootgroup'] to site-defaults.cfg
--
2.15.0
6 years, 4 months