-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Dmitri,
I have a few comments about the configuration work:
CandlpinConfiguration -
* why is it CandlepinConfiguration and not just Configuration? or Config :)
* why do we store the File object in CandlepinConfiguration? as opposed to storing just the filename, then in loadProperties() create a new File object there for loading.
* I don't quite understand the configurationWithPrefix method?
* why is there a special JPAConfiguration() class? (I'll respond more on this when I find the commit)
ConfigurationFileLoader -
* why store the File? could just make loadProperties() take in a file
* loadConfiguration() name seems redundant since it is the ConfigurationFileLoader(), I think load() would've sufficed.
* any reason we're converting Properties into HashMaps?
So far I don't see how we'll use the CandlepinConfiguration. For instance, in spacewalk I'd commonly want to do: Config.get().getString("a.b.c.url"); or Config.get().getInt("a.b.timeoutvalue");
Maybe we're not to that point yet.
Thanks jesus
- -- jesus m. rodriguez | jesusr@redhat.com principal software engineer | irc: zeus red hat systems management | 919.754.4413 (w) rhce # 805008586930012 | 919.623.0080 (c) +---------------------------------------------+ | "Those who cannot remember the past | | are condemned to repeat it." | | -- George Santayana | +---------------------------------------------+