Gitweb: http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitd... Commit: 8407be4c4ee5711a7e0be50444aeff4ba7f0ee26 Parent: 71f46b8688811540f0bfd53b63b55915a5b34ebc Author: Bob Peterson <rpeterso(a)redhat.com&gt; AuthorDate: Wed Feb 10 13:46:58 2010 -0600 Committer: Bob Peterson <rpeterso(a)redhat.com&gt; CommitterDate: Wed Feb 10 13:58:38 2010 -0600 gfs2_edit savemeta: Don't release indirect buffers too soon This patch fixes a regression in the "gfs2_edit savemeta" command whereby system files such as journals were not being saved. The function that processes indirect block lists was releasing buffers in a fashion that works okay with the old buf.c assumptions but too soon for the new buf.c assumptions. rhbz#455300 --- gfs2/edit/savemeta.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/gfs2/edit/savemeta.c b/gfs2/edit/savemeta.c index 44adaf0..45c9cb7 100644 --- a/gfs2/edit/savemeta.c +++ b/gfs2/edit/savemeta.c @@ -300,9 +300,7 @@ static void save_indirect_blocks(int out_fd, osi_list_t *cur_list, } if (height != hgt) { /* If not at max height */ nbh = bread(&sbd, indir_block); - osi_list_add_prev(&nbh->b_altlist, - cur_list); - brelse(nbh); + osi_list_add_prev(&nbh->b_altlist, cur_list); } } /* for all data on the indirect block */ }