Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=... Commit: defbc63a9c88389327ceee3410ca4efeec089254 Parent: 87c6039736fb05560f664d15cbb762936ba8b492 Author: Abhijith Das <adas(a)redhat.com&gt; AuthorDate: Tue Sep 22 14:43:52 2009 -0500 Committer: Abhijith Das <adas(a)redhat.com&gt; CommitterDate: Tue Sep 22 14:48:55 2009 -0500 gfs-kernel: Bug 471258 - fatal: assertion "gfs_glock_is_locked_by_me(gl) && gfs_glock_is_held_excl(gl)" failed Patch to manage racing gfs_creates when selinux is in permissive mode. With selinux in permissive mode, I've been able to hit this bug pretty easily. It arises when two processes (on different nodes) race each other to create the same file. Upon successful creation of the inode, security xattr for it needs to be written when selinux is in permissive mode. One of the racing processes creates the inode and succeeds in acquiring an EXclusive lock on it to set the xattr. The other process fails to actually create the inode (seeing that it exists by now), and does a lookup (which returns a SHared lock) instead to complete the operation. However, this process goes on and incorrectly attempts to write xattr, which fails with the above assert because it doesn't hold an EX lock on the inode. The process on the second node should not be attempting to write xattrs since it did not create the inode in the first place. This patch ensures that. --- gfs-kernel/src/gfs/ops_inode.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gfs-kernel/src/gfs/ops_inode.c b/gfs-kernel/src/gfs/ops_inode.c index 400ec13..bac215c 100644 --- a/gfs-kernel/src/gfs/ops_inode.c +++ b/gfs-kernel/src/gfs/ops_inode.c @@ -140,7 +140,7 @@ gfs_create(struct inode *dir, struct dentry *dentry, if (!inode) error = -ENOMEM; - else + else if (new) error = gfs_security_init(dip, ip); gfs_glock_dq_uninit(&d_gh);