I was looking through the code last night and noticed you'd commented out the modify_list function. This is the function that handles all the paging functions like # of items per page, current page, etc. I've noticed previously that it was functionally very similar to the modify_filter function, so I went ahead and merged the filter stuff into the modify_list() function, and modified the urls and template to use the new method.
modify_filter() is still in the code, but is no longer being used, but I left it for now. I added a header comment to the function explaining what it does, and also added a few comments in the code to clarify things.
Pushed to my github:
commit 3903476bf2955f901487dce0d1916ad93de58e5f Author: James Cammarata jimi@sngx.net Date: Wed May 20 06:33:36 2009 -0500
Fixing modify_list function and merging it with the modify_filter function
James Cammarata wrote:
I was looking through the code last night and noticed you'd commented out the modify_list function. This is the function that handles all the paging functions like # of items per page, current page, etc. I've noticed previously that it was functionally very similar to the modify_filter function, so I went ahead and merged the filter stuff into the modify_list() function, and modified the urls and template to use the new method.
modify_filter() is still in the code, but is no longer being used, but I left it for now. I added a header comment to the function explaining what it does, and also added a few comments in the code to clarify things.
Pushed to my github:
commit 3903476bf2955f901487dce0d1916ad93de58e5f Author: James Cammarata jimi@sngx.net Date: Wed May 20 06:33:36 2009 -0500
Fixing modify_list function and merging it with the modify_filter
function
Merged, thanks.
Everyone else --you're not forgotten, I'll merge the rest of the queue a bit later as we get further along on the web app. This is taking most of my attention ATM.
--Michael
cobbler-devel@lists.fedorahosted.org