Vreman, Peter - Acision wrote:
Please find a patch attached building on top of the generic list patch
I sent before:
- multiple delete support (still missing a recursive checkbox)
- generic copy and rename
- cleanup of the edit/rename/copy in generic edit (it is now
implemented like I already did for the systems in the old 1.6.x webui)
- generic save method based on the get_fields
I noticed that the names (e.g. ksmeta<>ks_meta, dhcptag<>dhcp_tag) in
the get_fields() are different from the names in the remote_methods()
list. This creates conflicts and fails to save the fields. Maybe the
remote_method names need to be adjusted or even be replaced by the new
get_fields() structure.
All merged in, thanks!
The remote method names are the ones we must use in that case, as
various important things depend on our remote XMLRPC API remaining
constant (Satellite/Spacewalk is #1, there are others). Though I don't
think that would be a problem as long as all the HTML fields support
underscores and such. We may need to add a field for the CLI name,
i.e. --kopts is not "kernel_options", and some hypenation is hard to
automate, though I think the webapp can use the names that match the
remote_methods names.
Longer term, I see the remote_methods hash going away entirely as we can
put the name of the modifier into the "get_fields" datastructure and
call it with eval, or something else reasonably clever. (Method
handles themselves won't be serializable, so we can't return the actual
handles).
--Michael