[Bug 1859387] New: Container Review Request - php-73-fedora - Platform for building and running PHP 7.3 applications
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
Bug ID: 1859387 Summary: Container Review Request - php-73-fedora - Platform for building and running PHP 7.3 applications Product: Fedora Container Images Version: 31 Status: NEW Component: Container Review Assignee: nobody@fedoraproject.org Reporter: craig@teamrobinson.us QA Contact: extras-qa@fedoraproject.org CC: container-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Container Build Info URL: https://github.com/sclorg/s2i-php-container/blob/master/7.3/Dockerfile.fedor... Description: PHP container image based on Fedora andintended for OKD and general usage, that provide a platform for building and running PHP applications. Fedora Account System Username: cragr
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
--- Comment #1 from cragr craig@teamrobinson.us --- Maybe use a similar image naming scheme as the centos images like php-73-f31 for PHP version 7.3 Fedora version 31?
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |athoscribeiro@gmail.com Assignee|nobody@fedoraproject.org |athoscribeiro@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
--- Comment #2 from Athos Ribeiro athoscribeiro@gmail.com --- Are you in the packager group already?
If not, you may also want to look for a sponsor.
See https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
--- Comment #3 from Athos Ribeiro athoscribeiro@gmail.com --- Moreover, are you planning on packaging all those files in the directory with the Dockerfile?
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
--- Comment #4 from cragr craig@teamrobinson.us --- (In reply to Athos Ribeiro from comment #2)
Are you in the packager group already?
If not, you may also want to look for a sponsor.
See https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
Moreover, are you planning on packaging all those files in the directory with the Dockerfile?
I am not in the packager group and have contacted one person so far for sponsorship, status is pending.
I have no plans to package files, the image will be built using that exact Dockerfile.fedora from the sclorg repo.
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |clems.verna@gmail.com Flags| |needinfo?(clems.verna@gmail | |.com)
--- Comment #5 from Athos Ribeiro athoscribeiro@gmail.com --- By "packaging files", I mean using the files being copied into the image in the Dockerfile in lines 61 and 64. If so, I believe the files should be linked here for the Review (let me know if you'd like me to go through that repository instead).
As for the image name, I believe the $FGC has been dropped from the guidelines, where we should now use just the main component name in the package. Moreover, shouldn't this bug name be the same as the image name and component, i.e., php? Then you could manipulate the image tag depending on the base image used to point to the proper php version you want to ship. Otherwise, we'd have to package/review this image multiple times for different Fedora releases. Thoughts?
I am also pinging Clement here to hear his ideas on this one :)
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
Clement Verna clems.verna@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(clems.verna@gmail | |.com) |
--- Comment #6 from Clement Verna clems.verna@gmail.com --- I believe the php s2i image is already available https://src.fedoraproject.org/container/php, it has just not been built in a while :(
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(craig@teamrobinso | |n.us)
--- Comment #7 from Athos Ribeiro athoscribeiro@gmail.com --- Any objections on closing this as a duplicate of BZ#1445784?
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
cragr craig@teamrobinson.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(craig@teamrobinso | |n.us) |
--- Comment #8 from cragr craig@teamrobinson.us --- (In reply to Clement Verna from comment #6)
I believe the php s2i image is already available https://src.fedoraproject.org/container/php, it has just not been built in a while :(
Correct. I would like to update these images if possible. The Fedora 31 version would include PHP7.3 an Fedora 32 would include PHP7.4.
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
Athos Ribeiro athoscribeiro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(craig@teamrobinso | |n.us)
--- Comment #9 from Athos Ribeiro athoscribeiro@gmail.com --- In this case, you should contact rpitonak ( the owner of https://src.fedoraproject.org/container/php). For the PRs in that repo, he seems to be inactive. If that is the case, you could start a non-responsive packager process.
Packaging this under a different name does not seems to be the way forward here though.
https://bugzilla.redhat.com/show_bug.cgi?id=1859387
cragr craig@teamrobinson.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Flags|needinfo?(craig@teamrobinso | |n.us) | Last Closed| |2020-08-18 17:12:07
--- Comment #10 from cragr craig@teamrobinson.us --- Closing with recommendation of contacting rpitonak.
container-review@lists.fedoraproject.org
-
bugzilla＠redhat.com