https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Bug ID: 1483358 Summary: Container Review Request - Greenwave - Service for making decisions based on test results Product: Fedora Container Images Version: 26 Component: Container Review Assignee: nobody@fedoraproject.org Reporter: mjia@redhat.com QA Contact: extras-qa@fedoraproject.org CC: container-review@lists.fedoraproject.org
Container Build Info URL: https://fedorapeople.org/~mjia/containers/greenwave/Dockerfile Description: Service for making decisions based on test results Fedora Account System Username: mjia
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
--- Comment #1 from Dan Callaghan dcallagh@redhat.com --- This will need a README.md as per: https://fedoraproject.org/wiki/Container:Guidelines#Help_File
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
--- Comment #2 from Dan Callaghan dcallagh@redhat.com --- Also noticed a small typo:
MAINTAINER Matt Jia" mjia@redhat.com
It has an extraneous quote character.
Also according to https://docs.docker.com/engine/reference/builder/#maintainer-deprecated the MAINTAINER command is deprecated anyway. So maybe just drop it? We already have all the usual distribution-level mechanisms for maintainership here anyway. No reason we need to name a specific person in the Dockerfile.
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
--- Comment #3 from matt jia mjia@redhat.com --- Okay, let's try v2:
https://fedorapeople.org/~mjia/containers/greenwave/v2/Dockerfile https://fedorapeople.org/~mjia/containers/greenwave/v2/README.md
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Adam Miller admiller@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |admiller@redhat.com Assignee|nobody@fedoraproject.org |admiller@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Adam Miller admiller@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #4 from Adam Miller admiller@redhat.com --- Thanks for the initial review Dan, it all looks good with things updated based on your feedback.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rbean@redhat.com Summary|Container Review Request - |Container Review Request: |Greenwave - Service for |Greenwave - Service for |making decisions based on |making decisions based on |test results |test results
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Ralph Bean rbean@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Container Review Request: |Container Review Request: |Greenwave - Service for |greenwave - Service for |making decisions based on |making decisions based on |test results |test results
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
--- Comment #5 from Ralph Bean rbean@redhat.com --- Filed https://pagure.io/releng/fedora-scm-requests/issue/283
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
--- Comment #6 from Ralph Bean rbean@redhat.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/container/greenwave
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Dan Callaghan dcallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #7 from Dan Callaghan dcallagh@redhat.com --- Thanks Ralph! I see you've also imported the sources and done a build:
https://koji.fedoraproject.org/koji/buildinfo?buildID=960717
I can successfully docker pull candidate-registry.fedoraproject.org/f26/greenwave:latest
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
--- Comment #8 from Fedora End Of Life jkurik@fedoraproject.org --- This message is a reminder that Fedora 26 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '26'.
Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version.
Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 26 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above.
Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
https://bugzilla.redhat.com/show_bug.cgi?id=1483358
Dan Callaghan dcallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2018-05-04 02:16:02
--- Comment #9 from Dan Callaghan dcallagh@redhat.com --- Oops. Probably should have closed this ages ago! Our greenwave container is working nicely.
container-review@lists.fedoraproject.org