[copr] master: W: 61, 12: Else clause on loop without a break statement (useless-else-on-loop) (d8f119d)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit d8f119d1278c28095efa21e7f216e5f6b59c43f7
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 08:47:52 2014 +0200
W: 61,12: Else clause on loop without a break statement (useless-else-on-loop)
>---------------------------------------------------------------
python/copr/client/responses.py | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/python/copr/client/responses.py b/python/copr/client/responses.py
index 7871234..2c13658 100644
--- a/python/copr/client/responses.py
+++ b/python/copr/client/responses.py
@@ -58,8 +58,7 @@ class CoprResponse(object):
request_kwargs=self.request_kwargs)
self._parsed_data[item] = value
return value
- else:
- raise KeyError(str(item))
+ raise KeyError(str(item))
def __str__(self):
return str(self.data)
9 years, 7 months
[copr] master: W: 18, 0: Unused import Task (unused-import) (494dd9b)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 494dd9be9b0c40d3c3ff24997bc8c0471c6e4210
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 09:13:02 2014 +0200
W: 18, 0: Unused import Task (unused-import)
>---------------------------------------------------------------
backend/backend/dispatcher.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/backend/backend/dispatcher.py b/backend/backend/dispatcher.py
index 0455c36..d233b70 100644
--- a/backend/backend/dispatcher.py
+++ b/backend/backend/dispatcher.py
@@ -15,7 +15,6 @@ from ansible import callbacks
from bunch import Bunch
from setproctitle import setproctitle
from IPy import IP
-from retask.task import Task
from retask.queue import Queue
from .exceptions import MockRemoteError, CoprWorkerError
9 years, 7 months
[copr] master: W: 5, 0: Unused import sys (unused-import) (eadc282)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit eadc282c2c7657f6f5e2185da570669887f282de
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 08:56:33 2014 +0200
W: 5, 0: Unused import sys (unused-import)
>---------------------------------------------------------------
python/setup.py | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/python/setup.py b/python/setup.py
index b495867..4cb6990 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -2,8 +2,6 @@
from setuptools import setup
-import sys
-
long_description = """Copr is designed to be a lightweight buildsystem that allows contributors
to create packages, put them in repositories, and make it easy for users
to install the packages onto their system. Within the Fedora Project it
9 years, 7 months
[copr] master: W:355, 12: Redefining built-in id (redefined-builtin) (85d479f)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 85d479f03040c4780ba98be6e7342e644a5ce281
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 09:07:45 2014 +0200
W:355,12: Redefining built-in id (redefined-builtin)
>---------------------------------------------------------------
backend/copr-be.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/backend/copr-be.py b/backend/copr-be.py
index 005d6bd..75bccbc 100755
--- a/backend/copr-be.py
+++ b/backend/copr-be.py
@@ -371,9 +371,9 @@ class CoprBackend(object):
self.abort = True
for group in self.opts.build_groups:
- id = group["id"]
- for w in self.workers[id]:
- self.workers[id].remove(w)
+ group_id = group["id"]
+ for w in self.workers[group_id]:
+ self.workers[group_id].remove(w)
w.terminate()
self.clean_task_queues()
9 years, 7 months
[copr] master: W: 13, 0: Unused import glob (unused-import) (6726aa9)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 6726aa9a3d681a364dcb6c2000fbad16a7d2791e
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 09:08:42 2014 +0200
W: 13, 0: Unused import glob (unused-import)
>---------------------------------------------------------------
backend/copr-be.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/backend/copr-be.py b/backend/copr-be.py
index 75bccbc..ec0f6e6 100755
--- a/backend/copr-be.py
+++ b/backend/copr-be.py
@@ -10,7 +10,6 @@ from retask.queue import Queue
from retask import ConnectionError
import ConfigParser
import daemon
-import glob
import grp
import json
import lockfile
9 years, 7 months
[copr] master: actually pass pkgs (3cd77a9)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 3cd77a9218765a2e8416e5daf57f332f6b287c22
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 08:52:26 2014 +0200
actually pass pkgs
and do not pass username, None is default value
>---------------------------------------------------------------
python/copr/client/responses.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/python/copr/client/responses.py b/python/copr/client/responses.py
index 2c13658..0b0f375 100644
--- a/python/copr/client/responses.py
+++ b/python/copr/client/responses.py
@@ -222,7 +222,7 @@ class ProjectChrootHandle(BaseHandle):
Shortcut to :meth:`~.client.CoprClient.modify_project_chroot_details`
"""
return self.client.modify_project_chroot_details(
- self.projectname, self.chrootname, pkgs=None, username=None)
+ self.projectname, self.chrootname, pkgs=pkgs)
class ProjectWrapper(object):
9 years, 7 months
[copr] master: W:189, 16: Redefining built-in id (redefined-builtin) (df2d48f)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit df2d48f9c7d5be142298b41a05c837c02a5c978c
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 09:01:43 2014 +0200
W:189,16: Redefining built-in id (redefined-builtin)
>---------------------------------------------------------------
backend/copr-be.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/backend/copr-be.py b/backend/copr-be.py
index 6f99ce3..5268e2e 100755
--- a/backend/copr-be.py
+++ b/backend/copr-be.py
@@ -199,9 +199,9 @@ class CoprBackend(object):
self.task_queues = []
try:
for group in self.opts.build_groups:
- id = group["id"]
- self.task_queues.append(Queue("copr-be-{0}".format(id)))
- self.task_queues[id].connect()
+ group_id = group["id"]
+ self.task_queues.append(Queue("copr-be-{0}".format(group_id)))
+ self.task_queues[group_id].connect()
except ConnectionError:
raise CoprBackendError(
"Could not connect to a task queue. Is Redis running?")
9 years, 7 months
[copr] master: W: 22, 0: Redefining built-in __name__ (redefined-builtin) (2674403)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 2674403913675816b455f787597baaa4f1911a86
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 08:58:35 2014 +0200
W: 22, 0: Redefining built-in __name__ (redefined-builtin)
>---------------------------------------------------------------
python/setup.py | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/python/setup.py b/python/setup.py
index 4cb6990..9df02d3 100644
--- a/python/setup.py
+++ b/python/setup.py
@@ -17,7 +17,6 @@ requires = [
]
-__name__ = 'copr'
__version__ = __version__
__description__ = __description__
__author__ = "Valentin Gologuzov"
@@ -26,7 +25,7 @@ __url__ = "http://fedorahosted.org/copr/"
setup(
- name=__name__,
+ name='copr',
version=__version__,
description=__description__,
long_description=long_description,
9 years, 7 months
[copr] master: wrap long line (831c1bf)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 831c1bfbebb9358a050f75556688d1489ff6ba12
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 09:11:50 2014 +0200
wrap long line
>---------------------------------------------------------------
backend/backend/mockremote.py | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/backend/backend/mockremote.py b/backend/backend/mockremote.py
index b37b845..567625d 100755
--- a/backend/backend/mockremote.py
+++ b/backend/backend/mockremote.py
@@ -460,7 +460,9 @@ class Builder(object):
self.mockremote.callback.log("Listing built binary packages")
self.conn.module_name = "shell"
- self.conn.module_args = "cd {0} && for f in `ls *.rpm | grep -v \"src.rpm$\"`; do rpm -qp --qf \"%{{NAME}} %{{VERSION}}\n\" $f; done".format(pipes.quote(self._get_remote_pkg_dir(pkg)))
+ self.conn.module_args = \
+ "cd {0} && for f in `ls *.rpm | grep -v \"src.rpm$\"`; do rpm -qp --qf \"%{{NAME}} %{{VERSION}}\n\" $f; done".format(
+ pipes.quote(self._get_remote_pkg_dir(pkg)))
results = self.conn.run()
build_details["built_packages"] = results["contacted"].itervalues().next()[u"stdout"]
self.mockremote.callback.log("Packages:\n"+build_details["built_packages"])
9 years, 7 months
[copr] master: C: 30, 0: Exactly one space required after comma (0ef1070)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 0ef1070cef4cf0cc34f1964f63327bde3ceb65bb
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Sep 10 08:55:19 2014 +0200
C: 30, 0: Exactly one space required after comma
>---------------------------------------------------------------
python/docs/conf.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/python/docs/conf.py b/python/docs/conf.py
index c8bb7ce..ff2001e 100644
--- a/python/docs/conf.py
+++ b/python/docs/conf.py
@@ -27,7 +27,7 @@ sys.path.insert(0, os.path.abspath('..'))
# Add any Sphinx extension module names here, as strings. They can be extensions
# coming with Sphinx (named 'sphinx.ext.*') or your custom ones.
-extensions = ['sphinx.ext.autodoc', 'sphinx.ext.coverage', 'sphinx.ext.ifconfig','sphinx.ext.viewcode']
+extensions = ['sphinx.ext.autodoc', 'sphinx.ext.coverage', 'sphinx.ext.ifconfig', 'sphinx.ext.viewcode']
# Add any paths that contain templates here, relative to this directory.
templates_path = ['_templates']
9 years, 7 months