Repository :
http://git.fedorahosted.org/cgit/copr.git
On branch : master
---------------------------------------------------------------
commit b83a08c236c353e636a3374501e4e3cc10ccdefc
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Thu Mar 6 21:06:23 2014 +0100
frontend: give nice error instead of traceback
addressing:
Exception on /coprs/rhscl/python27/delete/ [POST]
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/flask/app.py", line 1687, in
wsgi_app
response = self.full_dispatch_request()
File "/usr/lib/python2.7/site-packages/flask/app.py", line 1360, in
full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/lib/python2.7/site-packages/flask/app.py", line 1358, in
full_dispatch_request
rv = self.dispatch_request()
File "/usr/lib/python2.7/site-packages/flask/app.py", line 1344, in
dispatch_request
return self.view_functions[rule.endpoint](**req.view_args)
File "/usr/share/copr/coprs_frontend/coprs/views/misc.py", line 131, in
decorated_function
return f(*args, **kwargs)
File
"/usr/share/copr/coprs_frontend/coprs/views/coprs_ns/coprs_general.py", line
322, in copr_delete
coprs_logic.CoprsLogic.delete(flask.g.user, copr)
File "/usr/share/copr/coprs_frontend/coprs/logic/coprs_logic.py", line
162, in delete
cls.raise_if_cant_delete(user, copr)
File "/usr/share/copr/coprs_frontend/coprs/logic/coprs_logic.py", line
227, in raise_if_cant_delete
if not user.admin and user != copr.owner:
AttributeError: 'NoneType' object has no attribute 'owner'
---------------------------------------------------------------
.../coprs/views/coprs_ns/coprs_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
b/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
index 09de72a..cf56e12 100644
--- a/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
+++ b/coprs_frontend/coprs/views/coprs_ns/coprs_general.py
@@ -317,7 +317,7 @@ def copr_delete(username, coprname):
form = forms.CoprDeleteForm()
copr = coprs_logic.CoprsLogic.get(flask.g.user, username, coprname).first()
- if form.validate_on_submit():
+ if form.validate_on_submit() and copr:
try:
coprs_logic.CoprsLogic.delete(flask.g.user, copr)
except (exceptions.ActionInProgressException,