Repository :
http://git.fedorahosted.org/cgit/copr.git
On branch : master
---------------------------------------------------------------
commit d0e36f8422dc25bb23a4cff55b5e95eaceb9e1f3
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Wed Oct 30 09:09:38 2013 +0100
UX - add asterisk to required fields
In add new project field only.
Create new class "required" which automatically add red asterisk before
the tag.
Additionally add to this form required attribute, which move validation to browser.
---------------------------------------------------------------
coprs_frontend/coprs/static/copr.css | 7 +++++++
coprs_frontend/coprs/templates/_helpers.html | 4 ++--
.../coprs/templates/coprs/_coprs_forms.html | 4 ++--
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/coprs_frontend/coprs/static/copr.css b/coprs_frontend/coprs/static/copr.css
index 61a87d3..cde5420 100644
--- a/coprs_frontend/coprs/static/copr.css
+++ b/coprs_frontend/coprs/static/copr.css
@@ -360,3 +360,10 @@ hr {
.footer .last {
border-right: none;
}
+
+.required:before {
+ content: "* ";
+ color: red;
+ font-weight: bold;
+}
+
diff --git a/coprs_frontend/coprs/templates/_helpers.html
b/coprs_frontend/coprs/templates/_helpers.html
index 487a5dc..04630bb 100644
--- a/coprs_frontend/coprs/templates/_helpers.html
+++ b/coprs_frontend/coprs/templates/_helpers.html
@@ -1,6 +1,6 @@
-{% macro render_field(field, label=None) %}
+{% macro render_field(field, label=None, class='') %}
{% if not kwargs['hidden'] %}
- <dt class="field-label">{{ label or field.label }}</dt>
+ <dt class="field-label {{ class }}">{{ label or field.label
}}</dt>
<dd>
{% if field.errors %}
{% for error in field.errors %}
diff --git a/coprs_frontend/coprs/templates/coprs/_coprs_forms.html
b/coprs_frontend/coprs/templates/coprs/_coprs_forms.html
index 6fe89d9..4d3e7ab 100644
--- a/coprs_frontend/coprs/templates/coprs/_coprs_forms.html
+++ b/coprs_frontend/coprs/templates/coprs/_coprs_forms.html
@@ -12,10 +12,10 @@
<dl>
{{ form.csrf_token }}
{{ render_field(form.id, hidden = True) }}
- {{ render_field(form.name, label='Project Name') }}
+ {{ render_field(form.name, label='Project Name', required = True,
class="required") }}
{{ render_field(form.description, rows=5, cols=50) }}
{{ render_field(form.instructions, rows=5, cols=50) }}
- <dt class="field-label">Chroots</dt>
+ <dt class="field-label required">Chroots</dt>
{% if form._mock_chroots_error %}
<p class="form-error">{{ form._mock_chroots_error }}</p>
{% endif %}