Hi,
Can some of you guys please tell me what the Copr.repos class member is used for?
I understand that it contains .repo files, but where will these come from and where will they go? Are they .repos for pointing to coprs/chroots created within the copr application, or will they be used as external repos submitted by users for build time or even something else?
Does the variable hold URLs or a list of strings or something else? Now I dont't really know what the variable does and/or if I'm supposed to touch it when implementing the generation of repo files for coprs/chroots (TRAC ticket 21 [1]).
Thanks a lot, TR
[1] https://fedorahosted.org/copr/ticket/21
Hi,
----- Original Message -----
Hi,
Can some of you guys please tell me what the Copr.repos class member is used for?
I understand that it contains .repo files, but where will these come from and where will they go? Are they .repos for pointing to coprs/chroots created within the copr application, or will they be used as external repos submitted by users for build time or even something else?
Does the variable hold URLs or a list of strings or something else? Now I dont't really know what the variable does and/or if I'm supposed to touch it when implementing the generation of repo files for coprs/chroots (TRAC ticket 21 [1]).
Well, it is not exactly as you say. The Copr.repos list currently contains URLs of repos added to yum's baseurls (so basically the format that mockremote uses). Is this correct, Seth? I'm quite sure that you should not touch it in terms of changing it, but there is a question whether or not to add it to the generated repofile. On first look, it might seem to be a good idea, but on the other hand, that might be a security risk, since anyone can add anything into repos and we have no control over it. So let's start by not using Copr.repos at all for generating the .repo files.
Slavek.
Thanks a lot, TR
[1] https://fedorahosted.org/copr/ticket/21
-- Tomas Radej tradej@redhat.com _______________________________________________ copr-devel mailing list copr-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/copr-devel
On Fri, 1 Mar 2013 02:37:45 -0500 (EST) Bohuslav Kabrda bkabrda@redhat.com wrote:
Well, it is not exactly as you say. The Copr.repos list currently contains URLs of repos added to yum's baseurls (so basically the format that mockremote uses). Is this correct, Seth? I'm quite sure that you should not touch it in terms of changing it, but there is a question whether or not to add it to the generated repofile. On first look, it might seem to be a good idea, but on the other hand, that might be a security risk, since anyone can add anything into repos and we have no control over it. So let's start by not using Copr.repos at all for generating the .repo files.
You are correct. A repo provided buildrequires should not necessarily be thrust on a user who just wants to install the pkgs in the copr.
-sv
On Thu, 28 Feb 2013 18:44:38 +0100 Tomas Radej tradej@redhat.com wrote:
Hi,
Can some of you guys please tell me what the Copr.repos class member is used for?
where is the copr.repos class you're talking about?
do you mean the attribute of a copr which is repos? If so - that is just a list of repository baseurls which are used when mock is building the pkgs for the copr.
Those baseurls are used by mock to find additional buildrequirements for the pkgs it is building.
I understand that it contains .repo files, but where will these come from and where will they go? Are they .repos for pointing to coprs/chroots created within the copr application, or will they be used as external repos submitted by users for build time or even something else?
They are used as external repos submitted by users.
That right there.
Does the variable hold URLs or a list of strings or something else? Now I dont't really know what the variable does and/or if I'm supposed to touch it when implementing the generation of repo files for coprs/chroots (TRAC ticket 21 [1]).
urls are strings.
that variable has nothing to do with ticket 21.
ticket 21 is just about having the backend automatically generate the .repo file like it would be in /etc/yum.repos.d/
Does that make sense?
-sv
Hi,
On Wed, 6 Mar 2013 00:25:48 -0500 seth vidal skvidal@fedoraproject.org wrote:
where is the copr.repos class you're talking about?
coprs_frontend/coprs/models.py -> Copr.repos
do you mean the attribute of a copr which is repos? If so - that is just a list of repository baseurls which are used when mock is building the pkgs for the copr.
Those baseurls are used by mock to find additional buildrequirements for the pkgs it is building.
Right, thanks. It would be nice to have that as a comment in code.
urls are strings.
Ehm, of course. But with a variable of that name, you may be expecting an URL-formatted string, a repo definition (in .repo format, also as a string), a list of URLs, a list of .repo definitions, or anything related. As of now, I can't make the answer out from the data available in the code.
Does that make sense?
Indeed it does, and thanks for explanation, but I find it rather sub-optimal that it had to been made in an e-mail. Slavek told me that you are expecting some new guys to contribute to the project, therefore I would ask you to kindly focus on documenting such things very soon, so that the newcomers have as readable code as possible.
TR
On Fri, 8 Mar 2013 13:21:19 +0100 Tomas Radej tradej@redhat.com wrote:
Does that make sense?
Indeed it does, and thanks for explanation, but I find it rather sub-optimal that it had to been made in an e-mail. Slavek told me that you are expecting some new guys to contribute to the project, therefore I would ask you to kindly focus on documenting such things very soon, so that the newcomers have as readable code as possible.
You're right. I will work on explaining it in more detail in the code or in the readme in the git repo.
Thank you. -sv
copr-devel@lists.fedorahosted.org
-
Bohuslav Kabrda -
Seth Vidal -
Tomas Radej