On Wed, 2009-10-28 at 12:15 +0100, Martin Sourada wrote:
> On Wed, 2009-10-28 at 11:04 +0000, Bastien Nocera wrote:
> > On Wed, 2009-10-28 at 10:05 +0100, Martin Sourada wrote:
> > > On Wed, 2009-10-28 at 00:55 +0000, Bastien Nocera wrote:
> > > > This should be all fixed in:
> > > >
http://koji.fedoraproject.org/koji/buildinfo?buildID=138704
> > > >
> > > This one works as expected :)
> >
> > Finally, I also updated gnome-power-manager:
> >
http://koji.fedoraproject.org/koji/taskinfo?taskID=1774321
> >
> hrm, that one has now wrong positioning (at the top-left corner of the
> screen; testing brightness) and the progress bar is blurry. However,
> looking at the code, I fail to see, why :(
>
Actually, I've just found the source of blurriness:
in draw_action_brightness():
+ /* draw volume meter */
+ draw_volume_boxes (window,
+ cr,
+ (double)window->priv->volume_level / 100.0,
+ bright_box_x0 + 0.5,
+ bright_box_y0 + 0.5,
+ bright_box_width,
+ bright_box_height);
should be
+ /* draw volume meter */
+ draw_volume_boxes (window,
+ cr,
+ (double)window->priv->volume_level / 100.0,
+ bright_box_x0,
+ bright_box_y0,
+ bright_box_width,
+ bright_box_height);
as you are adding the 0.5 inside the draw_volume_boxes() already.
Good catch. That was some left-over from previous patches.
Not sure about the positioning issue though.