On Mon, 2009-10-26 at 16:00 +0100, Martin Sourada wrote:
> On Mon, 2009-10-26 at 14:50 +0100, Martin Sourada wrote:
> > On Mon, 2009-10-26 at 13:34 +0000, Bastien Nocera wrote:
> > > The sound volume one has an upstream bug:
> > >
https://bugzilla.gnome.org/show_bug.cgi?id=567249
> > >
> > Nice to see people from gnome-art team noticed it as well.
> >
> > > Patch would be most welcome
> > If I find the code that's responsible for this, I'll look into how to
> > patch it. But no promises.
> >
> > Martin
> Hrm, this one was a little bit harder to find where the problem is...
> You are actually trying to draw it on non-integer position, which of
> course results in blurry volume bar in most cases. I've workarounded
> that by hard retyping the values to (int), but use whatever you prefer
> in your code to get the integer values out of the double ones. Quickly
> tested patch attached.
I've attached a patch (and then an updated patch) to the upstream bug.
Mind testing it? Seems to look as expected for me.
When trying to build the fix into F12, I noticed we have a few of our
own changes.
Could you please make sure that: