On Tue, May 18, 2021 at 08:38:29AM -0700, Adam Williamson wrote:
> On Tue, 2021-05-18 at 08:26 -0500, Michael Catanzaro wrote:
> > You reported my complaints as:
> >
https://github.com/fedora-infra/bodhi/issues/4219. Thanks!
> >
> > I'm going to go ahead and ask that the gating be turned off until it's
> > fixed. If it doesn't display accurate test results, it's not even close
> > to being ready yet. Good gating is good, but bad gating is worse than
> > no gating.
>
> I don't really think this is necessary? It's not really
'displaying'
> anything inaccurate at any point. Just not totally clear. When the
> tests aren't yet run it shows that some results are missing, which is
> true. When they are finished it shows the correct status and gates
> correctly. What is it that you're saying is actually not accurate?
I don't think it needs to be turned off, but the issue does need to be
addressed. The first time I got a failure message, I had to go and
investigate. Took a minute to figure out what was going on. Now that I
know that it is the issue, I am ignoring those messages. I haven't seen
a real failure yet on anything I submitted, but I would assume the
message looks the same, and I likely won't notice until I go into bodhi
to do something with the update.
As for now, I think the gating is probably more valuable than the flawed
output of the tool. Leave it on, but perhaps add some priority to fixing
the issue?
I'm already planning to work on it today.
--
Adam Williamson
Fedora QA
IRC: adamw | Twitter: adamw_ha