On Sat, Feb 2, 2019 at 7:02 AM Samuel Rakitničan <
srakitnican(a)fedoraproject.org> wrote:
> On Sat, Feb 02, 2019 at 08:57:42AM -0000, Samuel Rakitničan
wrote:
>
> Guess the important question is, is the warning correct or not?
> If it is correct, certainly fix the code, if it is a false positive,
either
> find a workaround, turn the warning off (locally or globally) or don't
build
> wiht -Werror (or turn the particular warning into a warning only, say
> -Werror -Wno-error=whatever). Warnings do have false positives and with
> -Werror you need to be prepared to work around the warnings any time new
> ones appear, typically -Werror is a good fit only for some projects and
only
> for development builds.
The easiest would be to just disable -Werror because it doesn't help me
personally. Not sure if that is allowed by Fedora Packaging guidelines,
though.
$ rpm -E %optflags
-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
-grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
-fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection
The only required one seems to be for "format-security"...
Thanks,
Richard