Your Buildrequires are your declaration of what is required for the build the spec wants to do. You don't want it to depend on what happens to be around. I think what you want to do is: %define gnupg_version 1.2 %if "%fedora" >= "6" %define gnupg_version 1.4 %endif %if "%rhel" >= "5" %define gnupg_version 1.4 %endif ... BuildRequires: gnupg = %{gnupg_version} ... %check %if "%gnupg_version" = "1.2" this data %else that data %endif

On Sun, Feb 18, 2007 at 07:11:17PM -0800, Roland McGrath wrote: I don't know about Fedora, but on RHEL nothing on the system predefines the %rhel macro, that's purely an internal define in the RH build system. -- -- Jos Vos <jos(a)xos.nl&gt; -- X/OS Experts in Open Systems BV | Phone: +31 20 6938364 -- Amsterdam, The Netherlands | Fax: +31 20 6948204

On Monday 19 February 2007 06:13am, Jesse Keating wrote: Because of that, this technique really doesn't work for this package. For this RPM, I want to conditionally select which patch to apply based on the version of he installed gnupg package on the system it is building on. rpmbuild already has this information somewhere internally as it can compare versions for BuildRequires: lines. I'm looking for "something_that_gets_version" to use something like this: %define gnupg_version "%something_that_gets_version gnupg" %if "%gnupg_version" = "1.2" Patch1: GnuPG-Interface-0.33.test-results-1.2.patch BuildRequires: gpg = 1.2 %else Patch1: GnuPG-Interface-0.33.test-results-1.4.patch BuildRequires: gpg >= %{gnupg_version} %endif I need it to work for all sorts of distros, not just RHEL, FC and not just within buildsystems. Is there such a mechanism available for use in the SPEC file or do I need to execure an external rpm command to query for that on my own? -- Lamont Peterson <lamont(a)gurulabs.com&gt; Senior Instructor Guru Labs, L.C. [ http://www.GuruLabs.com/ ] NOTE: All messages from this email address should be digitally signed with my 0xDC0DD409 GPG key. It is available on the pgp.mit.edu keyserver as well as other keyservers that sync with MIT's.

On Saturday 10 March 2007 09:43am, Peter Gordon wrote: Yeah, that's basically what I'm trying now (still working on getting one of the patches built correctly too). I was just hoping there was a way internal to rpmbuild so I wouldn't have to run an external command, thinking that would probably be cleaner. Right now, I'm doing: %define gnupg_version %(rpm -q --queryformat '%{version}' gnupg 2>/dev/null | cut -d. -f 1,2) Yup. I like that idea, but in this case, the latest version doesn't need a patch. If/when a future release of gnupg changes the output again that make this patch necessary, then I'll create another set of entries to deal with the current set of files for version 1.4.x, etc. It does. However, I'm getting an error trying to run rpmbuild against the spec file: $ rpmbuild -ba perl-GnuPG-Interface.spec error: syntax error while parsing == error: /home/lamontp/rpmbuild/SPECS/perl-GnuPG-Interface.spec:15: parseExpressionBoolean returns -1 error: Package has no %description: perl-GnuPG-Interface There is a %description (which works fine without this conditional stuff). Lines 15 is: %if "%gnupg_version" = "1.2" I've double checked the exact command being used to define %gnupg_version and that is working correctly. This makes me think that I've got a syntax error on line 15, but it's such a simple line that I don't see what it could be. If I take out line 15 (and corresponding elements), it works just fine, so it really seems to be something wrong with the %if. Any ideas? BTW: I've already spoken with the package maintainer for this package (in extras) and will be giving him the results of this for EPEL to be able to build this package, too. -- Lamont Peterson <lamont(a)gurulabs.com&gt; Senior Instructor Guru Labs, L.C. [ http://www.GuruLabs.com/ ] NOTE: All messages from this email address should be digitally signed with my 0xDC0DD409 GPG key. It is available on the pgp.mit.edu keyserver as well as other keyservers that sync with MIT's.