Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: SRPMs fail to build in Koji
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Summary: SRPMs fail to build in Koji Product: Fedora Version: 11 Platform: All OS/Version: Linux Status: NEW Severity: urgent Priority: high Component: publican AssignedTo: jfearn@redhat.com ReportedBy: eric@christensenplace.us QAContact: extras-qa@fedoraproject.org CC: jfearn@redhat.com, fedora-docs-list@redhat.com, mmcallis@redhat.com Classification: Fedora
Description of problem: SRPMs fail to build in Koji due to the following error:
Processing files: fedora-security-guide-en-US-1.0-16.fc12.noarch error: Two files on one line: /usr/share/applications/Fedora error: File must begin with "/": Projectfedora-security-guide-en-US.desktop
Version-Release number of selected component (if applicable): 0.44-0.fc11
Possible Fix: Remove the %{?vendoropt} from
desktop-file-install %{?vendoropt} --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{name}.desktop
or remove %{vendor} all together.
I'll be testing this soon to see if I can provide a patch.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #1 from Jeff Fearn jfearn@redhat.com 2009-07-26 23:43:53 EDT --- As I recall, and it has been a while, vendoropt was added during the review of publican as it is a required field. So removing it would seem to be the wrong thing.
It looks to me like your package name is contains "Fedora Project" with a space, this is not a valid package name since spaces are not allowed in package names.
Please attach the spec file so I can take a look at it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #2 from Eric Christensen eric@christensenplace.us 2009-07-27 08:35:38 EDT --- Hi Jeff, Yeah, it's getting the "Fedora Project" from the vendoropt. The package name is Fedora-Security-Guide.
SPEC: http://cvs.fedoraproject.org/viewvc/rpms/fedora-security-guide-en-US/devel/f...
Thanks, Eric
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Elio Maldonado Batiz emaldona@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |emaldona@redhat.com Summary|SRPMs fail to build in Koji |NSS debug-info RPM fails to | |build in Koji
--- Comment #3 from Elio Maldonado Batiz emaldona@redhat.com 2009-07-27 09:39:13 EDT --- Corrected the bug summary to reflect the actual problem.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #4 from Elio Maldonado Batiz emaldona@redhat.com 2009-07-27 09:48:57 EDT --- Created an attachment (id=355276) --> (https://bugzilla.redhat.com/attachment.cgi?id=355276) spec file for review as requested
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Elio Maldonado Batiz emaldona@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #355276|application/octet-stream |text/ascii mime type| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Elio Maldonado Batiz emaldona@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #355276|text/ascii |text/plain mime type| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #5 from Elio Maldonado Batiz emaldona@redhat.com 2009-07-27 09:52:56 EDT --- (In reply to comment #1) See attachment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #6 from Jeff Fearn jfearn@redhat.com 2009-07-27 17:17:43 EDT --- According to https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usa... the vendor tag should only be used for existing packaging that use it ... so you need to remove it from the spec file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #7 from Eric Christensen eric@christensenplace.us 2009-07-27 17:22:07 EDT --- I agree. That SPEC is how Publican generates it. So can it be removed?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Elio Maldonado Batiz emaldona@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kengert@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #8 from Elio Maldonado Batiz emaldona@redhat.com 2009-07-27 18:44:00 EDT --- I can change spec to follow the guidelines but this has nothing to do with the problem I reported. An email sent to release-engineering automatically created this bug report.
----- Original Message ----- From: "Dennis Gregorovic" dgregor@redhat.com To: "Elio Maldonado" emaldona@redhat.com Cc: "David Malcolm" dmalcolm@redhat.com, jorris@redhat.com, kengert@redhat.com, "Scott Haines" shaines@redhat.com, "os-releng-list" os-releng-list@redhat.com Sent: Thursday, July 23, 2009 10:25:06 AM GMT -08:00 US/Canada Pacific Subject: Re: Changed Errata Request [RHBA-2009:8601-02] nss bug fix update
On Mon, 2009-07-20 at 12:16 -0700, Elio Maldonado wrote: <clipped>
Correcting a prior reply and adding Release Enginnering as this problem seems to be caused by the rpm build tools.
The URL for the latest report is https://errata.devel.redhat.com/rpmdiff/show/39254 Clicking on the Symbolic Links brings up https://errata.devel.redhat.com/rpmdiff/show/39254.?result_id=419473 which lists three dangling symbolic links. There are actually fifteen or dangling symbolic links as I was able to verify. Nothing wrong with rpmdiff as it just detects differences with the base for comparison.
Kai and I investigated and found out that even the prior release had this problem with thirty one dangling symbolic links as per his inspection!
I did the same build but on a RHEL-5 system and the problem does not happen there. Of course, the build must be done on a RHEL 4 machine as this is tne intended target but we needed to investigate and rule out differences in the spec file as the cause. The tool doing the copy is /usr/lib/rpm/find-debuginfo.sh. We believe this is a problem with the older older version of the rpm build tools that ships with RHEL-4. The find-debuginfo.sh doesn't seem to handle well the case where some files are copied twice which me must do in order to replace the softoken that normally comes with the latest NSS with the older softokn that's FIPS certified. If you wish more details Kai will be able to explain his diagnostic more clearly than I can.
From our investigation we think that the problem is caused by the older version of the RPM build tools in RHEL-4.
To get this fixed, we would need to get a bug filed against the RPM component and for that bug to get approved. Given that RHEL 4 is nearing its end of life and that this issue does not affect most packages, I think our best course of action is to live with the dangling symlinks. However, if the dangling symlinks present too much of a problem, we can see about getting RPM fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #9 from Elio Maldonado Batiz emaldona@redhat.com 2009-07-27 18:45:58 EDT --- Sorry, it came out that way for lack of hard-coded newlines.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Jeff Fearn jfearn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|NSS debug-info RPM fails to |fedora-security-guide-en-US |build in Koji |goes boom in koji
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Jens Petersen petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |petersen@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #11 from Jens Petersen petersen@redhat.com 2009-07-27 20:14:20 EDT --- I wonder what changed since http://koji.fedoraproject.org/koji/taskinfo?taskID=1416027 ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #12 from Eric Christensen eric@christensenplace.us 2009-07-27 20:20:55 EDT --- Yeah, that's what I was wondering.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #13 from Jeff Fearn jfearn@redhat.com 2009-07-27 20:24:54 EDT --- Clearly the vendor tag has changed from 'fedora' to 'Fedora Project'.
(In reply to comment #7)
I agree. That SPEC is how Publican generates it. So can it be removed?
That vendor stuff was only added because it was a fedora packaging requirement. Since there are no existing books being shipped in Fedora, my solution would be to pull it out entirely from the next version.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #14 from Eric Christensen eric@christensenplace.us 2009-07-27 20:32:48 EDT --- I agree. I don't see the need for it, here.
Is this something in the fedora "brand" or ??? I'd be happy to pull it out of the code and provide a patch if you can point me in the direction of the proper file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Elio Maldonado Batiz emaldona@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|emaldona@redhat.com |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #15 from Jeff Fearn jfearn@redhat.com 2009-07-27 20:41:37 EDT --- (In reply to comment #14)
I agree. I don't see the need for it, here.
Is this something in the fedora "brand" or ??? I'd be happy to pull it out of the code and provide a patch if you can point me in the direction of the proper file.
It's in /usr/share/publican/xsl/dt_htmlsingle_spec.xsl
You need to remove all references to vendor and vendoropt.
Here is a diff:
--- /usr/share/publican/xsl/dt_htmlsingle_spec.xsl 2009-03-27 12:12:05.000000000 +1000 +++ dt_htmlsingle_spec.xsl 2009-07-28 10:37:47.000000000 +1000 @@ -17,8 +17,6 @@
%if %{HTMLVIEW} %define viewer htmlview -%define vendor redhat- -%define vendoropt --vendor="redhat" %endif
Name: <xsl:value-of select="$book-title"/>-xsl:value-of select="$book-lang"/ @@ -66,7 +64,7 @@ Terminal=false EOF
-desktop-file-install %{?vendoropt} --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{name}.desktop +desktop-file-install --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{name}.desktop
%clean rm -rf $RPM_BUILD_ROOT @@ -74,7 +72,7 @@ %files %defattr(-,root,root,-) %doc tmp/<xsl:value-of select="$book-lang"/>/html-desktop/* -%{_datadir}/applications/%{?vendor}%{name}.desktop +%{_datadir}/applications/%{name}.desktop
%changelog<xsl:value-of select="$log"/>
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Jeff Fearn jfearn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Fixed In Version| |1.0 Resolution| |NEXTRELEASE
--- Comment #16 from Jeff Fearn jfearn@redhat.com 2009-07-27 21:07:17 EDT --- This change is in place for the next release.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
--- Comment #17 from Eric Christensen eric@christensenplace.us 2009-07-27 23:47:22 EDT --- Yeah, all is well here... Thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=513907
Jeff Fearn jfearn@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |publican-list@redhat.com Component|publican |publican Version|11 |1.6 Product|Fedora |Publican