https://bugzilla.redhat.com/show_bug.cgi?id=2283798
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co | |m) |
--- Comment #9 from Neal Gompa ngompa13@gmail.com --- (In reply to Jonathan Wright from comment #7)
Thanks for all the feedback. I intend to remove /etc/sysconfig/valkey* from the package. I'm working on a way to cleanly migrate away from this without causing breakages for users.
Side note...we need to update the packaging guidelines to advise against the usage of /etc/sysconfig/* config files in new packages. If someone beats me to this PR I wouldn't complain...
No we don't. /etc/sysconfig config files are intended to be used as a preferred location for services that are not runtime configurable. A lot of services only can be configured at initialization via command line arguments or environment variables (particularly stuff written in Go, in my experience) and this is where you put environmentfiles for that.
Yes, it originates from SysV, but it's as good of a place as any for that.
That said, Valkey should not need such a file, so we should endeavor to get rid of it. I also want to port over some interesting stuff from my work on the openSUSE valkey package to the Fedora one to offer some more flexibility.