https://bugzilla.redhat.com/show_bug.cgi?id=2283798
--- Comment #4 from Joshua Noeske fedora@joshuanoeske.de --- (In reply to Jonathan Wright from comment #3)
Did you use the conversion script(s) (compat package) to move from redis to valkey?
Yes, I did.
I agree that keeping it the same might be ideal and currently the config gets ported - but /etc/sysconfig/valkey will override it for the settings set within it. We could extract those settings from the config and update /etc/sysconfig/valkey with them.
Sounds like a sensible idea, in case it is decided in favour of keeping it at /etc/sysconfig/valkey.
What about some commends inline in the config file mentioning that the settings are set in /etc/sysconfig/valkey? Doing a `sed` to add comments is better in my book than modifying the actual options.
Again, sensible, if /etc/sysconfig/valkey is kept.
But I would argue that changes to the location of socket and pid files are rather uncommon
My thoughts exactly, and why using /etc/sysconfig/valkey seemed like a good option here.
Actually, I rather meant that *upstream* changes of these locations are uncommon. I do think that there are some users, like me, who might want to change the location of these. Furthermore, I personally prefer having all configs in one place instead of having to switch files for them, if it is not due to different `.conf` files in a `.d` directory.
The only notice we could give users would be a message during %post when installing/upgrading the package, but most people don't really watch for messages there.
That could be an additional thing, but a comment in the config file is, at least in my opinion, much more likely to be read.