https://bugzilla.redhat.com/show_bug.cgi?id=2283798
Jonathan Wright jonathan@almalinux.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ngompa13@gmail.co | |m) | |needinfo?(nathans@redhat.co | |m) | |needinfo?(fedora@famillecol | |let.com)
--- Comment #3 from Jonathan Wright jonathan@almalinux.org --- Did you use the conversion script(s) (compat package) to move from redis to valkey? I agree that keeping it the same might be ideal and currently the config gets ported - but /etc/sysconfig/valkey will override it for the settings set within it. We could extract those settings from the config and update /etc/sysconfig/valkey with them.
Using sed against the default config is not the worst thing, but I like to avoid it where I can. It's just my preference to avoid it, but if it leads to poor UX then we should just sed it and be done with it.
What about some commends inline in the config file mentioning that the settings are set in /etc/sysconfig/valkey? Doing a `sed` to add comments is better in my book than modifying the actual options.
But I would argue that changes to the location of socket and pid files are rather uncommon
My thoughts exactly, and why using /etc/sysconfig/valkey seemed like a good option here.
The only notice we could give users would be a message during %post when installing/upgrading the package, but most people don't really watch for messages there.
Would love some feedback from other maintainers here. @ngompa13@gmail.com @nathans@redhat.com @fedora@famillecollet.com