A new fedora-review is being brought to you. With this new version you
- Checks for Ruby packages (incomplete, but started)
- Checks for PHP packages (incomplete, but started)
- Better handling of the sources (handled now directly through rpm)
- Generate all review-related files in a subdirectory
- Add provides/requires to review template
- New report layout
- Support for different bugzilla
- Support for pre-built RPMs
- Possibility to exclude (-x) a test
- Possibility to run a single (-s) test
- A number of bugs fixed
And many more!
We would like to take this opportunity to thanks :
Alec Leamas (who has done the major part of this release)
who have joined our fearless team of developers and of course thanks to
all the people that brought us food^cbug reports and RFE.
Finally, for those of you that would like to see what's going on, feel
free to join the mailing-list:
And because they need karma, the announced updates:
Stanislav & Pierre
On Wed, Jul 4, 2012 at 3:41 PM, Alec Leamas <leamas.alec(a)gmail.com> wrote:
> On 07/04/2012 03:06 PM, Stanislav Ochotnicky wrote:
>> Quoting Alec Leamas (2012-07-04 14:48:45)
>>> I have looked into the f-r functions to assign, comment and login· From
>>> my perspective, they seem "odd" and not really focused on f-r's main
>>> task. Furtjhermore, they clog the CLI interface and are hard to test
>>> requiring some kind of bugzilla test account with unclear implications.
>>> As stated in #67, the already existing dependency python-bugzilla have a
>>> bugzilla tool which can do all this (assign, comment etc) and much, much
>>> more. I find it reasonable to point users to this tool rather than
>>> keeping overlapping functionality in f-r.
>>> Ergo: remove the function assign, login and comment from f-r. However,
>>> removing functionaltiy is not to be taken lightly. So: has anyone strong
>>> feelings about these functions, please speak up, either here or in the
>>> bug #67 :)
>>> A feature branch 'rm-bugz' is in git repo for review.
>> Truth be told, I don't mind removing the code from f-r. However...how
>> about we provide a wrapper for python-bugzilla? Just a simple shell
>> script mind you (which would directly call "bugzilla"). This way we
>> would still provide users with simplified way to assign bugzilla and
>> perhaps do the approval part as well.
>> If anything, I'd like to keep the commandline options there and when
>> invoked they should print out suggested workaround so people who were
>> using them won't be (too) surprised.
>> This is not fair - I know you are going on holiday. Don't worry, I''l
> wait until you're back to complete this discussion :)
> With this said, one of the objectives is to get rid of the command line
> options. They are simply too many, and it's hard to read the help page.
> One idea could be to have to old options 'assign', 'login' etc as invisible
> options, just spitting out some "use bugzilla instead" text. And of course,
> the manpage could have some transition text on this.
> However, expanding the interface with the obvious 'approve' part is going
> in the wrong direction IMHO.
> Also, I'm not really fond of the wrapper idea. The complexity if the CLI
> is not a technical problem, the python
> code is not that hard. The problem is the user interface, and a wrapper
> doesn't change that. It's just more complicated code.
> BTW, my gut feeling is that this part is not that heavily used. Might be
> wrong, but...
> fedorareview mailing list
removing '--assign' would be very bad in IMO, it is a very useful
functionality and very good related to a review tool
I have looked into the f-r functions to assign, comment and login· From
my perspective, they seem "odd" and not really focused on f-r's main
task. Furtjhermore, they clog the CLI interface and are hard to test
requiring some kind of bugzilla test account with unclear implications.
As stated in #67, the already existing dependency python-bugzilla have a
bugzilla tool which can do all this (assign, comment etc) and much, much
more. I find it reasonable to point users to this tool rather than
keeping overlapping functionality in f-r.
Ergo: remove the function assign, login and comment from f-r. However,
removing functionaltiy is not to be taken lightly. So: has anyone strong
feelings about these functions, please speak up, either here or in the
bug #67 :)
A feature branch 'rm-bugz' is in git repo for review.