[Alec Leamas] make-release: small fixes
Started by upstream project "FedoraReview_F17_py2.7" build number 130
originally caused by:
Started by user Alec Leamas
Building remotely on EL6 in workspace <http://jenkins.cloud.fedoraproject.org/job/FedoraReview_EL6_py2.6/ws/>
Checkout:FedoraReview_EL6_py2.6 / <http://jenkins.cloud.fedoraproject.org/job/FedoraReview_EL6_py2.6/ws/> - hudson.remoting.Channel@77f541ef:EL6
Using strategy: Default
Last Built Revision: Revision 29367d9fb772ee52995bb1a0129b0f70e4d005b3 (origin/devel)
Fetching changes from 1 remote Git repository
Fetching upstream changes from http://git.fedorahosted.org/git/FedoraReview.git
Commencing build of Revision f8813e69e83fcd7a508dc4b925d8ad00ebd78ae6 (origin/devel)
Checking out Revision f8813e69e83fcd7a508dc4b925d8ad00ebd78ae6 (origin/devel)
Deleting old artifacts from #172
[FedoraReview_EL6_py2.6] $ /bin/sh -xe /tmp/hudson4104072532599770189.sh
+ ./make_release -b
Using branch: (no branch)
Last commit : f8813e6 make-release: small fixes
./make_release: line 95: syntax error near unexpected token `else'
./make_release: line 95: ` else'
Build step 'Execute shell' marked build as failure
Skipping Cobertura coverage report as build was not UNSTABLE or better ...
Sorry for late reply!
First of all I would say that this looks like a great piece of software :)
May I suggest that you file a RFE bug with this patch attached so that
we have some sort of review process there rather than in the list?
(Handling patches in a bug makes them easier to track).
I have some initial remarks I will write into that that bug once it's there.
I'm attaching patch adding plug-in for checking autotools related
mistakes. In this attempt, only check for some obvious obsolete macros
was added. There are more macros worth to detect (I'll continue adding if
you were interested).
Patch is generated against 'devel' branch. Any comment is welcome! :)
I am trying to write some autotools related checker and I found that there
is a problem with checkers dependencies.
The problem I was facing was that I need in my check the 'buildsrc' to be
initialized. This shouldn't be a problem as each check is automatically
dependant on 'CheckBuildCompleted', am I right?
But when I tried to run something like this:
$ ./try-fedora-review --name tar -s \
.. the try-fedora-review script was unable to prepare the check-system
(mock, review directories, etc.) properly. The problem IMO is that you
have there something like this (in src/FedoraReview/check_base.py):
138 return None
140 is_run = property(lambda self: hasattr(self, 'result'))
The main problem here is IMO that the 'result' attribute is (almost?)
always set to some default value. Even if the test has not been run yet.
Possible solution (that fixes the bad behavior for me) is in attachment
but I'm not very familiar with internals of FedoraReview code. The only
thing I am aware that it is pretty annoying :) - it will always fail on
workdir_setup() call which does workdir lazy initialization but its
requirements are not met yet (due to not-ran checks).
I would also rename the is_run to something like 'finished' or some past
tense form.. if you are interested - I'm able to generate patch.