7:38 a.m.
---
config/Makefile.am | 1 +
config/services/nbd.xml | 6 ++++++
po/POTFILES.in | 1 +
3 files changed, 8 insertions(+)
diff --git a/config/Makefile.am b/config/Makefile.am
index 61021285..956aba51 100644
--- a/config/Makefile.am
+++ b/config/Makefile.am
@@ -204,6 +204,7 @@ CONFIG_FILES = \
services/ms-wbt.xml \
services/murmur.xml \
services/mysql.xml \
+ services/nbd.xml \
services/nfs.xml \
services/nfs3.xml \
services/nmea-0183.xml \
diff --git a/config/services/nbd.xml b/config/services/nbd.xml
new file mode 100644
index 00000000..f02edefc
--- /dev/null
+++ b/config/services/nbd.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<service>
+ <short>NBD</short>
+ <description>Network Block Device (NBD) is a high-performance protocol for
exporting disk images between machines.</description>
+ <port protocol="tcp" port="10809"/>
+</service>
diff --git a/po/POTFILES.in b/po/POTFILES.in
index ed5be3e2..fdd40572 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -137,6 +137,7 @@ config/services/mssql.xml
config/services/ms-wbt.xml
config/services/murmur.xml
config/services/mysql.xml
+config/services/nbd.xml
config/services/nfs3.xml
config/services/nfs.xml
config/services/nmea-0183.xml
--
2.28.0.rc2
10:28 a.m.
New subject: [PATCH firewalld] feat: service: add nbd (Network Block Device)
service
On Thu, Aug 13, 2020 at 01:38:54PM +0100, Richard W.M. Jones wrote:
---
config/Makefile.am | 1 +
config/services/nbd.xml | 6 ++++++
po/POTFILES.in | 1 +
3 files changed, 8 insertions(+)
Thanks! I applied and pushed this upstream:
8f562559dad8 ("feat: service: add nbd (Network Block Device)
service")
The firewalld-devel list is defunct. Can you tell me where you found it
referenced so I can update/remove the reference?
Thanks.
Eric.
10:50 a.m.
New subject: [PATCH firewalld] feat: service: add nbd (Network Block Device)
service
On Thu, Aug 13, 2020 at 11:28:31AM -0400, Eric Garver wrote:
On Thu, Aug 13, 2020 at 01:38:54PM +0100, Richard W.M. Jones wrote:
> ---
> config/Makefile.am | 1 +
> config/services/nbd.xml | 6 ++++++
> po/POTFILES.in | 1 +
> 3 files changed, 8 insertions(+)
Thanks! I applied and pushed this upstream:
8f562559dad8 ("feat: service: add nbd (Network Block Device)
service")
The firewalld-devel list is defunct. Can you tell me where you found it
referenced so I can update/remove the reference?
Sure, it's mentioned on the website:
https://firewalld.org/contribute.html
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
10:52 a.m.
New subject: [PATCH firewalld] feat: service: add nbd (Network Block Device)
service
On Thu, Aug 13, 2020 at 04:50:17PM +0100, Richard W.M. Jones wrote:
On Thu, Aug 13, 2020 at 11:28:31AM -0400, Eric Garver wrote:
> On Thu, Aug 13, 2020 at 01:38:54PM +0100, Richard W.M. Jones wrote:
> > ---
> > config/Makefile.am | 1 +
> > config/services/nbd.xml | 6 ++++++
> > po/POTFILES.in | 1 +
> > 3 files changed, 8 insertions(+)
>
> Thanks! I applied and pushed this upstream:
>
> 8f562559dad8 ("feat: service: add nbd (Network Block Device)
> service")
>
> The firewalld-devel list is defunct. Can you tell me where you found it
> referenced so I can update/remove the reference?
Sure, it's mentioned on the website:
https://firewalld.org/contribute.html
Thanks. I've addressed the issues with the list - it should work again.
No need to remove it with the website now.
11:25 a.m.
New subject: [PATCH firewalld] feat: service: add nbd (Network Block Device)
service
On 8/13/20 10:28 AM, Eric Garver wrote:
On Thu, Aug 13, 2020 at 01:38:54PM +0100, Richard W.M. Jones wrote:
> ---
> config/Makefile.am | 1 +
> config/services/nbd.xml | 6 ++++++
> po/POTFILES.in | 1 +
> 3 files changed, 8 insertions(+)
Thanks! I applied and pushed this upstream:
8f562559dad8 ("feat: service: add nbd (Network Block Device)
service")
Unrelated question - why can't firewalld automatically support an
implied service for every listing in /etc/services, in order to reduce
the number of patches needed to config/services/*.xml which end up
duplicating efforts?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
11:47 a.m.
New subject: [PATCH firewalld] feat: service: add nbd (Network Block Device)
service
On Thu, Aug 13, 2020 at 11:25:18AM -0500, Eric Blake wrote:
On 8/13/20 10:28 AM, Eric Garver wrote:
> On Thu, Aug 13, 2020 at 01:38:54PM +0100, Richard W.M. Jones wrote:
> > ---
> > config/Makefile.am | 1 +
> > config/services/nbd.xml | 6 ++++++
> > po/POTFILES.in | 1 +
> > 3 files changed, 8 insertions(+)
>
> Thanks! I applied and pushed this upstream:
>
> 8f562559dad8 ("feat: service: add nbd (Network Block Device)
> service")
Unrelated question - why can't firewalld automatically support an implied
service for every listing in /etc/services, in order to reduce the number of
patches needed to config/services/*.xml which end up duplicating efforts?
You can do that.
# firewall-cmd --add-port gopher/tcp
success
Internally it uses socket.getservbyname() [1].
Unfortunately listing the ports doesn't do the reverse translation, but
this could be addressed.
# firewall-cmd --list-ports
70/tcp
Services are useful if you want to open a collection of ports or the
service needs conntrack helpers.
[1]: https://docs.python.org/3/library/socket.html#socket.getservbyname
2:37 p.m.
New subject: [PATCH firewalld] feat: service: add nbd (Network Block Device)
service
On Thu, Aug 13, 2020 at 12:47:15PM -0400, Eric Garver wrote:
On Thu, Aug 13, 2020 at 11:25:18AM -0500, Eric Blake wrote:
> On 8/13/20 10:28 AM, Eric Garver wrote:
> > On Thu, Aug 13, 2020 at 01:38:54PM +0100, Richard W.M. Jones wrote:
> > > ---
> > > config/Makefile.am | 1 +
> > > config/services/nbd.xml | 6 ++++++
> > > po/POTFILES.in | 1 +
> > > 3 files changed, 8 insertions(+)
> >
> > Thanks! I applied and pushed this upstream:
> >
> > 8f562559dad8 ("feat: service: add nbd (Network Block Device)
> > service")
>
> Unrelated question - why can't firewalld automatically support an implied
> service for every listing in /etc/services, in order to reduce the number of
> patches needed to config/services/*.xml which end up duplicating efforts?
You can do that.
# firewall-cmd --add-port gopher/tcp
success
Internally it uses socket.getservbyname() [1].
I was initially prompted to provide this patch because I thought that
this would work in public.xml, but it did not:
<service name="nbd"/>
Of course the equivalent <port port="nbd" protocol="tcp"/>
works, but
it seems as if the same information is present in /etc/services
already.
Rich.
Unfortunately listing the ports doesn't do the reverse
translation, but
this could be addressed.
# firewall-cmd --list-ports
70/tcp
Services are useful if you want to open a collection of ports or the
service needs conntrack helpers.
[1]: https://docs.python.org/3/library/socket.html#socket.getservbyname
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
1350
days inactive
1350
days old
firewalld-devel@lists.fedorahosted.org
6 comments
4 participants
participants (4)
-
Eric Blake -
Eric Garver -
Eric Garver -
Richard W.M. Jones