Hi team,
I opened a PR a couple weeks ago - a pretty simple fix to not
consider tickets in diff context or removed lines. Looking for a
review / agreement that this is a good idea, and then we can merge
it.
https://github.com/freeipa/freeipa-tools/pull/72/files
Cheers,
Fraser
URL: https://github.com/freeipa/freeipa/pull/3241
Author: flo-renaud
Title: #3241: ipatests: fix test_backup_and_restore.py::TestBackupAndRestore
Action: opened
PR body:
"""
The test test_backup_and_restore.py::TestBackupAndRestore:: test_full_backup_and_restore_with_selinux_booleans_off requires SELinux to be enabled because it's using getsebool command.
Skip the test if SELinux is disabled.
Fixes: https://pagure.io/freeipa/issue/7970
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3241/head:pr3241
git checkout pr3241
URL: https://github.com/freeipa/freeipa/pull/3255
Author: flo-renaud
Title: #3255: [Backport][ipa-4-7] admintool: don't display log file on errors unless logging is setup
Action: opened
PR body:
"""
This PR was opened automatically because PR #3158 was pushed to master and backport to ipa-4-7 is required.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3255/head:pr3255
git checkout pr3255
URL: https://github.com/freeipa/freeipa/pull/3253
Author: frasertweedale
Title: #3253: [Backport][ipa-4-6] dn: sort AVAs when converting from x509.Name
Action: opened
PR body:
"""
This PR was opened automatically because PR #3212 was pushed to master and backport to ipa-4-6 is required.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3253/head:pr3253
git checkout pr3253
URL: https://github.com/freeipa/freeipa/pull/3252
Author: frasertweedale
Title: #3252: [Backport][ipa-4-7] dn: sort AVAs when converting from x509.Name
Action: opened
PR body:
"""
This PR was opened automatically because PR #3212 was pushed to master and backport to ipa-4-7 is required.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3252/head:pr3252
git checkout pr3252
URL: https://github.com/freeipa/freeipa/pull/3251
Author: rcritten
Title: #3251: [Backport][ipa-4-7] Work around autoremember-build timing issue test failures
Action: opened
PR body:
"""
This PR was opened automatically because PR #3242 was pushed to master and backport to ipa-4-7 is required.
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3251/head:pr3251
git checkout pr3251
URL: https://github.com/freeipa/freeipa/pull/3158
Author: rcritten
Title: #3158: admintool: don't display log file on errors unless logging is setup
Action: opened
PR body:
"""
The admintool will display the message when something goes wrong:
See %s for more information" % self.log_file_name
This is handy except when finally logging setup is not done
yet so the log file doesn't actually get written to.
This can happen if validation catches and raises an exception.
The workaround is to save off and remove the log_file_name value
before calling validation, then restore it if successful. This will
suppress the above error message.
Fixes: https://pagure.io/freeipa/issue/7952
Signed-off-by: Rob Crittenden <rcritten(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3158/head:pr3158
git checkout pr3158
URL: https://github.com/freeipa/freeipa/pull/3242
Author: rcritten
Title: #3242: Work around autoremember-build timing issue test failures
Action: opened
PR body:
"""
This is testing that by disabling modify-ops in the automember
plugin that one can add/remove members and properly exercise
automember rebuild.
This is unrelated to the rebuild directly so I moved where that
is executed and that seems to have settled the test down.
I filed https://bugzilla.redhat.com/show_bug.cgi?id=1718397 against
389-ds to investigate.
Signed-off-by: Rob Crittenden <rcritten(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3242/head:pr3242
git checkout pr3242