[freeipa PR#2766][opened] Fix ipatests test_ntp_options to configure the firewall where needed
by t-woerner
URL: https://github.com/freeipa/freeipa/pull/2766
Author: t-woerner
Title: #2766: Fix ipatests test_ntp_options to configure the firewall where needed
Action: opened
PR body:
"""
The firewall has not been configured before replicas and after masters
have been installed using the command line tools and not the available
methods from tasks. This resulted in failed tests as for example in
test_replica_promotion_without_ntp.
Configuration of the firewall has been added to the methods
install_replica, test_replica_promotion_with_ntp_options and
test_replica_promotion_without_ntp.
In the case of testing command line options that may not be used together
for replica installation, a comment has been added that it is theoretical
no need to configure the firewall in this case, because the installation
will not succeed. But it has been added to make sure that the test will
not fail because of the missing firewall configuration if the options will
not conflict. This is the method test_replica_promotion_with_ntp_options.
In the case where conflicting command line options are tested for the
server installation a comment has been added that it is not needed to
configure the firewall as it is configured after successful server
installation normally. This is the method
test_server_client_install_mixed_options.
tasks.uninstall_master is used to cleanup replica installations and test
remains, therefore the firewall configuration is reverted afterwards again.
See: https://pagure.io/freeipa/issue/7719
Signed-off-by: Thomas Woerner <twoerner(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2766/head:pr2766
git checkout pr2766
4 years, 9 months