URL: https://github.com/freeipa/freeipa/pull/5808 Author: rcritten Title: #5808: Catch ValueError when trying to retrieve existing credentials Action: opened
PR body: """ For WebUI users, catch ValueError from get_credentials_if_valid() if their associated credentials cache is expired or missing. This will in turn return an HTTP 401 so they can re-authenticate.
This was an uncaught exception due to changes made to sweep up expired ccaches (https://pagure.io/freeipa/issue/8589)
https://pagure.io/freeipa/issue/8873
Signed-off-by: Rob Crittenden rcritten@redhat.com
It's putting the cart before the horse but https://github.com/freeipa/freeipa/pull/5637 will eventually exercise this.
For reviewers: I did the least possible change. We could also not play with a creds variable and do the returns directly inside the exception but I found the current code easier to follow. YMMV. """
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/5808/head:pr5808 git checkout pr5808
URL: https://github.com/freeipa/freeipa/pull/5808 Author: rcritten Title: #5808: Catch ValueError when trying to retrieve existing credentials Action: closed
To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/5808/head:pr5808 git checkout pr5808
freeipa-devel@lists.fedorahosted.org