few things which need revert
by Rakesh Pandit
commit ee5048e2ea7f8b5a4fbf54c80cda9bdbc5e483e8
Author: Saleem Ansari <saleem(a)sansari.pnq.redhat.com>
Date: Mon Feb 8 17:36:18 2010 +0530
.project, .pydevproject: Added PyDev configuration files
commit 61258e6bf4100d7555ab6dc818d508b28af51ca1
Author: Saleem Ansari <tuxdna(a)gmail.com>
Date: Mon Feb 8 18:22:36 2010 +0530
GachApplication.py:
* added exception class NoFilesInBug()
* added option print_to_stdout to run() method
GachReporter.py:
* fixed singleton implementation bug
* added printToFile() method
GachReviewer.py:
* changed the signature of runRpmlint()
__init__.py:
* added new file
gach:
* added output option ( -o / --output ) and made related changes
These need to be reverted and reviewed. First one has files which are
not supposed to go to tree. Second, one is not a minor fix and never
received a +1.
Everything needs to get reviewed before changes are pushed to tree
(except way too minimal changes like the import fix) and every commit
even if it is trivial fix needs to get posted here.
I will revert them soon, as soon as I get some time.
Thanks,
--
Rakesh Pandit
https://fedoraproject.org/wiki/User:Rakesh
freedom, friends, features, first
14 years, 2 months
Proposal for enhancement
by Saleem Ansari
---------- Forwarded message ----------
From: tuxdna <tuxdna(a)gmail.com>
Date: Tue, Feb 9, 2010 at 7:28 PM
Subject: Re: Proposal for enhancement
To: Rakesh Pandit <rakesh.pandit(a)gmail.com>
Hi Rakesh,
I have prepared a web interface in django using gach API. I feel that the
entire set of files ( except COPYING and README.devel ) in root directory of
the codebase should be moved to a different folder ( gach/ ) so that the
actual gach API becomes a separate python module.
Parallel to this folder ( in the root folder itself ), will be a web/ folder
which will serve as the codebase for web application code.
So the directory structure will look like this:
.
├── COPYING
├── gach
│ ├── BinaryFilesCheck.py
│ ├── BuildLog.py
│ ├── BuildRootCheck.py
│ ├── Check.py
│ ├── ExcessDocFileCheck.py
│ ├── Filter.py
│ ├── gach
│ ├── GachApplication.py
│ ├── GachBugzillaFeeder.py
│ ├── GachBugzillaReporter.py
│ ├── GachBuilder.py
│ ├── GachFeeder.py
│ ├── GachFileReporter.py
│ ├── GachGenericFeeder.py
│ ├── GachKojiBuilder.py
│ ├── GachPkg.py
│ ├── GachReporter.py
│ ├── GachReviewer.py
│ ├── GachRPMReviewer.py
│ ├── GachSpecReviewer.py
│ ├── GachSrcRPMReviewer.py
│ ├── GachUtils.py
│ ├── __init__.py
│ ├── LogWarningCheck.py
│ ├── Pkg.py
│ ├── ReviewSpec.py
│ ├── RPMCheck.py
│ ├── SampleCheck.py
│ ├── SpecCheck.py
│ ├── Spec.py
│ └── SrcRPMCheck.py
├── gach-driver.sh
├── gach_feeder.cron
├── README.devel
└── web
├── feeder
│ ├── __init__.py
│ ├── management
│ │ ├── commands
│ │ │ ├── gach_process_job.py
│ │ │ └── __init__.py
│ │ └── __init__.py
│ ├── models.py
│ ├── tests.py
│ └── views.py
├── forms.py
├── __init__.py
├── manage.py
├── media
│ ├── ajax.js
│ ├── images
│ │ └── ajax.gif
│ └── style.css
├── settings.py
├── templates
│ ├── base.html
│ ├── feeder.html
│ ├── index.html
│ └── list.html
├── urls.py
└── views.py
8 directories, 55 files
DIFF STAT:
.pydevproject | 3 +-
BinaryFilesCheck.py | 100 ---------------
BuildLog.py | 55 --------
BuildRootCheck.py | 99 ---------------
Check.py | 53 --------
ExcessDocFileCheck.py | 72 -----------
Filter.py | 84 ------------
GachApplication.py | 178 --------------------------
GachBugzillaFeeder.py | 101 ---------------
GachBugzillaReporter.py | 108 ----------------
GachBuilder.py | 36 ------
GachFeeder.py | 33 -----
GachFileReporter.py | 69 ----------
GachGenericFeeder.py | 105 ---------------
GachKojiBuilder.py | 156 -----------------------
GachPkg.py | 113 -----------------
GachRPMReviewer.py | 44 -------
GachReporter.py | 176 --------------------------
GachReviewer.py | 96 --------------
GachSpecReviewer.py | 42 ------
GachSrcRPMReviewer.py | 43 -------
GachUtils.py | 118 -----------------
LogWarningCheck.py | 59 ---------
Pkg.py | 70 ----------
RPMCheck.py | 49 -------
ReviewSpec.py | 218 --------------------------------
SampleCheck.py | 44 -------
Spec.py | 323
-----------------------------------------------
SpecCheck.py | 49 -------
SrcRPMCheck.py | 49 -------
30 files changed, 2 insertions(+), 2743 deletions(-)
Since the patch is large, I am attaching it with this email.
All this is required to keep the actual gach API and the gach web codebase
separate.
What are your suggestions in this regard?
Thanks and regards,
Saleem
14 years, 2 months
Proposal for enhancement
by Saleem Ansari
Hi list,
Two issues which i feel need to be addressed:
1 - Currently gach prints all the report information onto stdout. I
suggest that there should be a command-line option which we can use to
specify a file in which this report will be generated.
command line option: -r <report file name> | --reportfile <report file name>
2 - The class GachReporter in GachReport.py is supposed to be
singleton, but its __init__() method always resets the instance
variables, which should not happen. This causes the bug "Need to check
later why this is needed" in GachApplication.run()
I have attached a patch for both of the above issues.
Diff summary:
BinaryFilesCheck.py | 37 ++++++++++++-----------
BuildRootCheck.py | 76 ++++++++++++++++++++++++------------------------
ExcessDocFileCheck.py | 16 +++++-----
GachApplication.py | 24 +++++++++++----
GachReporter.py | 18 +++++++++--
GachReviewer.py | 5 +--
LogWarningCheck.py | 8 ++--
SampleCheck.py | 14 ++++----
gach | 20 ++++++++++++-
9 files changed, 129 insertions(+), 89 deletions(-)
Do let me know if the patch is appropriate.
Thanks and regards,
Saleem
14 years, 2 months